coolaj86
/
acme-dns-01-cloudflare.js
1
0
Fork 0
Code Issues 2 Pull Requests 1 Releases Wiki Activity

Fix .set/.get #1

New Issue
Open
opened 2019-06-23 18:37:59 +00:00 by Ghost · 1 comment
Ghost commented 2019-06-23 18:37:59 +00:00
Copy Link

Tests complain with:

dns-01 challenge.get() returned 'KmlN8cfb-usOjCLyKAEu8wZ1pythkz8veFk2BVlLVSY', which does not match the dnsAuthorization (keyAuthDigest) saved with challenge.set(), which was 'QzQsFeFW2vd5QfR4sdqzr2i8phd5xGWJ4ttCB_gL4EM'

Really unsure what's wrong since data.challenge.dnsAuthorization is being used. But seems to be wrong anyways. Maybe multiple records with same name?

Tests complain with: ``` dns-01 challenge.get() returned 'KmlN8cfb-usOjCLyKAEu8wZ1pythkz8veFk2BVlLVSY', which does not match the dnsAuthorization (keyAuthDigest) saved with challenge.set(), which was 'QzQsFeFW2vd5QfR4sdqzr2i8phd5xGWJ4ttCB_gL4EM' ``` Really unsure what's wrong since `data.challenge.dnsAuthorization` is being used. But seems to be wrong anyways. Maybe multiple records with same name?
coolaj86 commented 2019-07-31 03:53:53 +00:00
Owner
Copy Link

*.foo.example.co.uk and foo.example.co.uk will BOTH set TXT records for foo.example.com.

This makes sense because * isn't a real domain, it's an alias, so it has to be set on the real domain instead.

You need to set BOTH records, not overwrite the record, and check that the record you return is the correct record based on its content, not the domain name (since a domain can have an infinite number of TXT records).

`*.foo.example.co.uk` and `foo.example.co.uk` will BOTH set TXT records for `foo.example.com`. This makes sense because `*` isn't a real domain, it's an alias, so it has to be set on the real domain instead. You need to set BOTH records, not _overwrite_ the record, and check that the record you return is the correct record based on its _content_, not the domain name (since a domain can have an infinite number of TXT records).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/acme-dns-01-cloudflare.js#1
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?