coolaj86
/
acme-dns-01-cloudflare.js
1
0
Fork 0
Code Issues 2 Pull Requests 1 Releases Wiki Activity

Deprecate in repo readme #3

New Issue
Open
opened 2019-10-01 13:24:44 +00:00 by Ghost · 1 comment
Ghost commented 2019-10-01 13:24:44 +00:00
Copy Link

According to NPM, this repo is now deprecated, and https://github.com/nodecraft/acme-dns-01-cloudflare should be used instead.

Maybe lock down this repo for further issues/PRs, and add in the readme a link to the other repo, to avoid confusion? Like, I already did a PR to this before I realized I'm making a PR against the wrong repo, so now my time was in vain.

According to NPM, this repo is now deprecated, and https://github.com/nodecraft/acme-dns-01-cloudflare should be used instead. Maybe lock down this repo for further issues/PRs, and add in the readme a link to the other repo, to avoid confusion? Like, I already did a PR to this before I realized I'm making a PR against the wrong repo, so now my time was in vain.
Ghost changed title from Deprecate in repo to Deprecate in repo readme 2019-10-01 13:25:03 +00:00
coolaj86 commented 2019-10-03 20:20:07 +00:00
Owner
Copy Link

Actually, I do want a pure JavaScript implementation of this (not ECMAScript / TypeScript), so it's not deprecated, but NodeCraft was the first to publish (coincidental simultaneous work) and uses CloudFlare regularly.

However, I do plan to eventually release pure JS implementations for each of the modules, so your contribution may not have been in vain.

My inbox is flooded with messages, and we just had our baby a few months ago, and I just switched jobs a few weeks ago, so unfortunately I didn't see your PR come in, otherwise I probably have reviewed, thanked you, and pulled it in.

Actually, I do want a pure JavaScript implementation of this (not ECMAScript / TypeScript), so it's not _deprecated_, but NodeCraft was the first to publish (coincidental simultaneous work) and uses CloudFlare regularly. However, I do plan to eventually release pure JS implementations for each of the modules, so your contribution may not have been in vain. My inbox is flooded with messages, and we just had our baby a few months ago, and I just switched jobs a few weeks ago, so unfortunately I didn't see your PR come in, otherwise I probably have reviewed, thanked you, and pulled it in.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/acme-dns-01-cloudflare.js#3
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?