coolaj86/acme.js-ARCHIVED
2
1
Fork 0
Code Issues 4 Pull Requests 3 Releases Activity

It not work for wildcard names #12

New Issue
Closed
opened 2019-02-03 03:45:02 +00:00 by Ghost · 1 comment
Ghost commented 2019-02-03 03:45:02 +00:00
Copy Link

It is a great library for letsencryt with node.

Recently I tried to make it work with wildcard names and it failed.

It will fail with dns-01 challenge testing when getting a wildcard domain certifications.

But I found that it works when changing here:

https://git.coolaj86.com/coolaj86/acme-v2.js/src/branch/master/node.js#L49

, 'dns-01': function (me, auth) {

    // var hostname = ACME.challengePrefixes['dns-01'] + '.' + auth.hostname;
    // ==>
    var hostname = ACME.challengePrefixes['dns-01'] + '.' + auth.hostname.replace(/^\*\./, '');
    return me._dig({
      type: 'TXT'
    , name: hostname
    }).then(function (ans) {
It is a great library for letsencryt with node. Recently I tried to make it work with wildcard names and it failed. It will fail with `dns-01` challenge testing when getting a wildcard domain certifications. But I found that it works when changing here: https://git.coolaj86.com/coolaj86/acme-v2.js/src/branch/master/node.js#L49 ```js , 'dns-01': function (me, auth) { // var hostname = ACME.challengePrefixes['dns-01'] + '.' + auth.hostname; // ==> var hostname = ACME.challengePrefixes['dns-01'] + '.' + auth.hostname.replace(/^\*\./, ''); return me._dig({ type: 'TXT' , name: hostname }).then(function (ans) { ```
coolaj86 commented 2019-02-05 05:31:55 +00:00
Owner
Copy Link

Thanks. I published the update as v1.5.2

Thanks. I published the update as v1.5.2
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
coolaj86
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coolaj86/acme.js-ARCHIVED#12
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?