var dryrun = true; #20

New Issue

Ghost · 2019-04-30T09:14:00Z

Ghost commented

2019-04-30 09:14:00 +00:00

in node.js, at line 332, it says "var dryrun = true;", hard coded, since 2019-04-03, v1.7.1, e5e7377712

That cannot have been intended for release, can it?

in node.js, at line 332, it says "var dryrun = true;", hard coded, since 2019-04-03, v1.7.1, e5e7377712f62d36660a27cf0cf96fa8d45d45e4 That cannot have been intended for release, can it?

coolaj86 commented

2019-04-30 14:19:03 +00:00

Yes. The dryrun happens before the actual challenge. If the dryrun fails, the real challenge will also fail.

See coolaj86/acme-v2.js#4

The option skipChallengeTest will skip the dry run:

https://git.coolaj86.com/coolaj86/acme-v2.js/src/branch/master/node.js#L294

Yes. The dryrun happens before the actual challenge. If the dryrun fails, the real challenge will also fail. See https://git.coolaj86.com/coolaj86/acme-v2.js/issues/4 The option `skipChallengeTest` will skip the dry run: https://git.coolaj86.com/coolaj86/acme-v2.js/src/branch/master/node.js#L294

coolaj86 closed this issue

2019-04-30 14:19:09 +00:00

Sign in to join this conversation.

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/acme.js-ARCHIVED#20