Does not work in web worker #5

New Issue

Ghost · 2020-06-12T08:17:58Z

Ghost commented

2020-06-12 08:17:58 +00:00

error message:

Uncaught ReferenceError: window is not defined
browser-atob.js:44

error message: ``` Uncaught ReferenceError: window is not defined browser-atob.js:44 ```

coolaj86 commented

2020-06-12 17:00:39 +00:00

Can you propose a solution?

Is atob defined on... self or whatever it is that workers have?

Does globalThis work?

Can you propose a solution? Is `atob` defined on... `self` or whatever it is that workers have? Does `globalThis` work?

Ghost commented

2020-06-13 06:54:59 +00:00

module.exports = function _atob(str) {
  return atob(str)
}

just with the function name works for me (both browser and web work)

reference:
https://caniuse.com/#search=atob

https://github.com/hughsk/atob-lite/blob/master/atob-browser.js

``` module.exports = function _atob(str) { return atob(str) } ``` just with the function name works for me (both browser and web work) reference: https://caniuse.com/#search=atob https://github.com/hughsk/atob-lite/blob/master/atob-browser.js

coolaj86 commented

2020-06-14 03:25:54 +00:00

How about just put var window = self; in your WebWorker script?

So many things depend on this and it is so abused by things like webpack and browserify, etc, etc that I don't want to rock the boat.

How about just put `var window = self;` in your WebWorker script? So many things depend on this and it is so abused by things like webpack and browserify, etc, etc that I don't want to rock the boat.

coolaj86 commented

2020-06-14 03:28:57 +00:00

I could release a version 3 that uses something like:

'undefined' !== typeof window ? window : 'undefined' !== typeof self ? self : golablThis

I could release a version 3 that uses something like: ```js 'undefined' !== typeof window ? window : 'undefined' !== typeof self ? self : golablThis ```

Ghost commented

2020-06-14 23:48:00 +00:00

That seems make sense. Thanks!

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/atob.js#5