Added alphabet check before decoding #7

Ghost · 2021-03-04T05:12:49Z

Ghost commented

2021-03-04 05:12:49 +00:00

First-time contributor

Resolves #6

Linear time complexity solution, guaranteed to work.

Alternatively you could check the expected length of the output matches but then you will have to deal with edge cases (such as the test case given).

Resolves #6 Linear time complexity solution, guaranteed to work. Alternatively you could check the expected length of the output matches but then you will have to deal with edge cases (such as the test case given).

Ghost added 1 commit 2021-03-04 05:12:50 +00:00

47351c126d

Added alphabet check before decoding

coolaj86 commented

2021-03-10 19:16:26 +00:00

I'm open to updating this, but it's so old an relied on so heavily by so many projects and devices (including the AppleTV SDK) that I think I'll have to do a major version bump even for a bugfix.

You could actually make this quite a bit faster by checking character ranges.

// off the cuff, not correct code
if (!(x >= "a".toCharCode() && x <= "Z".toCharCode() /* && range of symbols*/)) {
   throw Error('barf');
}

Also, I want to stick with Vanilla JavaScript (ES5) so that, for those who update, they don't have to introduce a compiler or change their other build tools.

I'm open to updating this, but it's so old an relied on so heavily by so many projects and devices (including the AppleTV SDK) that I think I'll have to do a major version bump even for a bugfix. You could actually make this quite a bit faster by checking character ranges. ```js // off the cuff, not correct code if (!(x >= "a".toCharCode() && x <= "Z".toCharCode() /* && range of symbols*/)) { throw Error('barf'); } ``` Also, I want to stick with Vanilla JavaScript (ES5) so that, for those who update, they don't have to introduce a compiler or change their other build tools.

Ghost added 1 commit 2021-03-11 13:26:24 +00:00

ca3678cddb Range check for b64 Alphabet

Ghost added 1 commit 2021-03-11 13:27:27 +00:00

34dd70eb8d Range check for b64 Alphabet

Ghost commented

2021-03-11 13:43:12 +00:00

First-time contributor

I changed it to a range check (good advice).

I think I've changed it to ES5, but I'm not super familiar with what is ES5 and what came after so I could have missed things.

We use a package called localflare to run Cloudflare Workers for testing which depends on this package. I discovered the different behavior between atob and buffer when looking at b64url in our code.

For us making the change is beneficial because the closer we can get our environment to Cloudflare the better (and I'm really against Node's behavior on this) but I also understand being cautious about versioning. I'll just have to make a PR to localflare to update their version :)

(Wrangler is on our roadmap but it will be a little while before we get there)

I changed it to a range check (good advice). I think I've changed it to ES5, but I'm not super familiar with what is ES5 and what came after so I could have missed things. We use a package called localflare to run Cloudflare Workers for testing which depends on this package. I discovered the different behavior between `atob` and `buffer` when looking at b64url in our code. For us making the change is beneficial because the closer we can get our environment to Cloudflare the better (and I'm really against Node's behavior on this) but I also understand being cautious about versioning. I'll just have to make a PR to localflare to update their version :) (Wrangler is on our roadmap but it will be a little while before we get there)

coolaj86 commented

2021-03-11 19:13:46 +00:00

Thanks.
I've scheduled review, update, merge, and publish this on Saturday.

Thanks. I've scheduled review, update, merge, and publish this on Saturday.

This pull request is broken due to missing fork information.

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/atob.js#7