typo and other fixes

This commit is contained in:
AJ ONeal 2019-05-06 11:27:00 -06:00
parent 274e47b726
commit 9a89e43263
2 changed files with 7 additions and 8 deletions

View File

@ -110,15 +110,12 @@ CSR._sign = function csrEcSig(jwk, request) {
CSR._toDer = function encode(opts) { CSR._toDer = function encode(opts) {
var sty; var sty;
var sig;
if (/^EC/i.test(opts.kty)) { if (/^EC/i.test(opts.kty)) {
// 1.2.840.10045.4.3.2 ecdsaWithSHA256 (ANSI X9.62 ECDSA algorithm with SHA256) // 1.2.840.10045.4.3.2 ecdsaWithSHA256 (ANSI X9.62 ECDSA algorithm with SHA256)
sty = ASN1('30', ASN1('06', '2a8648ce3d040302')); sty = ASN1('30', ASN1('06', '2a8648ce3d040302'));
sig = ASN1.BitStr(ASN1('30', Enc.bufToHex(opts.signature)));
} else { } else {
// 1.2.840.113549.1.1.11 sha256WithRSAEncryption (PKCS #1) // 1.2.840.113549.1.1.11 sha256WithRSAEncryption (PKCS #1)
sty = ASN1('30', ASN1('06', '2a864886f70d01010b'), ASN1('05')); sty = ASN1('30', ASN1('06', '2a864886f70d01010b'), ASN1('05'));
sig = ASN1.BitStr(Enc.bufToHex(opts.signature));
} }
return ASN1('30' return ASN1('30'
// The Full CSR Request Body // The Full CSR Request Body
@ -126,7 +123,7 @@ CSR._toDer = function encode(opts) {
// The Signature Type // The Signature Type
, sty , sty
// The Signature // The Signature
, sig , ASN1.BitStr(Enc.bufToHex(opts.signature))
); );
}; };

View File

@ -219,10 +219,12 @@ Keypairs._sign = function (opts, payload) {
).then(function (signature) { ).then(function (signature) {
signature = new Uint8Array(signature); // ArrayBuffer -> u8 signature = new Uint8Array(signature); // ArrayBuffer -> u8
// This will come back into play for CSRs, but not for JOSE // This will come back into play for CSRs, but not for JOSE
if ('EC' === opts.jwk.kty && /x509/i.test(opts.format)) { if ('EC' === opts.jwk.kty && /x509|asn1/i.test(opts.format)) {
signature = Keypairs._ecdsaJoseSigToAsn1Sig(signature); return Keypairs._ecdsaJoseSigToAsn1Sig(signature);
} else {
// jose/jws/jwt
return signature;
} }
return signature;
}); });
}); });
}; };
@ -298,7 +300,7 @@ Keypairs._ecdsaJoseSigToAsn1Sig = function (bufsig) {
if (len >= 0x80) { head.push(0x81); } if (len >= 0x80) { head.push(0x81); }
head.push(len); head.push(len);
return Uint8Array.from(head.concat([0x02, r.length], r, [0x02, s.byteLength], s)); return Uint8Array.from(head.concat([0x02, r.length], r, [0x02, s.length], s));
}; };
function setTime(time) { function setTime(time) {