coolaj86
/
dig.js
1
0
Fork 0
Code Issues Pull Requests Releases Activity

fix false positive on 0x20 failure

This commit is contained in:
AJ ONeal 2017-10-02 16:56:31 -06:00
parent e1d0322ed2
commit f8b2fb7ff8
1 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
bin/dig.js
View File

@ -186,6 +186,7 @@ cli.main(function (args, cli) {
cli.onMessage = function (nb) { cli.onMessage = function (nb) {
var packet = dnsjs.DNSPacket.parse(nb.buffer.slice(nb.byteOffset, nb.byteOffset + nb.byteLength)); var packet = dnsjs.DNSPacket.parse(nb.buffer.slice(nb.byteOffset, nb.byteOffset + nb.byteLength));
var fail0x20;
if (packet.id !== query.id) { if (packet.id !== query.id) {
console.log('ignoring packet for ', packet.question[0].name); console.log('ignoring packet for ', packet.question[0].name);
@ -197,6 +198,13 @@ cli.main(function (args, cli) {
console.log(packet); console.log(packet);
} }
packet.question.forEach(function (q) {
// if (-1 === q.name.indexOf(cli.casedQuery))
if (q.name !== cli.casedQuery) {
fail0x20 = q.name;
}
});
if (!cli.norecase && !cli.recase) { if (!cli.norecase && !cli.recase) {
[ 'question', 'answer', 'authority', 'additional' ].forEach(function (group) { [ 'question', 'answer', 'authority', 'additional' ].forEach(function (group) {
(packet[group]||[]).forEach(function (a) { (packet[group]||[]).forEach(function (a) {
@ -225,14 +233,12 @@ cli.main(function (args, cli) {
}); });
} }
packet.question.forEach(function (q) { if (fail0x20) {
// if (-1 === q.name.indexOf(cli.casedQuery)) console.warn("");
if (q.name !== cli.casedQuery) { console.warn(";; Warning: DNS 0x20 security not implemented (or packet spoofed). Queried '" + cli.casedQuery + "' but got response for '" + fail0x20 + "'.");
console.warn(""); console.warn("");
console.warn(";; Warning: DNS 0x20 security not implemented (or packet spoofed). Queried '" + cli.casedQuery + "' but got response for '" + q.name + "'."); }
console.warn("");
}
});
console.log(';; Got answer:'); console.log(';; Got answer:');
dig.logQuestion(packet); dig.logQuestion(packet);