From a1eca4f1a58ccd04d684d743e24a5cc185433aea Mon Sep 17 00:00:00 2001 From: AJ ONeal Date: Fri, 3 Nov 2017 12:23:56 -0600 Subject: [PATCH] clarify (kinda) vanity nameserver comment --- lib/dns-store.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/dns-store.js b/lib/dns-store.js index 547385c..1462354 100644 --- a/lib/dns-store.js +++ b/lib/dns-store.js @@ -407,6 +407,9 @@ module.exports.query = function (input, query, cb) { console.log("It's NS"); // If it's a vanity NS, it's not a valid NS for lookup + // NOTE: I think that the issue here is EXTERNAL vs INTERNAL vanity NS + // We _should_ reply for EXTERNAL vanity NS... but not when it's listed on the SOA internally? + // It's surrounding the problem of what if I do sub domain delegation to the same server. if (-1 === db.primaryNameservers.indexOf(r.data.toLowerCase())) { console.log("It's a vanity NS"); return false;