coolaj86
/
digd.js
2
1
Fork 1
Code Issues 7 Pull Requests 2 Releases Activity

better error handling

This commit is contained in:
AJ ONeal 2018-01-29 15:01:10 -07:00
parent 9dfa8ed323
commit f479c55501
2 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/httpd.js
View File

@ -277,6 +277,10 @@ module.exports.create = function (cli, engine/*, dnsd*/) {
res.send({ error: { message: err.message } }); res.send({ error: { message: err.message } });
return; return;
} }
if (!record) {
res.send({ error: { message: "no record with id '" + id + "' found" } });
return;
}
if ('SOA' === record.type) { if ('SOA' === record.type) {
// TODO be strict about what can be edited // TODO be strict about what can be edited

19
lib/public/js/app.js
View File

@ -397,16 +397,6 @@
var id = $qs('.js-record-id', $pel).value; var id = $qs('.js-record-id', $pel).value;
var existingRecord = cache.recordsMap[id]; var existingRecord = cache.recordsMap[id];
delete cache.recordsMap[id];
cache.records.some(function (r, i) {
if (r === existingRecord) {
cache.records.splice(i, 1);
return true;
}
});
renderRecords();
return window.fetch( return window.fetch(
'/api/records/' + id '/api/records/' + id
, { method: 'DELETE' , { method: 'DELETE'
@ -422,6 +412,15 @@
window.alert(data.error.message); window.alert(data.error.message);
return; return;
} }
delete cache.recordsMap[id];
cache.records.some(function (r, i) {
if (r === existingRecord) {
cache.records.splice(i, 1);
return true;
}
});
renderRecords();
console.log('result:', data); console.log('result:', data);
}); });
}); });