Doesn't respond with SERVFAIL when throwing an error #2

Nueva incidencia

coolaj86 · 2017-11-02T17:55:51Z

coolaj86 comentado

2017-11-02 17:55:51 +00:00

Propietario

When an error is thrown (such as malformed json data that cannot be written as binary), the server should respond with SERVFAIL

Here's how to observe this error:

Create a db file with bad data (the required field "exchange" is missing from the MX record):

fail.json

{
  "primaryNameservers": [ "localhost" ]
, "domains": [ { "id": "example.com" } ]
, "records": [

    { "zone": "example.com", "name": "example.com", "tld": "com", "sld": "example", "sub": ""
    , "type": "MX", "priority": 10, "MISSING-exchange": "mxa.example.org" }
  ]
}

Installing and running the digd.js server:

git clone https://git.coolaj86.com/coolaj86/digd.js.git

pushd digd.js/

npm install

node bin/digd.js --port 5353 --input fail.json +norecurse

In another terminal, while the server is running:

dig @localhost -p 5353 MX example.com

The server throws an error and nothing comes back. Instead a SERVFAIL should come back.

Note: we should also validate the date... but we should correct the server's handling of error cases before we correct the case that causes an error.

When an error is thrown (such as malformed json data that cannot be written as binary), the server should respond with SERVFAIL Here's how to observe this error: Create a db file with bad data (the required field "exchange" is missing from the MX record): `fail.json` ```json { "primaryNameservers": [ "localhost" ] , "domains": [ { "id": "example.com" } ] , "records": [ { "zone": "example.com", "name": "example.com", "tld": "com", "sld": "example", "sub": "" , "type": "MX", "priority": 10, "MISSING-exchange": "mxa.example.org" } ] } ``` Installing and running the digd.js server: ```bash git clone https://git.coolaj86.com/coolaj86/digd.js.git pushd digd.js/ npm install node bin/digd.js --port 5353 --input fail.json +norecurse ``` In another terminal, while the server is running: ```bash dig @localhost -p 5353 MX example.com ``` The server throws an error and nothing comes back. Instead a SERVFAIL should come back. Note: we should also validate the date... but we should correct the server's handling of error cases _before_ we correct the case that causes an error.

Inicie sesión para unirse a esta conversación.

Sin etiquetas

Sin Milestone

No asignados

1 participantes

Notificaciones

Fecha de vencimiento

La fecha de vencimiento es inválida o está fuera de rango. Por favor utilice el formato 'aaaa-mm-dd'.

Sin fecha de vencimiento.

Dependencias

No se han establecido dependencias.

Referencia: coolaj86/digd.js#2