Doesn't respond with SERVFAIL when throwing an error #2

새로운 이슈

coolaj86 · 2017-11-02T17:55:51Z

coolaj86 코멘트됨,

2017-11-02 17:55:51 +00:00

소유자

When an error is thrown (such as malformed json data that cannot be written as binary), the server should respond with SERVFAIL

Here's how to observe this error:

Create a db file with bad data (the required field "exchange" is missing from the MX record):

fail.json

{
  "primaryNameservers": [ "localhost" ]
, "domains": [ { "id": "example.com" } ]
, "records": [

    { "zone": "example.com", "name": "example.com", "tld": "com", "sld": "example", "sub": ""
    , "type": "MX", "priority": 10, "MISSING-exchange": "mxa.example.org" }
  ]
}

Installing and running the digd.js server:

git clone https://git.coolaj86.com/coolaj86/digd.js.git

pushd digd.js/

npm install

node bin/digd.js --port 5353 --input fail.json +norecurse

In another terminal, while the server is running:

dig @localhost -p 5353 MX example.com

The server throws an error and nothing comes back. Instead a SERVFAIL should come back.

Note: we should also validate the date... but we should correct the server's handling of error cases before we correct the case that causes an error.

When an error is thrown (such as malformed json data that cannot be written as binary), the server should respond with SERVFAIL Here's how to observe this error: Create a db file with bad data (the required field "exchange" is missing from the MX record): `fail.json` ```json { "primaryNameservers": [ "localhost" ] , "domains": [ { "id": "example.com" } ] , "records": [ { "zone": "example.com", "name": "example.com", "tld": "com", "sld": "example", "sub": "" , "type": "MX", "priority": 10, "MISSING-exchange": "mxa.example.org" } ] } ``` Installing and running the digd.js server: ```bash git clone https://git.coolaj86.com/coolaj86/digd.js.git pushd digd.js/ npm install node bin/digd.js --port 5353 --input fail.json +norecurse ``` In another terminal, while the server is running: ```bash dig @localhost -p 5353 MX example.com ``` The server throws an error and nothing comes back. Instead a SERVFAIL should come back. Note: we should also validate the date... but we should correct the server's handling of error cases _before_ we correct the case that causes an error.

"로그인하여 이 대화에 참여"

레이블 없음

마일스톤 없음

담당자 없음

참여자 1명

알림

마감일

기한이 올바르지 않거나 범위를 벗어났습니다. 'yyyy-mm-dd'형식을 사용해주십시오.

마감일이 설정되지 않았습니다.

의존성

No dependencies set.

Reference: coolaj86/digd.js#2