Handle case of querying for root "." #4

Open
opened 6 years ago by coolaj86 · 1 comments
coolaj86 commented 6 years ago
Owner
dig +trace coolaj86.com @ns1.coolaj86.com

It turns out that that queries ".", which is an empty string in the packet, which throws an error (but shouldn't).

This is really a dns-suite.js issue, but I'll file it hear for now since I'm better at tracking these issues.

However, I think what should be returned is not an empty array but rather an NXDOMAIN

```bash dig +trace coolaj86.com @ns1.coolaj86.com ``` It turns out that that queries ".", which is an empty string in the packet, which throws an error (but shouldn't). This is really a `dns-suite.js` issue, but I'll file it hear for now since I'm better at tracking these issues. However, I think what should be returned is not an empty array but rather an `NXDOMAIN`
Poster
Owner

Partial fix in digd.js#v1.2.2, dig.js#v1.3.8, and dns-suite.js#v1.2.11 - no longer causes a crash (though I'm not sure if the exactly correct response is returned)

dig.js '' @ns1.coolaj86.com
Partial fix in `digd.js#v1.2.2`, `dig.js#v1.3.8`, and `dns-suite.js#v1.2.11` - no longer causes a crash (though I'm not sure if the exactly correct response is returned) ``` dig.js '' @ns1.coolaj86.com ```
Sign in to join this conversation.
No Label
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.