Handle case of querying for root "." #4

New Issue

coolaj86 · 2017-12-15T04:36:46Z

coolaj86 commented

2017-12-15 04:36:46 +00:00

dig +trace coolaj86.com @ns1.coolaj86.com

It turns out that that queries ".", which is an empty string in the packet, which throws an error (but shouldn't).

This is really a dns-suite.js issue, but I'll file it hear for now since I'm better at tracking these issues.

However, I think what should be returned is not an empty array but rather an NXDOMAIN

```bash dig +trace coolaj86.com @ns1.coolaj86.com ``` It turns out that that queries ".", which is an empty string in the packet, which throws an error (but shouldn't). This is really a `dns-suite.js` issue, but I'll file it hear for now since I'm better at tracking these issues. However, I think what should be returned is not an empty array but rather an `NXDOMAIN`

coolaj86 commented

2017-12-15 09:47:58 +00:00

Partial fix in digd.js#v1.2.2, dig.js#v1.3.8, and dns-suite.js#v1.2.11 - no longer causes a crash (though I'm not sure if the exactly correct response is returned)

dig.js '' @ns1.coolaj86.com

Partial fix in `digd.js#v1.2.2`, `dig.js#v1.3.8`, and `dns-suite.js#v1.2.11` - no longer causes a crash (though I'm not sure if the exactly correct response is returned) ``` dig.js '' @ns1.coolaj86.com ```

Sign in to join this conversation.

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/digd.js#4