From 6ecb2882dc1f5799e0eebc480557b7f1a6fca25a Mon Sep 17 00:00:00 2001 From: AJ ONeal Date: Sat, 11 Feb 2017 14:27:44 -0700 Subject: [PATCH] fix file scope var packet bug --- dns.parser.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dns.parser.js b/dns.parser.js index d65eee7..858451a 100644 --- a/dns.parser.js +++ b/dns.parser.js @@ -7,7 +7,6 @@ var classes = exports.DNS_CLASSES || require('./dns.classes.js').DNS_CLASSES; var types = exports.DNS_TYPES || require('./dns.types.js').DNS_TYPES; // Order http://www.zytrax.com/books/dns/ch15/ -var packet = {}; pdns.unpackHeader = function (i) { // i is one element from a Uint16Array (as a 16-bit unsigned integer) @@ -32,7 +31,7 @@ pdns.unpackHeader = function (i) { pdns._unpackLabels = exports.DNS_UNPACK_LABELS || require('./dns.unpack-labels.js').DNS_UNPACK_LABELS; -pdns.unpackOpt = function (ab, rec) { +pdns.unpackOpt = function (ab, packet, rec) { var dv; // https://tools.ietf.org/html/rfc6891#section-6 @@ -94,6 +93,7 @@ pdns.unpack = function (ab) { // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DataView var dv = new DataView(ab); var id = dv.getUint16(0, false); + var packet = {}; packet.header = pdns.unpackHeader(dv.getUint16(2, false)); packet.qdcount = dv.getUint16(4, false); // query count packet.ancount = dv.getUint16(6, false); // answer count @@ -238,7 +238,7 @@ pdns.unpack = function (ab) { total += rec.byteLength; if (0x29 === rec.type) { // OPT 41 (0x29) - pdns.unpackOpt(ab, rec); + pdns.unpackOpt(ab, packet, rec); continue; } packet.additional.push(rec);