v5.1.3: remove deps, update link

README.md

@@ -1,6 +1,8 @@
-forEachAsync
+forEachAsync.js
 ===
 
+| A [Root](https://rootprojects.org) project
+
 Analogous to `[].forEach`, but handles items asynchronously with a final callback passed to `then`.
 
 This is the most essential piece of the [`ArrayAsync`](https://github.com/FuturesJS/ArrayAsync) package.
@@ -19,7 +21,7 @@ Straight up, that's probably a bad idea and waste of time so I hope I don't actu
 Screencast
 ---
 
-<http://youtu.be/O7egvEz4scA>
+<https://youtu.be/O7egvEz4scA>
 
 Usage
 -----
@@ -62,18 +64,17 @@ You can install from bower:
 bower install --save forEachAsync@5.x
 ```
 
-Or download the raw file from <https://raw.github.com/FuturesJS/forEachAsync/master/forEachAsync.js>:
+Or download the raw file from <https://git.coolaj86.com/coolaj86/foreachasync.js/raw/branch/master/foreachasync.js>:
 
 ```bash
-wget https://raw.github.com/FuturesJS/forEachAsync/master/forEachAsync.js
+wget https://git.coolaj86.com/coolaj86/foreachasync.js/raw/branch/master/foreachasync.js
 ```
 
 ```javascript
 (function () {
   'use strict';
 
-  var forEachAsync = window.forEachAsync
+  var forEachAsync = window.forEachAsync;
-    ;
 
   // do stuff ...
 }());
@@ -85,7 +86,7 @@ Node Installation
 ===
 
 ```bash
-npm install --save forEachAsync@5.x
+npm install --save foreachasync@5.x
 ```
 
 API

foreachasync.js

@@ -2,17 +2,15 @@
 ;(function (exports) {
   'use strict';
 
-  var BREAK = {}
+  var BREAK = {};
-    , exp = {}
+  var exp = {};
-    ;
 
   function create(PromiseA) {
     PromiseA = PromiseA.Promise || PromiseA;
 
 
     function forEachAsync(arr, fn, thisArg) {
-      var result = PromiseA.resolve()
+      var result = PromiseA.resolve();
-        ;
 
       arr.forEach(function (item, k) {
         result = result.then(function () {
@@ -26,11 +24,11 @@
             ret = result = fn(item, k, arr);
           }
 
-          if (!ret.then) {
+          if (!ret || !ret.then) {
-            ret = PromiseA.resolve(result);
+            ret = PromiseA.resolve(ret);
           }
 
-          ret.then(function (val) {
+          return ret.then(function (val) {
             if (val === forEachAsync.__BREAK) {
               return PromiseA.reject(new Error('break'));
               //throw new Error('break');
@@ -61,24 +59,15 @@
   exports.create = forEachAsync.create = function () {};
   */
 
-
+  /* globals Promise */
-  try { 
+  if ('undefined' !== typeof Promise) {
-   exp.forEachAsync = create(require('bluebird'));
+    exp.forEachAsync = create(Promise);
-  } catch(e) {
+  }
-    if ('undefined' !== typeof PromiseA) {
+  else {
-      exp.forEachAsync = create(Promise);
+    try {
-    } else {
+     exp.forEachAsync = create(require('bluebird'));
-      try { 
+    } catch(e) {
-       exp.forEachAsync = create(require('es6-promise'));
+      console.warn("This version of node doesn't support promises. Please `npm install --save bluebird` in your project.");
-      } catch(e) {
-        try { 
-         exp.forEachAsync = create(require('rsvp'));
-        } catch(e) {
-          console.warning('forEachAsync needs requires a promise implementation and your environment does not provide one.'
-            + '\nYou may provide your own by calling forEachAsync.create(Promise) with a PromiseA+ implementation'
-          );
-        }
-      }
     }
   }
 
@@ -87,4 +76,4 @@
   };
   exports.forEachAsync.create = create;
 
-}('undefined' !== typeof exports && exports || new Function('return this')()));
+}('undefined' !== typeof exports && exports || window));

package-lock.json

@@ -0,0 +1,5 @@
+{
+  "name": "foreachasync",
+  "version": "5.1.3",
+  "lockfileVersion": 1
+}

package.json

@@ -1,9 +1,10 @@
 {
   "name": "foreachasync",
-  "version": "5.0.0",
+  "version": "5.1.3",
   "description": "A node- and browser-ready async (now with promises) counterpart of Array.prototype.forEach",
-  "homepage": "https://github.com/FuturesJS/forEachAsync",
+  "homepage": "https://git.coolaj86.com/coolaj86/foreachasync.js",
-  "main": "forEachAsync.js",
+  "main": "foreachasync.js",
+  "files": [],
   "directories": {
     "test": "test"
   },
@@ -12,7 +13,7 @@
   },
   "repository": {
     "type": "git",
-    "url": "git://github.com/FuturesJS/forEachAsync.git"
+    "url": "https://git.coolaj86.com/coolaj86/foreachasync.js.git"
   },
   "keywords": [
     "futuresjs",
@@ -25,14 +26,13 @@
     "promises",
     "each"
   ],
-  "optionalDependencies": {
+  "trulyOptionalDependencies": {
-    "bluebird": "^2.5.3"
+    "bluebird": "^3.5.1"
   },
-  "author": "AJ ONeal <coolaj86@gmail.com> (http://coolaj86.com/)",
+  "author": "AJ ONeal <coolaj86@gmail.com> (https://coolaj86.com/)",
-  "license": "Apache2",
+  "license": "(MIT OR Apache-2.0)",
   "bugs": {
-    "url": "https://github.com/FuturesJS/forEachAsync/issues"
+    "url": "https://git.coolaj86.com/coolaj86/foreachasync.js/issues"
   },
-  "dependencies": {
+  "dependencies": {}
-  }
 }

test-bluebird.js

@@ -1,27 +1,32 @@
 (function () {
   "use strict";
 
-  var PromiseA = require('bluebird')
+  var PromiseA = require('bluebird');
-    , forEachAsync = require('./forEachAsync').forEachAsync
+  var forEachAsync = require('./forEachAsync').forEachAsync;
-    , context = {}
+  var context = {};
-    ;
 
   forEachAsync([0, 500, 70, 200, 400, 100], function (element, i, arr) {
-    // test that array order is as expected
+    console.log(i, '/', arr.length, 'began');
-    console.log(element, 'is element', i, 'of', arr.length);
+
+    var result;
 
     // test that thisness is applied
     this[element] = i;
 
-    if (i > 2) {
+    if (i % 2) {
       // test that synchronous callbacks don't mess things up
-      return PromiseA.resolve();
+      result = PromiseA.resolve();
     } else {
       // test asynchronous callbacks
-      return new Promise(function (resolve/*, reject*/) {
+      result = new PromiseA(function (resolve/*, reject*/) {
         setTimeout(resolve, element);
       });
     }
+
+    return result.then(function () {
+      // test that array order is as expected
+      console.log(i, '/', arr.length, 'complete');
+    });
   }, context).then(function () {
     // test that thisness carried
     console.log('context', context);

test-native.js

@@ -1,26 +1,30 @@
 (function () {
   "use strict";
 
-  var forEachAsync = require('./forEachAsync').forEachAsync.create(Promise)
+  /* globals Promise */
-    , context = {}
+  var forEachAsync = require('./forEachAsync').forEachAsync.create(Promise);
-    ;
+  var context = {};
 
   forEachAsync([0, 500, 70, 200, 400, 100], function (element, i, arr) {
-    // test that array order is as expected
+    var p;
-    console.log(element, 'is element', i, 'of', arr.length);
 
     // test that thisness is applied
     this[element] = i;
 
-    if (i > 2) {
+    if (i % 2) {
       // test that synchronous callbacks don't mess things up
-      return Promise.resolve();
+      p = Promise.resolve();
     } else {
       // test asynchronous callbacks
-      return new Promise(function (resolve/*, reject*/) {
+      p = new Promise(function (resolve/*, reject*/) {
         setTimeout(resolve, element);
       });
     }
+
+    return p.then(function () {
+      // test that array order is as expected
+      console.log(element, 'is element', i, 'of', arr.length);
+    });
   }, context).then(function () {
     // test that thisness carried
     console.log('context', context);