From 35284be148013bbdd2660d91e817c7d565a0f143 Mon Sep 17 00:00:00 2001
From: AJ ONeal <coolaj86@gmail.com>
Date: Fri, 4 Feb 2011 00:14:19 -0700
Subject: [PATCH] api / doc matching

---
 README.md            | 25 +++++++++++++++++++------
 lib/walk.js          |  4 ++--
 package.json         |  2 +-
 profile/walk-test.js | 11 +++++++----
 4 files changed, 29 insertions(+), 13 deletions(-)

diff --git a/README.md b/README.md
index 001a8ed..f49a203 100644
--- a/README.md
+++ b/README.md
@@ -13,9 +13,6 @@ This is somewhat of a port python's `os.walk`, but using Node.JS conventions.
 As few file descriptors are opened at a time as possible.
 This is particularly well suited for single hard disks which are not flash or solid state.
 
-Memory usage is high (120mb for 60,000 dirs), but reduction is being investigated.
-Patches welcome.
-
 Installation
 ----
 
@@ -34,6 +31,14 @@ Usage
 
     walker = walk("path/to/dir", options);
 
+    walker.on("names", function (root, nodeNamesArray) {
+      nodeNames.sort(function (a, b) {
+        if (a > b) return 1;
+        if (a < b) return -1;
+        return 0;
+      });
+    });
+
     walker.on("directories", function (root, dirStatsArray, next) {
       // dirStatsArray is an array of `stat` objects with the additional attributes
       // * type
@@ -63,6 +68,8 @@ API
 
 Emitted Values
 
+  * `on('XYZ', function(root, stats, next) {})`
+
   * `root` - the containing the files to be inspected
   * *stats[Array]* - a single `stats` object or an array with some added attributes
     * type - 'file', 'directory', etc
@@ -75,28 +82,34 @@ Single Events - fired immediately
   * `end` - No files, dirs, etc left to inspect
 
   * `directoryError` - Error when `fstat` succeeded, but reading path failed (Probably due to permissions).
+  * `nodeError` - Error `fstat` did not succeeded.
   * `node` - a `stats` object for a node of any type
   * `file` - includes links when `followLinks` is `true`
+    * Note: This feature is broken in the current version, but works in the previous `walk-recursive` version
   * `directory`
+  * `symbolicLink` - always empty when `followLinks` is `true`
   * `blockDevice`
   * `characterDevice`
-  * `symbolicLink` - always empty when `followLinks` is `true`
   * `FIFO`
   * `socket`
 
 Events with Array Arguments - fired after all files in the dir have been `stat`ed
 
+  * `names` - before any `stat` takes place. Useful for sorting and filtering.
+    * Note: the array is an array of `string`s, not `stat` objects
+    * Note: the `next` argument is a `noop`
+
   * `errors` - errors encountered by `fs.stat` when reading ndes in a directory
   * `nodes` - an array of `stats` of any type
   * `files`
   * `directories` - modification of this array - sorting, removing, etc - affects traversal
+  * `symbolicLinks`
   * `blockDevices`
   * `characterDevices`
-  * `symbolicLinks`
   * `FIFOs`
   * `sockets`
 
-**Warning** beware of infinite loops when `followLinks` is true.
+**Warning** beware of infinite loops when `followLinks` is true (using `walk-recurse` varient).
 
 Comparisons
 ====
diff --git a/lib/walk.js b/lib/walk.js
index 04fbf91..99b7677 100644
--- a/lib/walk.js
+++ b/lib/walk.js
@@ -32,9 +32,9 @@
 
         // TODO could allow user to selectively stat
         // and don't stat if there are no stat listeners
-        emitter.emit('names', curpath, files);
+        emitter.emit('names', curpath, files, noop);
         files.forEachAsync(function (cont, file) {
-          emitter.emit('name', curpath, file);
+          emitter.emit('name', curpath, file, noop);
           fs.lstat(curpath + '/' + file, function (err, stat) {
             stat = stat || {};
             stat.name = file;
diff --git a/package.json b/package.json
index 6ef246c..a51e2f0 100644
--- a/package.json
+++ b/package.json
@@ -8,5 +8,5 @@
   "dependencies"  : [],
   "lib"           : "lib",
   "main"          : "./lib/walk.js",
-  "version"       : "1.0.0"
+  "version"       : "1.0.1"
 }
diff --git a/profile/walk-test.js b/profile/walk-test.js
index bb6dfb0..6379984 100755
--- a/profile/walk-test.js
+++ b/profile/walk-test.js
@@ -11,7 +11,7 @@
     b= b.toLowerCase();
     if (a > b) return -1;
     if (a < b) return  1;
-    else       return  0;
+    return  0;
   }
 
   process.argv.forEach(function(startpath, index) {
@@ -24,7 +24,6 @@
         //console.log( ["[", count, "] ", path, '/', file].join('') )
         console.log( [path, '/', file].join('') )
       });
-      /*
       emitter.on('names', function (path, files, stats) {
         files.sort(sort);
         //console.log('sort: ' + files.join(' ; '));
@@ -32,8 +31,10 @@
       */
 
 
+
   // Single `stat`ed Nodes
       emitter.on('error', function (path, err, next) {
+        next()
         // ignore
       });
       emitter.on('directoryError', function (path, stats, next) {
@@ -67,8 +68,6 @@
         next();
       });
       /*
-      */
-      /*
       emitter.on('blockDevice', function (path, stat, next) {
         next();
       });
@@ -83,6 +82,8 @@
       });
       */
 
+
+
     // Grouped `stat`ed Nodes
       emitter.on('errors', function (path, stats, next) {
         next();
@@ -117,6 +118,8 @@
       });
       */
 
+
+
     // The end of all things
       emitter.on('end', function () {
         console.log("The eagle has landed. [" + count + " == " + saneCount + "]");