coolaj86
/
gitroast
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Removed HTTP 500 error on the release page when a user deleted their account

This commit is contained in:
Martin Hartkorn 2016-02-10 21:35:58 +01:00
parent e797a225b6
commit 6b3e47b103
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
routers/repo/release.go
View File

@ -45,9 +45,13 @@ func Releases(ctx *middleware.Context) {
if rel.TagName == rawTag { if rel.TagName == rawTag {
rel.Publisher, err = models.GetUserByID(rel.PublisherID) rel.Publisher, err = models.GetUserByID(rel.PublisherID)
if err != nil { if err != nil {
if models.IsErrUserNotExist(err) {
rel.Publisher = models.NewFakeUser()
} else {
ctx.Handle(500, "GetUserByID", err) ctx.Handle(500, "GetUserByID", err)
return return
} }
}
// FIXME: duplicated code. // FIXME: duplicated code.
// Get corresponding target if it's not the current branch. // Get corresponding target if it's not the current branch.
if ctx.Repo.BranchName != rel.Target { if ctx.Repo.BranchName != rel.Target {
@ -105,9 +109,13 @@ func Releases(ctx *middleware.Context) {
rel.Publisher, err = models.GetUserByID(rel.PublisherID) rel.Publisher, err = models.GetUserByID(rel.PublisherID)
if err != nil { if err != nil {
if models.IsErrUserNotExist(err) {
rel.Publisher = models.NewFakeUser()
} else {
ctx.Handle(500, "GetUserByID", err) ctx.Handle(500, "GetUserByID", err)
return return
} }
}
// FIXME: duplicated code. // FIXME: duplicated code.
// Get corresponding target if it's not the current branch. // Get corresponding target if it's not the current branch.
if ctx.Repo.BranchName != rel.Target { if ctx.Repo.BranchName != rel.Target {