coolaj86
/
gitroast
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Enhance healthcheck for database connectivity (#3754) 

Modify the call to ping the database to fail gracefully if the
database has not yet been configured by the end user, such as
after a clean install. This allows /healthcheck to return a 200
with a modified status message instead of causing a PANIC.

Signed-off-by: Evan Sherwood <evan@sherwood.io>
This commit is contained in:
Evan Sherwood 2018-04-04 02:34:27 -07:00 committed by Lunny Xiao
parent 3e06490d38
commit 6b6c414bc3
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
models/models.go
View File

@ -335,7 +335,10 @@ func GetStatistic() (stats Statistic) {
// Ping tests if database is alive // Ping tests if database is alive
func Ping() error { func Ping() error {
return x.Ping() if x != nil {
return x.Ping()
}
return errors.New("database not configured")
} }
// DumpDatabase dumps all data from database according the special database SQL syntax to file system. // DumpDatabase dumps all data from database according the special database SQL syntax to file system.