From 722bcefbbf26f4bca74f160295611cc982b364dc Mon Sep 17 00:00:00 2001 From: Bo-Yi Wu Date: Wed, 16 Aug 2017 08:46:41 +0800 Subject: [PATCH] refactor(Makefile): allow overriding default go program (#2310) --- Makefile | 49 +++++++++++++++++++++++++------------------------ 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/Makefile b/Makefile index 6b2877c72..738b76a86 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,7 @@ DIST := dist IMPORT := code.gitea.io/gitea +GO ?= go SED_INPLACE := sed -i ifeq ($(OS), Windows_NT) @@ -24,7 +25,7 @@ EXTRA_GOFLAGS ?= LDFLAGS := -X "main.Version=$(shell git describe --tags --always | sed 's/-/+/' | sed 's/^v//')" -X "main.Tags=$(TAGS)" -PACKAGES ?= $(filter-out code.gitea.io/gitea/integrations,$(shell go list ./... | grep -v /vendor/)) +PACKAGES ?= $(filter-out code.gitea.io/gitea/integrations,$(shell $(GO) list ./... | grep -v /vendor/)) SOURCES ?= $(shell find . -name "*.go" -type f) TAGS ?= @@ -52,11 +53,11 @@ all: build .PHONY: clean clean: - go clean -i ./... + $(GO) clean -i ./... rm -rf $(EXECUTABLE) $(DIST) $(BINDATA) required-gofmt-version: - @go version | grep -q '\(1.7\|1.8\)' || { echo "We require go version 1.7 or 1.8 to format code" >&2 && exit 1; } + @$(GO) version | grep -q '\(1.7\|1.8\)' || { echo "We require go version 1.7 or 1.8 to format code" >&2 && exit 1; } .PHONY: fmt fmt: required-gofmt-version @@ -64,19 +65,19 @@ fmt: required-gofmt-version .PHONY: vet vet: - go vet $(PACKAGES) + $(GO) vet $(PACKAGES) .PHONY: generate generate: @hash go-bindata > /dev/null 2>&1; if [ $$? -ne 0 ]; then \ - go get -u github.com/jteeuwen/go-bindata/...; \ + $(GO) get -u github.com/jteeuwen/go-bindata/...; \ fi - go generate $(PACKAGES) + $(GO) generate $(PACKAGES) .PHONY: generate-swagger generate-swagger: @hash swagger > /dev/null 2>&1; if [ $$? -ne 0 ]; then \ - go get -u github.com/go-swagger/go-swagger/cmd/swagger; \ + $(GO) get -u github.com/go-swagger/go-swagger/cmd/swagger; \ fi swagger generate spec -o ./public/swagger.v1.json $(SED_INPLACE) "s;\".ref\": \"#/definitions/GPGKey\";\"type\": \"object\";g" ./public/swagger.v1.json @@ -85,28 +86,28 @@ generate-swagger: .PHONY: errcheck errcheck: @hash errcheck > /dev/null 2>&1; if [ $$? -ne 0 ]; then \ - go get -u github.com/kisielk/errcheck; \ + $(GO) get -u github.com/kisielk/errcheck; \ fi errcheck $(PACKAGES) .PHONY: lint lint: @hash golint > /dev/null 2>&1; if [ $$? -ne 0 ]; then \ - go get -u github.com/golang/lint/golint; \ + $(GO) get -u github.com/golang/lint/golint; \ fi for PKG in $(PACKAGES); do golint -set_exit_status $$PKG || exit 1; done; .PHONY: misspell-check misspell-check: @hash misspell > /dev/null 2>&1; if [ $$? -ne 0 ]; then \ - go get -u github.com/client9/misspell/cmd/misspell; \ + $(GO) get -u github.com/client9/misspell/cmd/misspell; \ fi misspell -error -i unknwon $(GOFILES) .PHONY: misspell misspell: @hash misspell > /dev/null 2>&1; if [ $$? -ne 0 ]; then \ - go get -u github.com/client9/misspell/cmd/misspell; \ + $(GO) get -u github.com/client9/misspell/cmd/misspell; \ fi misspell -w -i unknwon $(GOFILES) @@ -122,12 +123,12 @@ fmt-check: required-gofmt-version .PHONY: test test: fmt-check - go test $(PACKAGES) + $(GO) test $(PACKAGES) .PHONY: test-coverage test-coverage: unit-test-coverage integration-test-coverage @hash gocovmerge > /dev/null 2>&1; if [ $$? -ne 0 ]; then \ - go get -u github.com/wadey/gocovmerge; \ + $(GO) get -u github.com/wadey/gocovmerge; \ fi for PKG in $(PACKAGES); do\ touch $$GOPATH/src/$$PKG/coverage.out;\ @@ -139,12 +140,12 @@ test-coverage: unit-test-coverage integration-test-coverage .PHONY: unit-test-coverage unit-test-coverage: - for PKG in $(PACKAGES); do go test -cover -coverprofile $$GOPATH/src/$$PKG/coverage.out $$PKG || exit 1; done; + for PKG in $(PACKAGES); do $(GO) test -cover -coverprofile $$GOPATH/src/$$PKG/coverage.out $$PKG || exit 1; done; .PHONY: test-vendor test-vendor: @hash govendor > /dev/null 2>&1; if [ $$? -ne 0 ]; then \ - go get -u github.com/kardianos/govendor; \ + $(GO) get -u github.com/kardianos/govendor; \ fi govendor list +unused | tee "$(TMPDIR)/wc-gitea-unused" [ $$(cat "$(TMPDIR)/wc-gitea-unused" | wc -l) -eq 0 ] || echo "Warning: /!\\ Some vendor are not used /!\\" @@ -185,26 +186,26 @@ integration-test-coverage: integrations.cover.test GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/mysql.ini ./integrations.cover.test -test.coverprofile=integration.coverage.out integrations.test: $(SOURCES) - go test -c code.gitea.io/gitea/integrations + $(GO) test -c code.gitea.io/gitea/integrations integrations.sqlite.test: $(SOURCES) - go test -c code.gitea.io/gitea/integrations -o integrations.sqlite.test -tags 'sqlite' + $(GO) test -c code.gitea.io/gitea/integrations -o integrations.sqlite.test -tags 'sqlite' integrations.cover.test: $(SOURCES) - go test -c code.gitea.io/gitea/integrations -coverpkg $(shell echo $(PACKAGES) | tr ' ' ',') -o integrations.cover.test + $(GO) test -c code.gitea.io/gitea/integrations -coverpkg $(shell echo $(PACKAGES) | tr ' ' ',') -o integrations.cover.test .PHONY: check check: test .PHONY: install install: $(wildcard *.go) - go install -v -tags '$(TAGS)' -ldflags '-s -w $(LDFLAGS)' + $(GO) install -v -tags '$(TAGS)' -ldflags '-s -w $(LDFLAGS)' .PHONY: build build: $(EXECUTABLE) $(EXECUTABLE): $(SOURCES) - go build $(GOFLAGS) $(EXTRA_GOFLAGS) -tags '$(TAGS)' -ldflags '-s -w $(LDFLAGS)' -o $@ + $(GO) build $(GOFLAGS) $(EXTRA_GOFLAGS) -tags '$(TAGS)' -ldflags '-s -w $(LDFLAGS)' -o $@ .PHONY: docker docker: @@ -221,7 +222,7 @@ release-dirs: .PHONY: release-windows release-windows: @hash xgo > /dev/null 2>&1; if [ $$? -ne 0 ]; then \ - go get -u github.com/karalabe/xgo; \ + $(GO) get -u github.com/karalabe/xgo; \ fi xgo -dest $(DIST)/binaries -tags 'netgo $(TAGS)' -ldflags '-linkmode external -extldflags "-static" $(LDFLAGS)' -targets 'windows/*' -out gitea-$(VERSION) . ifeq ($(CI),drone) @@ -231,7 +232,7 @@ endif .PHONY: release-linux release-linux: @hash xgo > /dev/null 2>&1; if [ $$? -ne 0 ]; then \ - go get -u github.com/karalabe/xgo; \ + $(GO) get -u github.com/karalabe/xgo; \ fi xgo -dest $(DIST)/binaries -tags 'netgo $(TAGS)' -ldflags '-linkmode external -extldflags "-static" $(LDFLAGS)' -targets 'linux/*' -out gitea-$(VERSION) . ifeq ($(CI),drone) @@ -241,7 +242,7 @@ endif .PHONY: release-darwin release-darwin: @hash xgo > /dev/null 2>&1; if [ $$? -ne 0 ]; then \ - go get -u github.com/karalabe/xgo; \ + $(GO) get -u github.com/karalabe/xgo; \ fi xgo -dest $(DIST)/binaries -tags 'netgo $(TAGS)' -ldflags '$(LDFLAGS)' -targets 'darwin/*' -out gitea-$(VERSION) . ifeq ($(CI),drone) @@ -278,7 +279,7 @@ stylesheets: public/css/index.css .IGNORE: public/css/index.css public/css/index.css: $(STYLESHEETS) @which lessc > /dev/null; if [ $$? -ne 0 ]; then \ - go get -u github.com/kib357/less-go/lessc; \ + $(GO) get -u github.com/kib357/less-go/lessc; \ fi lessc -i $< -o $@