From 902a749fd9091721db5796805ecef56c855ebbf9 Mon Sep 17 00:00:00 2001 From: Ethan Koenig Date: Wed, 21 Jun 2017 21:06:57 -0400 Subject: [PATCH] Fix fast-forward PR bug (#1989) --- models/pull.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/models/pull.go b/models/pull.go index 882ee1b22..94bd7930f 100644 --- a/models/pull.go +++ b/models/pull.go @@ -515,11 +515,11 @@ func (pr *PullRequest) getMergeCommit() (*git.Commit, error) { mergeCommit, stderr, err := process.GetManager().ExecDirEnv(-1, "", fmt.Sprintf("isMerged (git rev-list --ancestry-path --merges --reverse): %d", pr.BaseRepo.ID), []string{"GIT_INDEX_FILE=" + indexTmpPath, "GIT_DIR=" + pr.BaseRepo.RepoPath()}, "git", "rev-list", "--ancestry-path", "--merges", "--reverse", cmd) - if err == nil && len(mergeCommit) != 40 { - err = fmt.Errorf("unexpected length of output (got:%d bytes) '%s'", len(mergeCommit), mergeCommit) - } if err != nil { return nil, fmt.Errorf("git rev-list --ancestry-path --merges --reverse: %v %v", stderr, err) + } else if len(mergeCommit) < 40 { + // PR was fast-forwarded, so just use last commit of PR + mergeCommit = commitID[:40] } gitRepo, err := git.OpenRepository(pr.BaseRepo.RepoPath())