From bf552761894dee08f734d91f5c8175cd0cb2f9f5 Mon Sep 17 00:00:00 2001 From: SagePtr Date: Fri, 7 Sep 2018 03:37:02 +0200 Subject: [PATCH] Fix redirect with non-ascii branch names (#4764) (#4810) * Fix redirect with non-ascii branch names (#4764) * Add integration tests for non-ascii branch redirect * Fix mysql test and coverage test --- integrations/api_repo_test.go | 6 +- .../user2/utf8.git/HEAD | 1 + .../user2/utf8.git/config | 4 + .../user2/utf8.git/description | 1 + .../utf8.git/hooks/applypatch-msg.sample | 15 ++ .../user2/utf8.git/hooks/commit-msg.sample | 24 +++ .../user2/utf8.git/hooks/post-receive | 7 + .../user2/utf8.git/hooks/post-receive.d/gitea | 2 + .../user2/utf8.git/hooks/post-update.sample | 8 + .../utf8.git/hooks/pre-applypatch.sample | 14 ++ .../user2/utf8.git/hooks/pre-commit.sample | 49 +++++ .../user2/utf8.git/hooks/pre-push.sample | 53 ++++++ .../user2/utf8.git/hooks/pre-rebase.sample | 169 +++++++++++++++++ .../user2/utf8.git/hooks/pre-receive | 7 + .../user2/utf8.git/hooks/pre-receive.d/gitea | 2 + .../utf8.git/hooks/prepare-commit-msg.sample | 36 ++++ .../user2/utf8.git/hooks/update | 7 + .../user2/utf8.git/hooks/update.d/gitea | 2 + .../user2/utf8.git/hooks/update.sample | 128 +++++++++++++ .../user2/utf8.git/info/exclude | 6 + .../user2/utf8.git/info/refs | 9 + .../14/c42687126acae9d1ad41d7bdb528f811065a6a | Bin 0 -> 39 bytes .../1d/5e00f305a7ca6a8a94e65456820a6d260adab8 | Bin 0 -> 127 bytes .../28/d579e4920fbf4f66e71dab3e779d9fbf41422a | 3 + .../3a/810dbf6b96afaa8c5f69a8b6ec1dabfca7368b | Bin 0 -> 176 bytes .../3a/a73c3499bff049a352b4e265575373e964b89a | Bin 0 -> 137 bytes .../3a/c6084110205f98174c4f1ec7e78cb21a15dfc2 | Bin 0 -> 23 bytes .../56/92bcf9f7c9eacb1ad68442161f2573877f96f4 | Bin 0 -> 49 bytes .../6d/0c79ce3401c67d1ad522e61c47083a9fdee16c | Bin 0 -> 54 bytes .../a9/a61830fbf4e84999d3b20cf178954366701fe5 | Bin 0 -> 129 bytes .../eb/f146f803fccbc1471ef01d8fa0fe12c14e61a5 | 1 + .../ee/9686cb562f492f64381bff7f298b2a1c67a141 | Bin 0 -> 88 bytes .../f4/02ff67c0b3161c3988dbf6188e6e0df257fd75 | Bin 0 -> 52 bytes .../user2/utf8.git/objects/info/packs | 1 + .../user2/utf8.git/refs/heads/Grüßen | 1 + .../utf8.git/refs/heads/Plus+Is+Not+Space | 1 + .../user2/utf8.git/refs/heads/master | 1 + .../refs/heads/ГлавнаяВетка | 1 + .../user2/utf8.git/refs/heads/а/б/в | 1 + .../user2/utf8.git/refs/heads/ブランチ | 1 + .../user2/utf8.git/refs/tags/Ё/人 | 1 + .../user2/utf8.git/refs/tags/Тэг | 1 + .../user2/utf8.git/refs/tags/タグ | 1 + integrations/nonascii_branches_test.go | 178 ++++++++++++++++++ models/fixtures/repo_unit.yml | 35 ++++ models/fixtures/repository.yml | 7 + models/fixtures/user.yml | 2 +- models/repo_list_test.go | 6 +- modules/context/repo.go | 2 +- 49 files changed, 786 insertions(+), 8 deletions(-) create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/HEAD create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/config create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/description create mode 100755 integrations/gitea-repositories-meta/user2/utf8.git/hooks/applypatch-msg.sample create mode 100755 integrations/gitea-repositories-meta/user2/utf8.git/hooks/commit-msg.sample create mode 100755 integrations/gitea-repositories-meta/user2/utf8.git/hooks/post-receive create mode 100755 integrations/gitea-repositories-meta/user2/utf8.git/hooks/post-receive.d/gitea create mode 100755 integrations/gitea-repositories-meta/user2/utf8.git/hooks/post-update.sample create mode 100755 integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-applypatch.sample create mode 100755 integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-commit.sample create mode 100755 integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-push.sample create mode 100755 integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-rebase.sample create mode 100755 integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-receive create mode 100755 integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-receive.d/gitea create mode 100755 integrations/gitea-repositories-meta/user2/utf8.git/hooks/prepare-commit-msg.sample create mode 100755 integrations/gitea-repositories-meta/user2/utf8.git/hooks/update create mode 100755 integrations/gitea-repositories-meta/user2/utf8.git/hooks/update.d/gitea create mode 100755 integrations/gitea-repositories-meta/user2/utf8.git/hooks/update.sample create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/info/exclude create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/info/refs create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/objects/14/c42687126acae9d1ad41d7bdb528f811065a6a create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/objects/1d/5e00f305a7ca6a8a94e65456820a6d260adab8 create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/objects/28/d579e4920fbf4f66e71dab3e779d9fbf41422a create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/objects/3a/810dbf6b96afaa8c5f69a8b6ec1dabfca7368b create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/objects/3a/a73c3499bff049a352b4e265575373e964b89a create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/objects/3a/c6084110205f98174c4f1ec7e78cb21a15dfc2 create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/objects/56/92bcf9f7c9eacb1ad68442161f2573877f96f4 create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/objects/6d/0c79ce3401c67d1ad522e61c47083a9fdee16c create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/objects/a9/a61830fbf4e84999d3b20cf178954366701fe5 create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/objects/eb/f146f803fccbc1471ef01d8fa0fe12c14e61a5 create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/objects/ee/9686cb562f492f64381bff7f298b2a1c67a141 create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/objects/f4/02ff67c0b3161c3988dbf6188e6e0df257fd75 create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/objects/info/packs create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/Grüßen create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/Plus+Is+Not+Space create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/master create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/ГлавнаяВетка create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/а/б/в create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/ブランチ create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/refs/tags/Ё/人 create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/refs/tags/Тэг create mode 100644 integrations/gitea-repositories-meta/user2/utf8.git/refs/tags/タグ create mode 100644 integrations/nonascii_branches_test.go diff --git a/integrations/api_repo_test.go b/integrations/api_repo_test.go index aec8c8f81..5dc2f88cb 100644 --- a/integrations/api_repo_test.go +++ b/integrations/api_repo_test.go @@ -67,9 +67,9 @@ func TestAPISearchRepo(t *testing.T) { expectedResults }{ {name: "RepositoriesMax50", requestURL: "/api/v1/repos/search?limit=50", expectedResults: expectedResults{ - nil: {count: 16}, - user: {count: 16}, - user2: {count: 16}}, + nil: {count: 17}, + user: {count: 17}, + user2: {count: 17}}, }, {name: "RepositoriesMax10", requestURL: "/api/v1/repos/search?limit=10", expectedResults: expectedResults{ nil: {count: 10}, diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/HEAD b/integrations/gitea-repositories-meta/user2/utf8.git/HEAD new file mode 100644 index 000000000..cb089cd89 --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/HEAD @@ -0,0 +1 @@ +ref: refs/heads/master diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/config b/integrations/gitea-repositories-meta/user2/utf8.git/config new file mode 100644 index 000000000..07d359d07 --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/config @@ -0,0 +1,4 @@ +[core] + repositoryformatversion = 0 + filemode = true + bare = true diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/description b/integrations/gitea-repositories-meta/user2/utf8.git/description new file mode 100644 index 000000000..498b267a8 --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/description @@ -0,0 +1 @@ +Unnamed repository; edit this file 'description' to name the repository. diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/hooks/applypatch-msg.sample b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/applypatch-msg.sample new file mode 100755 index 000000000..a5d7b84a6 --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/applypatch-msg.sample @@ -0,0 +1,15 @@ +#!/bin/sh +# +# An example hook script to check the commit log message taken by +# applypatch from an e-mail message. +# +# The hook should exit with non-zero status after issuing an +# appropriate message if it wants to stop the commit. The hook is +# allowed to edit the commit message file. +# +# To enable this hook, rename this file to "applypatch-msg". + +. git-sh-setup +commitmsg="$(git rev-parse --git-path hooks/commit-msg)" +test -x "$commitmsg" && exec "$commitmsg" ${1+"$@"} +: diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/hooks/commit-msg.sample b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/commit-msg.sample new file mode 100755 index 000000000..b58d1184a --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/commit-msg.sample @@ -0,0 +1,24 @@ +#!/bin/sh +# +# An example hook script to check the commit log message. +# Called by "git commit" with one argument, the name of the file +# that has the commit message. The hook should exit with non-zero +# status after issuing an appropriate message if it wants to stop the +# commit. The hook is allowed to edit the commit message file. +# +# To enable this hook, rename this file to "commit-msg". + +# Uncomment the below to add a Signed-off-by line to the message. +# Doing this in a hook is a bad idea in general, but the prepare-commit-msg +# hook is more suited to it. +# +# SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/Signed-off-by: \1/p') +# grep -qs "^$SOB" "$1" || echo "$SOB" >> "$1" + +# This example catches duplicate Signed-off-by lines. + +test "" = "$(grep '^Signed-off-by: ' "$1" | + sort | uniq -c | sed -e '/^[ ]*1[ ]/d')" || { + echo >&2 Duplicate Signed-off-by lines. + exit 1 +} diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/hooks/post-receive b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/post-receive new file mode 100755 index 000000000..4b3d452ab --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/post-receive @@ -0,0 +1,7 @@ +#!/usr/bin/env bash +ORI_DIR=`pwd` +SHELL_FOLDER=$(cd "$(dirname "$0")";pwd) +cd "$ORI_DIR" +for i in `ls "$SHELL_FOLDER/post-receive.d"`; do + sh "$SHELL_FOLDER/post-receive.d/$i" +done \ No newline at end of file diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/hooks/post-receive.d/gitea b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/post-receive.d/gitea new file mode 100755 index 000000000..43a948da3 --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/post-receive.d/gitea @@ -0,0 +1,2 @@ +#!/usr/bin/env bash +"$GITEA_ROOT/gitea" hook --config="$GITEA_ROOT/$GITEA_CONF" post-receive diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/hooks/post-update.sample b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/post-update.sample new file mode 100755 index 000000000..ec17ec193 --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/post-update.sample @@ -0,0 +1,8 @@ +#!/bin/sh +# +# An example hook script to prepare a packed repository for use over +# dumb transports. +# +# To enable this hook, rename this file to "post-update". + +exec git update-server-info diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-applypatch.sample b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-applypatch.sample new file mode 100755 index 000000000..4142082bc --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-applypatch.sample @@ -0,0 +1,14 @@ +#!/bin/sh +# +# An example hook script to verify what is about to be committed +# by applypatch from an e-mail message. +# +# The hook should exit with non-zero status after issuing an +# appropriate message if it wants to stop the commit. +# +# To enable this hook, rename this file to "pre-applypatch". + +. git-sh-setup +precommit="$(git rev-parse --git-path hooks/pre-commit)" +test -x "$precommit" && exec "$precommit" ${1+"$@"} +: diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-commit.sample b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-commit.sample new file mode 100755 index 000000000..68d62d544 --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-commit.sample @@ -0,0 +1,49 @@ +#!/bin/sh +# +# An example hook script to verify what is about to be committed. +# Called by "git commit" with no arguments. The hook should +# exit with non-zero status after issuing an appropriate message if +# it wants to stop the commit. +# +# To enable this hook, rename this file to "pre-commit". + +if git rev-parse --verify HEAD >/dev/null 2>&1 +then + against=HEAD +else + # Initial commit: diff against an empty tree object + against=4b825dc642cb6eb9a060e54bf8d69288fbee4904 +fi + +# If you want to allow non-ASCII filenames set this variable to true. +allownonascii=$(git config --bool hooks.allownonascii) + +# Redirect output to stderr. +exec 1>&2 + +# Cross platform projects tend to avoid non-ASCII filenames; prevent +# them from being added to the repository. We exploit the fact that the +# printable range starts at the space character and ends with tilde. +if [ "$allownonascii" != "true" ] && + # Note that the use of brackets around a tr range is ok here, (it's + # even required, for portability to Solaris 10's /usr/bin/tr), since + # the square bracket bytes happen to fall in the designated range. + test $(git diff --cached --name-only --diff-filter=A -z $against | + LC_ALL=C tr -d '[ -~]\0' | wc -c) != 0 +then + cat <<\EOF +Error: Attempt to add a non-ASCII file name. + +This can cause problems if you want to work with people on other platforms. + +To be portable it is advisable to rename the file. + +If you know what you are doing you can disable this check using: + + git config hooks.allownonascii true +EOF + exit 1 +fi + +# If there are whitespace errors, print the offending file names and fail. +exec git diff-index --check --cached $against -- diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-push.sample b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-push.sample new file mode 100755 index 000000000..6187dbf43 --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-push.sample @@ -0,0 +1,53 @@ +#!/bin/sh + +# An example hook script to verify what is about to be pushed. Called by "git +# push" after it has checked the remote status, but before anything has been +# pushed. If this script exits with a non-zero status nothing will be pushed. +# +# This hook is called with the following parameters: +# +# $1 -- Name of the remote to which the push is being done +# $2 -- URL to which the push is being done +# +# If pushing without using a named remote those arguments will be equal. +# +# Information about the commits which are being pushed is supplied as lines to +# the standard input in the form: +# +# +# +# This sample shows how to prevent push of commits where the log message starts +# with "WIP" (work in progress). + +remote="$1" +url="$2" + +z40=0000000000000000000000000000000000000000 + +while read local_ref local_sha remote_ref remote_sha +do + if [ "$local_sha" = $z40 ] + then + # Handle delete + : + else + if [ "$remote_sha" = $z40 ] + then + # New branch, examine all commits + range="$local_sha" + else + # Update to existing branch, examine new commits + range="$remote_sha..$local_sha" + fi + + # Check for WIP commit + commit=`git rev-list -n 1 --grep '^WIP' "$range"` + if [ -n "$commit" ] + then + echo >&2 "Found WIP commit in $local_ref, not pushing" + exit 1 + fi + fi +done + +exit 0 diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-rebase.sample b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-rebase.sample new file mode 100755 index 000000000..33730ca64 --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-rebase.sample @@ -0,0 +1,169 @@ +#!/bin/sh +# +# Copyright (c) 2006, 2008 Junio C Hamano +# +# The "pre-rebase" hook is run just before "git rebase" starts doing +# its job, and can prevent the command from running by exiting with +# non-zero status. +# +# The hook is called with the following parameters: +# +# $1 -- the upstream the series was forked from. +# $2 -- the branch being rebased (or empty when rebasing the current branch). +# +# This sample shows how to prevent topic branches that are already +# merged to 'next' branch from getting rebased, because allowing it +# would result in rebasing already published history. + +publish=next +basebranch="$1" +if test "$#" = 2 +then + topic="refs/heads/$2" +else + topic=`git symbolic-ref HEAD` || + exit 0 ;# we do not interrupt rebasing detached HEAD +fi + +case "$topic" in +refs/heads/??/*) + ;; +*) + exit 0 ;# we do not interrupt others. + ;; +esac + +# Now we are dealing with a topic branch being rebased +# on top of master. Is it OK to rebase it? + +# Does the topic really exist? +git show-ref -q "$topic" || { + echo >&2 "No such branch $topic" + exit 1 +} + +# Is topic fully merged to master? +not_in_master=`git rev-list --pretty=oneline ^master "$topic"` +if test -z "$not_in_master" +then + echo >&2 "$topic is fully merged to master; better remove it." + exit 1 ;# we could allow it, but there is no point. +fi + +# Is topic ever merged to next? If so you should not be rebasing it. +only_next_1=`git rev-list ^master "^$topic" ${publish} | sort` +only_next_2=`git rev-list ^master ${publish} | sort` +if test "$only_next_1" = "$only_next_2" +then + not_in_topic=`git rev-list "^$topic" master` + if test -z "$not_in_topic" + then + echo >&2 "$topic is already up-to-date with master" + exit 1 ;# we could allow it, but there is no point. + else + exit 0 + fi +else + not_in_next=`git rev-list --pretty=oneline ^${publish} "$topic"` + /usr/bin/perl -e ' + my $topic = $ARGV[0]; + my $msg = "* $topic has commits already merged to public branch:\n"; + my (%not_in_next) = map { + /^([0-9a-f]+) /; + ($1 => 1); + } split(/\n/, $ARGV[1]); + for my $elem (map { + /^([0-9a-f]+) (.*)$/; + [$1 => $2]; + } split(/\n/, $ARGV[2])) { + if (!exists $not_in_next{$elem->[0]}) { + if ($msg) { + print STDERR $msg; + undef $msg; + } + print STDERR " $elem->[1]\n"; + } + } + ' "$topic" "$not_in_next" "$not_in_master" + exit 1 +fi + +<<\DOC_END + +This sample hook safeguards topic branches that have been +published from being rewound. + +The workflow assumed here is: + + * Once a topic branch forks from "master", "master" is never + merged into it again (either directly or indirectly). + + * Once a topic branch is fully cooked and merged into "master", + it is deleted. If you need to build on top of it to correct + earlier mistakes, a new topic branch is created by forking at + the tip of the "master". This is not strictly necessary, but + it makes it easier to keep your history simple. + + * Whenever you need to test or publish your changes to topic + branches, merge them into "next" branch. + +The script, being an example, hardcodes the publish branch name +to be "next", but it is trivial to make it configurable via +$GIT_DIR/config mechanism. + +With this workflow, you would want to know: + +(1) ... if a topic branch has ever been merged to "next". Young + topic branches can have stupid mistakes you would rather + clean up before publishing, and things that have not been + merged into other branches can be easily rebased without + affecting other people. But once it is published, you would + not want to rewind it. + +(2) ... if a topic branch has been fully merged to "master". + Then you can delete it. More importantly, you should not + build on top of it -- other people may already want to + change things related to the topic as patches against your + "master", so if you need further changes, it is better to + fork the topic (perhaps with the same name) afresh from the + tip of "master". + +Let's look at this example: + + o---o---o---o---o---o---o---o---o---o "next" + / / / / + / a---a---b A / / + / / / / + / / c---c---c---c B / + / / / \ / + / / / b---b C \ / + / / / / \ / + ---o---o---o---o---o---o---o---o---o---o---o "master" + + +A, B and C are topic branches. + + * A has one fix since it was merged up to "next". + + * B has finished. It has been fully merged up to "master" and "next", + and is ready to be deleted. + + * C has not merged to "next" at all. + +We would want to allow C to be rebased, refuse A, and encourage +B to be deleted. + +To compute (1): + + git rev-list ^master ^topic next + git rev-list ^master next + + if these match, topic has not merged in next at all. + +To compute (2): + + git rev-list master..topic + + if this is empty, it is fully merged to "master". + +DOC_END diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-receive b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-receive new file mode 100755 index 000000000..412701305 --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-receive @@ -0,0 +1,7 @@ +#!/usr/bin/env bash +ORI_DIR=`pwd` +SHELL_FOLDER=$(cd "$(dirname "$0")";pwd) +cd "$ORI_DIR" +for i in `ls "$SHELL_FOLDER/pre-receive.d"`; do + sh "$SHELL_FOLDER/pre-receive.d/$i" +done \ No newline at end of file diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-receive.d/gitea b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-receive.d/gitea new file mode 100755 index 000000000..49d094063 --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/pre-receive.d/gitea @@ -0,0 +1,2 @@ +#!/usr/bin/env bash +"$GITEA_ROOT/gitea" hook --config="$GITEA_ROOT/$GITEA_CONF" pre-receive diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/hooks/prepare-commit-msg.sample b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/prepare-commit-msg.sample new file mode 100755 index 000000000..f093a02ec --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/prepare-commit-msg.sample @@ -0,0 +1,36 @@ +#!/bin/sh +# +# An example hook script to prepare the commit log message. +# Called by "git commit" with the name of the file that has the +# commit message, followed by the description of the commit +# message's source. The hook's purpose is to edit the commit +# message file. If the hook fails with a non-zero status, +# the commit is aborted. +# +# To enable this hook, rename this file to "prepare-commit-msg". + +# This hook includes three examples. The first comments out the +# "Conflicts:" part of a merge commit. +# +# The second includes the output of "git diff --name-status -r" +# into the message, just before the "git status" output. It is +# commented because it doesn't cope with --amend or with squashed +# commits. +# +# The third example adds a Signed-off-by line to the message, that can +# still be edited. This is rarely a good idea. + +case "$2,$3" in + merge,) + /usr/bin/perl -i.bak -ne 's/^/# /, s/^# #/#/ if /^Conflicts/ .. /#/; print' "$1" ;; + +# ,|template,) +# /usr/bin/perl -i.bak -pe ' +# print "\n" . `git diff --cached --name-status -r` +# if /^#/ && $first++ == 0' "$1" ;; + + *) ;; +esac + +# SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/Signed-off-by: \1/p') +# grep -qs "^$SOB" "$1" || echo "$SOB" >> "$1" diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/hooks/update b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/update new file mode 100755 index 000000000..c186fe4a1 --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/update @@ -0,0 +1,7 @@ +#!/usr/bin/env bash +ORI_DIR=`pwd` +SHELL_FOLDER=$(cd "$(dirname "$0")";pwd) +cd "$ORI_DIR" +for i in `ls "$SHELL_FOLDER/update.d"`; do + sh "$SHELL_FOLDER/update.d/$i" $1 $2 $3 +done \ No newline at end of file diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/hooks/update.d/gitea b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/update.d/gitea new file mode 100755 index 000000000..38101c242 --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/update.d/gitea @@ -0,0 +1,2 @@ +#!/usr/bin/env bash +"$GITEA_ROOT/gitea" hook --config="$GITEA_ROOT/$GITEA_CONF" update $1 $2 $3 diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/hooks/update.sample b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/update.sample new file mode 100755 index 000000000..80ba94135 --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/hooks/update.sample @@ -0,0 +1,128 @@ +#!/bin/sh +# +# An example hook script to block unannotated tags from entering. +# Called by "git receive-pack" with arguments: refname sha1-old sha1-new +# +# To enable this hook, rename this file to "update". +# +# Config +# ------ +# hooks.allowunannotated +# This boolean sets whether unannotated tags will be allowed into the +# repository. By default they won't be. +# hooks.allowdeletetag +# This boolean sets whether deleting tags will be allowed in the +# repository. By default they won't be. +# hooks.allowmodifytag +# This boolean sets whether a tag may be modified after creation. By default +# it won't be. +# hooks.allowdeletebranch +# This boolean sets whether deleting branches will be allowed in the +# repository. By default they won't be. +# hooks.denycreatebranch +# This boolean sets whether remotely creating branches will be denied +# in the repository. By default this is allowed. +# + +# --- Command line +refname="$1" +oldrev="$2" +newrev="$3" + +# --- Safety check +if [ -z "$GIT_DIR" ]; then + echo "Don't run this script from the command line." >&2 + echo " (if you want, you could supply GIT_DIR then run" >&2 + echo " $0 )" >&2 + exit 1 +fi + +if [ -z "$refname" -o -z "$oldrev" -o -z "$newrev" ]; then + echo "usage: $0 " >&2 + exit 1 +fi + +# --- Config +allowunannotated=$(git config --bool hooks.allowunannotated) +allowdeletebranch=$(git config --bool hooks.allowdeletebranch) +denycreatebranch=$(git config --bool hooks.denycreatebranch) +allowdeletetag=$(git config --bool hooks.allowdeletetag) +allowmodifytag=$(git config --bool hooks.allowmodifytag) + +# check for no description +projectdesc=$(sed -e '1q' "$GIT_DIR/description") +case "$projectdesc" in +"Unnamed repository"* | "") + echo "*** Project description file hasn't been set" >&2 + exit 1 + ;; +esac + +# --- Check types +# if $newrev is 0000...0000, it's a commit to delete a ref. +zero="0000000000000000000000000000000000000000" +if [ "$newrev" = "$zero" ]; then + newrev_type=delete +else + newrev_type=$(git cat-file -t $newrev) +fi + +case "$refname","$newrev_type" in + refs/tags/*,commit) + # un-annotated tag + short_refname=${refname##refs/tags/} + if [ "$allowunannotated" != "true" ]; then + echo "*** The un-annotated tag, $short_refname, is not allowed in this repository" >&2 + echo "*** Use 'git tag [ -a | -s ]' for tags you want to propagate." >&2 + exit 1 + fi + ;; + refs/tags/*,delete) + # delete tag + if [ "$allowdeletetag" != "true" ]; then + echo "*** Deleting a tag is not allowed in this repository" >&2 + exit 1 + fi + ;; + refs/tags/*,tag) + # annotated tag + if [ "$allowmodifytag" != "true" ] && git rev-parse $refname > /dev/null 2>&1 + then + echo "*** Tag '$refname' already exists." >&2 + echo "*** Modifying a tag is not allowed in this repository." >&2 + exit 1 + fi + ;; + refs/heads/*,commit) + # branch + if [ "$oldrev" = "$zero" -a "$denycreatebranch" = "true" ]; then + echo "*** Creating a branch is not allowed in this repository" >&2 + exit 1 + fi + ;; + refs/heads/*,delete) + # delete branch + if [ "$allowdeletebranch" != "true" ]; then + echo "*** Deleting a branch is not allowed in this repository" >&2 + exit 1 + fi + ;; + refs/remotes/*,commit) + # tracking branch + ;; + refs/remotes/*,delete) + # delete tracking branch + if [ "$allowdeletebranch" != "true" ]; then + echo "*** Deleting a tracking branch is not allowed in this repository" >&2 + exit 1 + fi + ;; + *) + # Anything else (is there anything else?) + echo "*** Update hook: unknown type of update to ref $refname of type $newrev_type" >&2 + exit 1 + ;; +esac + +# --- Finished +exit 0 diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/info/exclude b/integrations/gitea-repositories-meta/user2/utf8.git/info/exclude new file mode 100644 index 000000000..a5196d1be --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/info/exclude @@ -0,0 +1,6 @@ +# git ls-files --others --exclude-from=.git/info/exclude +# Lines that start with '#' are comments. +# For a project mostly in C, the following would be a good set of +# exclude patterns (uncomment them if you want to use them): +# *.[oa] +# *~ diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/info/refs b/integrations/gitea-repositories-meta/user2/utf8.git/info/refs new file mode 100644 index 000000000..29eaf9f16 --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/info/refs @@ -0,0 +1,9 @@ +ebf146f803fccbc1471ef01d8fa0fe12c14e61a5 refs/heads/Grüßen +3a810dbf6b96afaa8c5f69a8b6ec1dabfca7368b refs/heads/Plus+Is+Not+Space +3aa73c3499bff049a352b4e265575373e964b89a refs/heads/master +ebf146f803fccbc1471ef01d8fa0fe12c14e61a5 refs/heads/ГлавнаяВетка +ebf146f803fccbc1471ef01d8fa0fe12c14e61a5 refs/heads/а/б/в +28d579e4920fbf4f66e71dab3e779d9fbf41422a refs/heads/ブランチ +ebf146f803fccbc1471ef01d8fa0fe12c14e61a5 refs/tags/Ё/人 +ebf146f803fccbc1471ef01d8fa0fe12c14e61a5 refs/tags/Тэг +28d579e4920fbf4f66e71dab3e779d9fbf41422a refs/tags/タグ diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/objects/14/c42687126acae9d1ad41d7bdb528f811065a6a b/integrations/gitea-repositories-meta/user2/utf8.git/objects/14/c42687126acae9d1ad41d7bdb528f811065a6a new file mode 100644 index 0000000000000000000000000000000000000000..19fdbf1232d7c8a9eee245ce2e08b5e6a6e4231f GIT binary patch literal 39 vcmb7v}7zBBpb$Sp+{a(;`177k zQlj?{K^0wCa$&=Tofme4lzn0PpMGGon2cq|?Qar&dAy&(|CU0PJ#L=*xM|_zrX`P? hSA&#_98qf*$~yJ(;#$Y+d$(%*5M+zW0s!v2HA#m3K7;@O literal 0 HcmV?d00001 diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/objects/28/d579e4920fbf4f66e71dab3e779d9fbf41422a b/integrations/gitea-repositories-meta/user2/utf8.git/objects/28/d579e4920fbf4f66e71dab3e779d9fbf41422a new file mode 100644 index 000000000..413ef4cea --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/objects/28/d579e4920fbf4f66e71dab3e779d9fbf41422a @@ -0,0 +1,3 @@ +xAj0 E)R(ci 셜6·>d}u}O)xi]%RKvPۢl +u[dǣ>Q \ No newline at end of file diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/objects/3a/810dbf6b96afaa8c5f69a8b6ec1dabfca7368b b/integrations/gitea-repositories-meta/user2/utf8.git/objects/3a/810dbf6b96afaa8c5f69a8b6ec1dabfca7368b new file mode 100644 index 0000000000000000000000000000000000000000..4f6634b5f78773a3816b68bae355c95b7e40467b GIT binary patch literal 176 zcmV;h08jsT0hNwRio-Av1+&&EdOt9z^|J)SkQ_yy?pR>UMwUsAKPESrRY4UGUf$NV z4p7G2Mkj(8qC>AGCpP3w2%+etWM-UvutqyKNo2BOkDb~8N{q&_mzr}<8O?;m5{u_3 znNVGZ97ZeRIp(dyc~DpI^TD0oaordC&fEG6Xtj0PD{bIQDk;TfuWN(;H4=|fAobYt e46iz7*q8HwqdwaKu@&ID&?nReb%;OcbWN!Yc~xHk literal 0 HcmV?d00001 diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/objects/3a/a73c3499bff049a352b4e265575373e964b89a b/integrations/gitea-repositories-meta/user2/utf8.git/objects/3a/a73c3499bff049a352b4e265575373e964b89a new file mode 100644 index 0000000000000000000000000000000000000000..0fcdfdfe72058851cfdae090f7320190c396a413 GIT binary patch literal 137 zcmV;40CxX)0d0-T3c@fD06pg`_NWMDlQgM;B3}KBuvs;bM~Nxu-wW;4(_Cg4syW9F z(&|HR%wPl3Qrs-`o_;8*ZgGUeb5qkIzfu rp|869Fkb@zaz_c5 literal 0 HcmV?d00001 diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/objects/56/92bcf9f7c9eacb1ad68442161f2573877f96f4 b/integrations/gitea-repositories-meta/user2/utf8.git/objects/56/92bcf9f7c9eacb1ad68442161f2573877f96f4 new file mode 100644 index 0000000000000000000000000000000000000000..36c0db1ece6fb945c1db1ce8451549b410deba3b GIT binary patch literal 49 zcmbj!#xg=%=|p78YX^9|HEuX8d$Lyut-quz7A FSpeOW5`q8# literal 0 HcmV?d00001 diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/objects/6d/0c79ce3401c67d1ad522e61c47083a9fdee16c b/integrations/gitea-repositories-meta/user2/utf8.git/objects/6d/0c79ce3401c67d1ad522e61c47083a9fdee16c new file mode 100644 index 0000000000000000000000000000000000000000..dab81f8d1111f17ff40edb0b88578213fb3e4541 GIT binary patch literal 54 zcmV-60LlM&0V^p=O;s>9XD~D{Ff%bx2y%6F@paY9O<}M)#^ETS5I;lQ$6xOF^PWvo MqW2F002iqaGa>{P!~g&Q literal 0 HcmV?d00001 diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/objects/a9/a61830fbf4e84999d3b20cf178954366701fe5 b/integrations/gitea-repositories-meta/user2/utf8.git/objects/a9/a61830fbf4e84999d3b20cf178954366701fe5 new file mode 100644 index 0000000000000000000000000000000000000000..a2ceb0044af3dbe2bcaaf2a4358c94e7e05c9eec GIT binary patch literal 129 zcmV-{0Dk{?0V^p=O;s>7GGZ_^FfcPQQ3!H%bn$i7%S~ahI>zBBpb$Sp+{a(;`177k zQlj?{K@}zDrD$iCXlE8{mnG(8rhrt3P1^JG`^i_QrLMI&iOH)Lx7Sbm0#$us$%PFU jc3#*GQuc-EfBJ#VVltK;x4%jB![9@-!Z,wMW|NPۮs}o.rUQM \ No newline at end of file diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/objects/ee/9686cb562f492f64381bff7f298b2a1c67a141 b/integrations/gitea-repositories-meta/user2/utf8.git/objects/ee/9686cb562f492f64381bff7f298b2a1c67a141 new file mode 100644 index 0000000000000000000000000000000000000000..013c49979316d8db440a50877d7d28c58a023596 GIT binary patch literal 88 zcmV-e0H^AV=y!@Ff%bx2y%6F@paY9O<}M)#^ETS5I;lQ$6xOF^PWvo uqW2F$6l literal 0 HcmV?d00001 diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/objects/f4/02ff67c0b3161c3988dbf6188e6e0df257fd75 b/integrations/gitea-repositories-meta/user2/utf8.git/objects/f4/02ff67c0b3161c3988dbf6188e6e0df257fd75 new file mode 100644 index 0000000000000000000000000000000000000000..4ce3cc4136f369e255057396edf62b57e0ce7358 GIT binary patch literal 52 zcmV-40L%Y)0Rbrh*8gH`Z(<-bGXNtX(4o-2(6rFC(SXpl(74dN(7w>MAkl=-u+X{C KyU?)5$Qbyj6dn%% literal 0 HcmV?d00001 diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/objects/info/packs b/integrations/gitea-repositories-meta/user2/utf8.git/objects/info/packs new file mode 100644 index 000000000..8b1378917 --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/objects/info/packs @@ -0,0 +1 @@ + diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/Grüßen b/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/Grüßen new file mode 100644 index 000000000..abd33644f --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/Grüßen @@ -0,0 +1 @@ +ebf146f803fccbc1471ef01d8fa0fe12c14e61a5 diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/Plus+Is+Not+Space b/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/Plus+Is+Not+Space new file mode 100644 index 000000000..00dd05db8 --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/Plus+Is+Not+Space @@ -0,0 +1 @@ +3a810dbf6b96afaa8c5f69a8b6ec1dabfca7368b diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/master b/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/master new file mode 100644 index 000000000..560458b5a --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/master @@ -0,0 +1 @@ +3aa73c3499bff049a352b4e265575373e964b89a diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/ГлавнаяВетка b/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/ГлавнаяВетка new file mode 100644 index 000000000..abd33644f --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/ГлавнаяВетка @@ -0,0 +1 @@ +ebf146f803fccbc1471ef01d8fa0fe12c14e61a5 diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/а/б/в b/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/а/б/в new file mode 100644 index 000000000..abd33644f --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/а/б/в @@ -0,0 +1 @@ +ebf146f803fccbc1471ef01d8fa0fe12c14e61a5 diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/ブランチ b/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/ブランチ new file mode 100644 index 000000000..b0935a912 --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/refs/heads/ブランチ @@ -0,0 +1 @@ +28d579e4920fbf4f66e71dab3e779d9fbf41422a diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/refs/tags/Ё/人 b/integrations/gitea-repositories-meta/user2/utf8.git/refs/tags/Ё/人 new file mode 100644 index 000000000..abd33644f --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/refs/tags/Ё/人 @@ -0,0 +1 @@ +ebf146f803fccbc1471ef01d8fa0fe12c14e61a5 diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/refs/tags/Тэг b/integrations/gitea-repositories-meta/user2/utf8.git/refs/tags/Тэг new file mode 100644 index 000000000..abd33644f --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/refs/tags/Тэг @@ -0,0 +1 @@ +ebf146f803fccbc1471ef01d8fa0fe12c14e61a5 diff --git a/integrations/gitea-repositories-meta/user2/utf8.git/refs/tags/タグ b/integrations/gitea-repositories-meta/user2/utf8.git/refs/tags/タグ new file mode 100644 index 000000000..b0935a912 --- /dev/null +++ b/integrations/gitea-repositories-meta/user2/utf8.git/refs/tags/タグ @@ -0,0 +1 @@ +28d579e4920fbf4f66e71dab3e779d9fbf41422a diff --git a/integrations/nonascii_branches_test.go b/integrations/nonascii_branches_test.go new file mode 100644 index 000000000..e59a5ef8b --- /dev/null +++ b/integrations/nonascii_branches_test.go @@ -0,0 +1,178 @@ +// Copyright 2018 The Gitea Authors. All rights reserved. +// Use of this source code is governed by a MIT-style +// license that can be found in the LICENSE file. + +package integrations + +import ( + "net/http" + "path" + "testing" + + "github.com/stretchr/testify/assert" +) + +func testSrcRouteRedirect(t *testing.T, session *TestSession, user, repo, route, expectedLocation string, expectedStatus int) { + prefix := path.Join("/", user, repo, "src") + + // Make request + req := NewRequest(t, "GET", path.Join(prefix, route)) + resp := session.MakeRequest(t, req, http.StatusFound) + + // Check Location header + location := resp.HeaderMap.Get("Location") + assert.Equal(t, path.Join(prefix, expectedLocation), location) + + // Perform redirect + req = NewRequest(t, "GET", location) + resp = session.MakeRequest(t, req, expectedStatus) +} + +func setDefaultBranch(t *testing.T, session *TestSession, user, repo, branch string) { + location := path.Join("/", user, repo, "settings/branches") + csrf := GetCSRF(t, session, location) + req := NewRequestWithValues(t, "POST", location, map[string]string{ + "_csrf": csrf, + "action": "default_branch", + "branch": branch, + }) + session.MakeRequest(t, req, http.StatusFound) +} + +func TestNonasciiBranches(t *testing.T) { + testRedirects := []struct { + from string + to string + status int + }{ + // Branches + { + from: "master", + to: "branch/master", + status: http.StatusOK, + }, + { + from: "master/README.md", + to: "branch/master/README.md", + status: http.StatusOK, + }, + { + from: "master/badfile", + to: "branch/master/badfile", + status: http.StatusNotFound, // it does not exists + }, + { + from: "ГлавнаяВетка", + to: "branch/%d0%93%d0%bb%d0%b0%d0%b2%d0%bd%d0%b0%d1%8f%d0%92%d0%b5%d1%82%d0%ba%d0%b0", + status: http.StatusOK, + }, + { + from: "а/б/в", + to: "branch/%d0%b0/%d0%b1/%d0%b2", + status: http.StatusOK, + }, + { + from: "Grüßen/README.md", + to: "branch/Gr%c3%bc%c3%9fen/README.md", + status: http.StatusOK, + }, + { + from: "Plus+Is+Not+Space", + to: "branch/Plus+Is+Not+Space", + status: http.StatusOK, + }, + { + from: "Plus+Is+Not+Space/Файл.md", + to: "branch/Plus+Is+Not+Space/%d0%a4%d0%b0%d0%b9%d0%bb.md", + status: http.StatusOK, + }, + { + from: "Plus+Is+Not+Space/and+it+is+valid.md", + to: "branch/Plus+Is+Not+Space/and+it+is+valid.md", + status: http.StatusOK, + }, + { + from: "ブランチ", + to: "branch/%e3%83%96%e3%83%a9%e3%83%b3%e3%83%81", + status: http.StatusOK, + }, + // Tags + { + from: "Тэг", + to: "tag/%d0%a2%d1%8d%d0%b3", + status: http.StatusOK, + }, + { + from: "Ё/人", + to: "tag/%d0%81/%e4%ba%ba", + status: http.StatusOK, + }, + { + from: "タグ", + to: "tag/%e3%82%bf%e3%82%b0", + status: http.StatusOK, + }, + { + from: "タグ/ファイル.md", + to: "tag/%e3%82%bf%e3%82%b0/%e3%83%95%e3%82%a1%e3%82%a4%e3%83%ab.md", + status: http.StatusOK, + }, + // Files + { + from: "README.md", + to: "branch/Plus+Is+Not+Space/README.md", + status: http.StatusOK, + }, + { + from: "Файл.md", + to: "branch/Plus+Is+Not+Space/%d0%a4%d0%b0%d0%b9%d0%bb.md", + status: http.StatusOK, + }, + { + from: "ファイル.md", + to: "branch/Plus+Is+Not+Space/%e3%83%95%e3%82%a1%e3%82%a4%e3%83%ab.md", + status: http.StatusNotFound, // it's not on default branch + }, + // Same but url-encoded (few tests) + { + from: "%E3%83%96%E3%83%A9%E3%83%B3%E3%83%81", + to: "branch/%e3%83%96%e3%83%a9%e3%83%b3%e3%83%81", + status: http.StatusOK, + }, + { + from: "%E3%82%BF%E3%82%b0", + to: "tag/%e3%82%bf%e3%82%b0", + status: http.StatusOK, + }, + { + from: "%D0%A4%D0%B0%D0%B9%D0%BB.md", + to: "branch/Plus+Is+Not+Space/%d0%a4%d0%b0%d0%b9%d0%bb.md", + status: http.StatusOK, + }, + { + from: "%D0%81%2F%E4%BA%BA", + to: "tag/%d0%81/%e4%ba%ba", + status: http.StatusOK, + }, + { + from: "Ё%2F%E4%BA%BA", + to: "tag/%d0%81/%e4%ba%ba", + status: http.StatusOK, + }, + } + + prepareTestEnv(t) + + user := "user2" + repo := "utf8" + session := loginUser(t, user) + + setDefaultBranch(t, session, user, repo, "Plus+Is+Not+Space") + + for _, test := range testRedirects { + testSrcRouteRedirect(t, session, user, repo, test.from, test.to, test.status) + } + + setDefaultBranch(t, session, user, repo, "master") + +} diff --git a/models/fixtures/repo_unit.yml b/models/fixtures/repo_unit.yml index 6780de753..581f9d6ed 100644 --- a/models/fixtures/repo_unit.yml +++ b/models/fixtures/repo_unit.yml @@ -74,3 +74,38 @@ type: 1 config: "{}" created_unix: 1524304355 + +- + id: 12 + repo_id: 33 + type: 1 + config: "{}" + created_unix: 1535593231 + +- + id: 13 + repo_id: 33 + type: 2 + config: "{\"EnableTimetracker\":true,\"AllowOnlyContributorsToTrackTime\":true}" + created_unix: 1535593231 + +- + id: 14 + repo_id: 33 + type: 3 + config: "{\"IgnoreWhitespaceConflicts\":false,\"AllowMerge\":true,\"AllowRebase\":true,\"AllowSquash\":true}" + created_unix: 1535593231 + +- + id: 15 + repo_id: 33 + type: 4 + config: "{}" + created_unix: 1535593231 + +- + id: 16 + repo_id: 33 + type: 5 + config: "{}" + created_unix: 1535593231 \ No newline at end of file diff --git a/models/fixtures/repository.yml b/models/fixtures/repository.yml index 3238b65ea..54f3ed7b0 100644 --- a/models/fixtures/repository.yml +++ b/models/fixtures/repository.yml @@ -400,3 +400,10 @@ num_forks: 0 num_issues: 0 is_mirror: false + +- + id: 33 + owner_id: 2 + lower_name: utf8 + name: utf8 + is_private: false diff --git a/models/fixtures/user.yml b/models/fixtures/user.yml index a2e3b88d7..55606e42b 100644 --- a/models/fixtures/user.yml +++ b/models/fixtures/user.yml @@ -27,7 +27,7 @@ is_admin: false avatar: avatar2 avatar_email: user2@example.com - num_repos: 5 + num_repos: 6 num_stars: 2 num_followers: 2 num_following: 1 diff --git a/models/repo_list_test.go b/models/repo_list_test.go index 164bc19bf..4b5d659ce 100644 --- a/models/repo_list_test.go +++ b/models/repo_list_test.go @@ -147,10 +147,10 @@ func TestSearchRepositoryByName(t *testing.T) { count: 14}, {name: "AllPublic/PublicRepositoriesOfUserIncludingCollaborative", opts: &SearchRepoOptions{Page: 1, PageSize: 10, OwnerID: 15, AllPublic: true}, - count: 16}, + count: 17}, {name: "AllPublic/PublicAndPrivateRepositoriesOfUserIncludingCollaborative", opts: &SearchRepoOptions{Page: 1, PageSize: 10, OwnerID: 15, Private: true, AllPublic: true}, - count: 20}, + count: 21}, {name: "AllPublic/PublicAndPrivateRepositoriesOfUserIncludingCollaborativeByName", opts: &SearchRepoOptions{Keyword: "test", Page: 1, PageSize: 10, OwnerID: 15, Private: true, AllPublic: true}, count: 13}, @@ -159,7 +159,7 @@ func TestSearchRepositoryByName(t *testing.T) { count: 11}, {name: "AllPublic/PublicRepositoriesOfOrganization", opts: &SearchRepoOptions{Page: 1, PageSize: 10, OwnerID: 17, AllPublic: true, Collaborate: util.OptionalBoolFalse}, - count: 16}, + count: 17}, } for _, testCase := range testCases { diff --git a/modules/context/repo.go b/modules/context/repo.go index 17a319ecc..7221ad7c8 100644 --- a/modules/context/repo.go +++ b/modules/context/repo.go @@ -625,7 +625,7 @@ func RepoRefByType(refType RepoRefType) macaron.Handler { // redirect from old URL scheme to new URL scheme ctx.Redirect(path.Join( setting.AppSubURL, - strings.TrimSuffix(ctx.Req.URL.String(), ctx.Params("*")), + strings.TrimSuffix(ctx.Req.URL.Path, ctx.Params("*")), ctx.Repo.BranchNameSubURL(), ctx.Repo.TreePath)) return