From d389ed25a53a2e45a9a820f432772f40594babc0 Mon Sep 17 00:00:00 2001 From: Shuanglei Tao Date: Wed, 28 Jun 2017 14:08:47 +0800 Subject: [PATCH] Fix: `http: multiple response.WriteHeader calls` (#2038) We can't change the http status code here, because the response has been written. --- routers/repo/http.go | 1 - 1 file changed, 1 deletion(-) diff --git a/routers/repo/http.go b/routers/repo/http.go index 0bea513ef..b7e83536c 100644 --- a/routers/repo/http.go +++ b/routers/repo/http.go @@ -381,7 +381,6 @@ func serviceRPC(h serviceHandler, service string) { cmd.Stderr = &stderr if err := cmd.Run(); err != nil { log.GitLogger.Error(2, "fail to serve RPC(%s): %v - %v", service, err, stderr) - h.w.WriteHeader(http.StatusInternalServerError) return } }