From f91b8c5f53dce072ed9fe72dbf4ab10cbeaa8008 Mon Sep 17 00:00:00 2001 From: Bo-Yi Wu Date: Mon, 9 Jan 2017 22:36:23 +0800 Subject: [PATCH] refactor: check the error returned by os.MkdirAll() --- modules/setting/setting.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/modules/setting/setting.go b/modules/setting/setting.go index 7fd4cfc2f..275e4b58a 100644 --- a/modules/setting/setting.go +++ b/modules/setting/setting.go @@ -660,7 +660,9 @@ please consider changing to GITEA_CUSTOM`) cfg.Section("server").Key("LFS_JWT_SECRET").SetValue(LFS.JWTSecretBase64) - os.MkdirAll(filepath.Dir(CustomConf), os.ModePerm) + if err := os.MkdirAll(filepath.Dir(CustomConf), os.ModePerm); err != nil { + log.Fatal(4, "Fail to create '%s': %v", CustomConf, err) + } if err := cfg.SaveTo(CustomConf); err != nil { log.Fatal(4, "Error saving generated JWT Secret to custom config: %v", err) return