Lunny Xiao
04ec79579c
fix orgnization webhooks ( #2422 )
...
* fix org webhooks
* remove trace code
2017-08-30 13:36:52 +08:00
Lunny Xiao
5de94a67cf
some refactors for issue and comments ( #2419 )
2017-08-30 07:31:33 +03:00
Lunny Xiao
3e6fed368b
fix webhook test ( #2415 )
...
* fix webhook test
* fix error message
* fix typo
2017-08-29 22:55:24 +08:00
Lauris BH
edb95faba2
Fix releases to be counted from database not tags ( #2389 )
2017-08-28 22:06:10 +08:00
Morlinest
8e61823ec4
Fix tests code to prevent some runtime errors ( #2381 )
...
* Fix tests code to prevent some runtime errors
* Reduce nesting
2017-08-28 12:17:45 +03:00
Lunny Xiao
ced50e0ec1
Implementation of discord webhook ( #2402 )
...
* implementation of discord webhook
* fix webhooks
* fix typo and unnecessary color values
* fix typo
* fix imports and revert changes to webhook_slack.go
2017-08-28 13:06:45 +08:00
Lunny Xiao
e41da3845d
fix duplicated feed ( #2370 )
2017-08-28 10:26:04 +08:00
Morlinest
0f2c98adcd
Fix "index out of range" runtime error in repo_list tests ( #2376 )
2017-08-28 09:33:38 +08:00
Manuel
d9d8fad230
Add UseCompatSSHURI setting ( #2356 )
...
* Add UseCompatSSHURI setting
Signed-off-by: Manuel Kroeber <manuel.kroeber@gmail.com> (+1 squashed commits)
Squashed commits:
[dda2dc79] Add ForceCloneSSHURL setting
Signed-off-by: Manuel Kroeber <manuel.kroeber@gmail.com>
* Make protocol if construct more readable
Signed-off-by: Manuel Kroeber <manuel.kroeber@gmail.com>
2017-08-26 15:57:41 +02:00
Lunny Xiao
f61a1d210c
Fix missing collabrative repos ( #2367 )
...
* fix missing collabrative repos
* fix bug of collabrative
* fix SQL quotes
2017-08-24 22:01:03 +08:00
Zsombor
da230a2872
Add possibility to record branch or tag information in an issue ( #780 )
2017-08-24 15:30:27 +03:00
Lunny Xiao
64b7068846
Add more test for login links and fix a bug on action retrieve ( #2361 )
...
* add more test for login links and fix a bug on action retrieve
2017-08-23 12:53:35 +03:00
Ethan Koenig
fd6e91077a
Fix SQL condition bug in GetFeeds(..) ( #2360 )
2017-08-23 08:51:58 +03:00
Bwko
1a5fe4326f
Add collaborative repositories to the dashboard ( #2205 )
...
* Add collaborative repositories to the dashboard
Remove some unused code from the Dashboard func
* fix some bug and some refactor
* fix tests
2017-08-23 09:30:54 +08:00
Lunny Xiao
2c6a0fdca8
update latest xorm version to vendor ( #2353 )
2017-08-22 14:39:52 +03:00
Ethan Koenig
7907786040
Trigger sync webhooks on UI commit ( #2302 )
...
* Trigger sync webhooks on UI commit
* Also fix UI upload/delete
2017-08-17 15:22:08 +08:00
Lunny Xiao
f960e19c59
Only update needed columns when update user ( #2296 )
...
* only update needed columns when update user
* fix missing update_unix column
2017-08-12 22:18:44 +08:00
Lunny Xiao
921d90fd8b
fix 500 error when view an issue which's milestone deleted ( #2297 )
2017-08-12 10:15:30 +08:00
G
34df9deff1
Convert xorm literal queries to method calls ( #2253 )
2017-08-04 12:42:51 +08:00
Ethan Koenig
7e0654bd9e
Fix counts on issues dashboard ( #2215 )
...
* Fix counts on issues dashboard
* setupSess -> setupSession
* Unit test
* Load repo owners for issues
2017-08-03 13:09:16 +08:00
Ethan Koenig
f29458bd3a
EnableUnit() -> UnitEnabled() ( #2242 )
2017-08-02 11:46:54 +03:00
G
66e8262530
Replace calls to xorm UseBool with Where ( #2237 )
2017-08-01 13:47:31 +08:00
Ethan Koenig
fd45a032a7
Fix bare-repo bugs ( #2199 )
...
* Fix bare-repo bugs
* Integration tests
* Unused import
2017-07-27 12:23:38 +03:00
Ethan Koenig
a27863b6d1
Fix issue updated_unix bug ( #2204 )
2017-07-27 09:20:38 +08:00
Ethan Koenig
5f37944dff
Fix unclosed session bug ( #2214 )
2017-07-26 17:30:47 +08:00
Lauris BH
1d032f5220
Fix compiling without sqlite and gcc ( #2177 )
2017-07-26 15:27:30 +08:00
Ethan Koenig
48898e5d0b
Fix PR nil-dereference bug ( #2195 )
...
* Fix PR nil-dereference bug
* Revert to original error format
2017-07-26 15:16:45 +08:00
Lauris BH
dde0052ca2
Fix key usage time update if the key is used in parallel for multiple operations ( #2185 )
2017-07-20 11:15:10 +08:00
Lauris BH
f33e6ae09e
Remove unit types commits and settings ( #2161 )
...
* Remove unit types commits and settings
* Can not limit units in administrator teams
* Limit changing units only to teams with read and write access mode
* Small code optimization
2017-07-17 10:04:43 +08:00
Lauris BH
b639fa1648
Ignore invalid issue numbers in commit messages. Fixes #2022 ( #2150 )
2017-07-12 22:35:47 -05:00
Ethan Koenig
858324c21a
Fix username rendering bug ( #2122 )
...
* Fix username rendering bug
* XSS integration test
* Migration to unescape user full names
2017-07-12 17:58:52 +03:00
Antoine GIRARD
30787e48f2
Improve org error handling ( #2117 )
...
* Improve ErrOrgNotExist type
Return new error type
Use good error check
Use new method to check error
Update tests
* Fix unchanged method name report
2017-07-06 21:30:19 +08:00
Ethan Koenig
a52cd59727
Fix unchecked error bug ( #2110 )
2017-07-04 09:30:41 +08:00
Lauris BH
f189ccd2d6
Fix git hooks update to receive required arguments. Fixes #2090 ( #2095 )
...
* Changed migration calling so that migrations can use models package
2017-07-02 21:50:57 +08:00
Ethan Koenig
eae9154811
Fix SQL bug in models.PullRequests
2017-07-01 14:08:43 +03:00
Lauris BH
12cb6cd3c9
Merge pull request #2087 from Bwko/fix_error_exit
...
Fix exit status 1 not handled @ getMergeCommit (#2087 )
2017-06-30 15:46:49 +03:00
Bwko
b36849dc1f
Fix exit status 1 not handled @ getMergeCommit
2017-06-30 12:35:26 +02:00
Andrey Nering
935b40fd8e
Merge pull request #2083 from ethantkoenig/check_err/org_avatar
...
Don't ignore gravatar error
2017-06-29 21:30:05 -03:00
Ethan Koenig
05e3726415
Use default avatar on error
2017-06-29 12:10:33 -04:00
Lauris BH
783b1967e2
Fix release display and correct paging ( #2080 )
2017-06-29 23:11:38 +08:00
Lunny Xiao
33f3165296
remove unnecessary blank lines and wrong error log
2017-06-28 19:00:08 +02:00
iszla
3f9016430f
Pagination on releases page ( #2035 )
...
* Added count to GetReleasesByRepoID so pagination will work
* Separated it out to a new function, can then also leave the API part unaffected
* Remove extra whitespace added in untouched function
* Added comment and corrected name in error handler
* Account for if the user is owner or not in the count
* Also check if repo is draft
* revert back to the correct count in the ReleasesToDisplay loop
* Fixed lint error regarding else with return statement
* Use Cond struct instead of string, corrected name in error handler
* Removed unused return variable names
2017-06-28 22:47:00 +08:00
Lauris BH
32fc44aa83
Make time diff translatable ( #2057 )
2017-06-28 13:43:28 +08:00
Dan Magnus Lindvall
79daf31058
Setting to disable authorized_keys backup ( #1856 )
...
* Add setting to disable authorized_keys backup when rewriting public keys
Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>
* Update default value to comply with documentation
Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>
* Use tmp-file instead of bak-file for saving manually added keys.
Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>
* Change casing
Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>
* Change casing and build bakpath with sprintf only
Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>
* Only close file once
Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>
* Do not modify calcFingerprint
Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>
* Fix casing
Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>
* Change style from disable to enable
Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>
* Change name, just SSH_BACKUP_AUTHORIZED_KEYS
Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>
* Do not check for directory existence if backup is disabled
Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>
2017-06-28 09:35:35 +08:00
Ethan Koenig
80707c4736
Fix default ghost assignee bug ( #2069 )
2017-06-28 09:27:12 +08:00
Jonas Franz
441986a473
Fix "Dashboard shows deleted comments" ( #1995 )
2017-06-25 20:20:29 +02:00
Ethan Koenig
2559a34b97
Load label ID in NewLabels ( #2045 )
2017-06-25 14:15:09 +08:00
Győrvári Gábor
f2afed3098
Enable assignee e-mail notification ( #2003 )
...
* Enable assignee e-mail notification
* Check assignee and doer to avoid self made comment notifications.
* Assignee not always defined
* New method to avoid error when assignee deleted
* Assignee empty check
2017-06-23 21:43:37 +08:00
Ethan Koenig
902a749fd9
Fix fast-forward PR bug ( #1989 )
2017-06-22 09:06:57 +08:00
Lunny Xiao
d71fad2ab7
Fix #2001 and fix issue comments hidden ( #2016 )
...
* revert #2001 and fix issue comments hidden
* fix #2001
* fix import
* improve comment type
* reduce unnecessary join
* fix comment on FindCommentsOptions
2017-06-21 09:00:44 +08:00
Lauris BH
6db387a21e
Refactor session close as xorm already does everything needed internally ( #2020 )
2017-06-21 08:57:05 +08:00
Lauris BH
165cf33771
Wrong PR merge commit ID saved ( #2007 )
2017-06-19 17:37:11 +08:00
Ethan Koenig
255adc40ae
Don't show non-comments in comments API ( #2001 )
2017-06-18 17:06:17 +08:00
Lauris BH
1a906f800d
Fix GPG email checking to be case insensitive ( #1988 )
2017-06-17 18:56:40 +08:00
Lunny Xiao
e2ec4b7c23
fix bu ong normal user visit public repo ( #1984 )
2017-06-17 12:53:51 +08:00
Ethan Koenig
8fc64741d9
Fix deleted milestone bug ( #1942 )
...
* Fix deleted milestone bug
* Use locale for ghost milestone name
* Fix pointer bug
2017-06-17 12:51:28 +08:00
Ethan Koenig
ce9b86082c
Consolidate boilerplate in integration tests ( #1979 )
2017-06-17 12:49:45 +08:00
Ethan Koenig
8fcda0442e
Fix search by issue type ( #1914 )
...
* Fix search by issue type
2017-06-15 05:09:03 +02:00
Kim "BKC" Carlbäcker
bf48c8ebdd
SQLite has a query timeout. Hopefully fixes most 'database locked' errors ( #1961 )
...
* SQLite has a query timeout. Fixes 'database locked' errors
2017-06-15 04:51:17 +02:00
Lunny Xiao
31b5e9177f
fix collborators lack of units on orgnization repositories ( #1968 )
...
* fix collborators lack of units on orgnization repositories
* also change log level to debug
2017-06-15 04:50:12 +02:00
Ethan Koenig
57cabb3ad3
Fix diff of renamed and modified file ( #1967 )
2017-06-14 04:07:09 -05:00
Antoine GIRARD
274149dd14
Switch to keybase go-crypto (for some elliptic curve key) + test ( #1925 )
...
* Switch to keybase go-crypto (for some elliptic curve key) + test
* Use assert.NoError
and add a little more context to failing test description
* Use assert.(No)Error everywhere 🌈
and assert.Error in place of .Nil/.NotNil
2017-06-14 08:43:43 +08:00
Ethan Koenig
96152c38b1
Fix bug in Action.loadRepo() ( #1959 )
2017-06-14 08:37:50 +08:00
Ethan Koenig
b38b61bbc1
Fix import order ( #1951 )
2017-06-12 10:01:09 -05:00
Andrey Nering
635273cea6
Merge pull request #1829 from ethantkoenig/no_branches
...
Commitless repos should be bare
2017-06-12 11:05:01 -03:00
Ethan Koenig
9fbdd7d787
Fix engine bug in getIssueByID ( #1934 )
2017-06-11 14:39:12 +08:00
Ethan Koenig
e0a63a20e0
Fix errors caused by force push ( #1927 )
2017-06-10 21:59:13 -05:00
Dennis Keitzel
96b4780727
Gracefully handle bare repositories on API operations. ( #1932 )
...
Signed-off-by: Dennis Keitzel <github@pinshot.net>
2017-06-10 21:57:28 -05:00
Ethan Koenig
73836ce8c4
Fix ghost user bug ( #1913 )
...
Fix bug where unassigned issues would appear to be assigned to a ghost user
2017-06-09 09:51:31 +08:00
Dan Magnus Lindvall
ff7424179e
Delete Public SSH Key tmp file after calculating fingerprint ( #1855 )
...
* Delete public key tmp file after calculating fingerprint
Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>
* Move line
Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>
* Remove defer statement
Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>
* Readd defer statement and move remove
Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>
* Delete space
Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>
2017-06-08 10:08:22 +08:00
Sandro Santilli
f6b58964d7
Include formatting check to the `make test` (and thus also `check`) rule ( #1366 )
...
* Include formatting check to the `make check` rule
... and give it its own standalone target too (make fmt-check)
Show diff on fmt-check failure
Do not allow running "fmt-check" with incompatible go version
Also simplify the `fmt` rule
* Forbid running "make fmt" with Go version != 1.7 or 1.8
* Ignore bindata.go for spelling and formatting checks
also remove duplicated variable assignment for GOFILES
* Run `make fmt`
2017-06-06 08:53:16 -05:00
Phil Hopper
6ec07a6bd7
Make `LocalCopyPath` a setting instead of a hard-coded path ( #1881 )
2017-06-06 04:09:54 -05:00
Ethan Koenig
ca9169fbe9
Migration to fix existing owner team units ( #1873 )
2017-06-05 05:40:25 -05:00
Bo-Yi Wu
703d18e50d
feat: add check misspelling ( #1877 )
2017-06-05 02:49:46 -05:00
Andrey Nering
ed31dff5ab
Merge pull request #1874 from ethantkoenig/typo/issue_test
...
Fix misspelled variables
2017-06-04 17:10:40 -03:00
Ethan Koenig
9f9289fc68
Run unused test
2017-06-04 14:28:17 -04:00
Ethan Koenig
1a09afc729
Fix misspelled variables
2017-06-04 13:39:08 -04:00
Ethan Koenig
3e74b5cf51
Rename misnamed migration ( #1867 )
2017-06-04 11:09:50 +08:00
Ethan Koenig
b900c04316
Display draft releases ( #1854 )
...
* Display draft releases
* Include ctx.User in user cache
* Integration test
2017-06-03 11:46:56 +08:00
Ethan Koenig
036ce3f813
Fix bug in removeOrgRepo ( #1858 )
2017-06-02 20:06:09 -05:00
Ethan Koenig
4e5ee2b67a
Fix user profile activity feed ( #1848 )
...
* Fix user profile activity feed
* gofmt, and avoid overlapping database connections
2017-06-02 08:42:25 +08:00
Ethan Koenig
a977ab7889
Don't ignore error in getMergeCommit ( #1843 )
2017-05-31 19:51:24 -05:00
Ethan Koenig
336e311a7c
Fix locking bug in removeOrgRepo ( #1842 )
2017-06-01 08:41:14 +08:00
Ethan Koenig
5554165a0c
Fix pull request compare link ( #1832 )
...
* Fix pull request compare link
* Integration test
2017-05-31 09:47:42 -05:00
Ethan Koenig
bfb44f8854
Fix status table race condition ( #1835 )
2017-05-31 16:57:17 +08:00
Ethan Koenig
474d636794
Update code.gitea.io/git ( #1824 )
...
* Update code.gitea.io/git
* Update function calls
* govendor fetch
2017-05-30 04:32:01 -05:00
Ethan Koenig
367ff327ed
Use ghost users in issues/PRs ( #1831 )
2017-05-30 14:08:36 +08:00
Timo Myyrä
2525195749
use writeTmpKeyFile in calcFingerprint ( #1828 )
...
this makes calcFingerprint use SSH.KeyTestpath instead of os temp dir.
2017-05-29 19:51:16 +08:00
Jonas Östanbäck
b93568cce4
xxx_active_code_live setting in printed in hours and minutes instead … ( #1814 )
...
* xxx_active_code_live setting in printed in hours and minutes instead of just hours
* Update app.ini description of xxx_code_lives settings
2017-05-29 02:35:47 -05:00
Rémy Boulanouar
e0c6ab2d44
Add Gitea Webhook ( #1755 )
...
* Replace Gogs by Gitea
* Fix missing changes
* Create Gitea webhook and put Gogs webhook apart.
2017-05-29 02:17:15 -05:00
Ethan Koenig
c85ff532e9
Commitless repos should be bare
2017-05-28 22:31:40 -04:00
Ethan Koenig
bafd778c25
Fix invalid reference in feeds template ( #1820 )
...
* Fix invalid reference in feeds template
* Comment for GetActAvatar
* Add integration test
2017-05-27 11:34:11 +08:00
Ethan Koenig
7e6ff69c00
Fix 500 for GET /teams/:id endpoints ( #1811 )
...
* Fix 500 for GET /teams/:id endpoints
* Integration test for GET /team/:id
* Clean up integration test
2017-05-26 08:15:45 -05:00
Ethan Koenig
39348cd27e
Give all units to owner team ( #1812 )
2017-05-26 16:03:37 +08:00
Ethan Koenig
9c66d1d9ea
Fix deadlock in updateRepository ( #1813 )
2017-05-26 13:08:13 +08:00
Ethan Koenig
0c332f0480
Fix activity feed ( #1779 )
...
* Fix activity feed
Preserve actions after user/repo name change
* Add missing comment
* Fix migration, and remove fields completely
* Tests
2017-05-26 09:38:18 +08:00
Jonas Franz
03912ce014
Adding #issuecomment to the URL in E-Mail notifications ( #1674 )
...
* Added comment's hashtag to url for mail notifications.
Signed-off-by: Jonas <info@jonasfranz.software>
* Added comment's hashtag to url for mail notifications.
Added explanation to return statement.
Signed-off-by: Jonas <info@jonasfranz.software>
* Added comment's hashtag to url for mail notifications.
Added explanation to return statement + documentation.
Signed-off-by: Jonas <info@jonasfranz.software>
* Added comment's hashtag to url for mail notifications.
Signed-off-by: Jonas Franz <info@jonasfranz.software>
* Replacing in-line link generation with HTMLURL. (+gofmt)
Signed-off-by: Jonas Franz <info@jonasfranz.software>
* Replaced action-based model with nil-based model. (+gofmt)
Signed-off-by: Jonas Franz <info@jonasfranz.software>
* Replaced mailIssueActionToParticipants with mailIssueCommentToParticipants.
Signed-off-by: Jonas Franz <info@jonasfranz.software>
* Updating comment for mailIssueCommentToParticipants
Signed-off-by: Jonas Franz <info@jonasfranz.software>
2017-05-25 10:38:56 +08:00
Lunny Xiao
19d889daa2
fix bug not to trim space of login username ( #1796 )
2017-05-25 00:12:00 +08:00
Jonas Östanbäck
7b907ed348
Rename RepoCreationNum -> MaxCreationLimit ( #1766 )
2017-05-24 08:27:08 +08:00
Ethan Koenig
bdc90aeaee
Delete repo redirects on repo deletion ( #1776 )
2017-05-23 16:00:10 +08:00