Commit Graph

1761 Commits

Author SHA1 Message Date
Ethan Koenig a52cd59727 Fix unchecked error bug () 2017-07-04 09:30:41 +08:00
Lauris BH f189ccd2d6 Fix git hooks update to receive required arguments. Fixes ()
* Changed migration calling so that migrations can use models package
2017-07-02 21:50:57 +08:00
Ethan Koenig eae9154811 Fix SQL bug in models.PullRequests 2017-07-01 14:08:43 +03:00
Lauris BH 12cb6cd3c9 Merge pull request from Bwko/fix_error_exit
Fix exit status 1 not handled @ getMergeCommit ()
2017-06-30 15:46:49 +03:00
Bwko b36849dc1f
Fix exit status 1 not handled @ getMergeCommit 2017-06-30 12:35:26 +02:00
Andrey Nering 935b40fd8e Merge pull request from ethantkoenig/check_err/org_avatar
Don't ignore gravatar error
2017-06-29 21:30:05 -03:00
Ethan Koenig 05e3726415 Use default avatar on error 2017-06-29 12:10:33 -04:00
Lauris BH 783b1967e2 Fix release display and correct paging () 2017-06-29 23:11:38 +08:00
Lunny Xiao 33f3165296 remove unnecessary blank lines and wrong error log 2017-06-28 19:00:08 +02:00
iszla 3f9016430f Pagination on releases page ()
* Added count to GetReleasesByRepoID so pagination will work

* Separated it out to a new function, can then also leave the API part unaffected

* Remove extra whitespace added in untouched function

* Added comment and corrected name in error handler

* Account for if the user is owner or not in the count

* Also check if repo is draft

* revert back to the correct count in the ReleasesToDisplay loop

* Fixed lint error regarding else with return statement

* Use Cond struct instead of string, corrected name in error handler

* Removed unused return variable names
2017-06-28 22:47:00 +08:00
Lauris BH 32fc44aa83 Make time diff translatable () 2017-06-28 13:43:28 +08:00
Dan Magnus Lindvall 79daf31058 Setting to disable authorized_keys backup ()
* Add setting to disable authorized_keys backup when rewriting public keys

Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>

* Update default value to comply with documentation

Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>

* Use tmp-file instead of bak-file for saving manually added keys.

Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>

* Change casing

Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>

* Change casing and build bakpath with sprintf only

Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>

* Only close file once

Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>

* Do not modify calcFingerprint

Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>

* Fix casing

Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>

* Change style from disable to enable

Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>

* Change name, just SSH_BACKUP_AUTHORIZED_KEYS

Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>

* Do not check for directory existence if backup is disabled

Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>
2017-06-28 09:35:35 +08:00
Ethan Koenig 80707c4736 Fix default ghost assignee bug () 2017-06-28 09:27:12 +08:00
Jonas Franz 441986a473 Fix "Dashboard shows deleted comments" () 2017-06-25 20:20:29 +02:00
Ethan Koenig 2559a34b97 Load label ID in NewLabels () 2017-06-25 14:15:09 +08:00
Győrvári Gábor f2afed3098 Enable assignee e-mail notification ()
* Enable assignee e-mail notification

* Check assignee and doer to avoid self made comment notifications.

* Assignee not always defined

* New method to avoid error when assignee deleted

* Assignee empty check
2017-06-23 21:43:37 +08:00
Ethan Koenig 902a749fd9 Fix fast-forward PR bug () 2017-06-22 09:06:57 +08:00
Lunny Xiao d71fad2ab7 Fix and fix issue comments hidden ()
* revert  and fix issue comments hidden

* fix 

* fix import

* improve comment type

* reduce unnecessary join

* fix comment on FindCommentsOptions
2017-06-21 09:00:44 +08:00
Lauris BH 6db387a21e Refactor session close as xorm already does everything needed internally () 2017-06-21 08:57:05 +08:00
Lauris BH 165cf33771 Wrong PR merge commit ID saved () 2017-06-19 17:37:11 +08:00
Ethan Koenig 255adc40ae Don't show non-comments in comments API () 2017-06-18 17:06:17 +08:00
Lauris BH 1a906f800d Fix GPG email checking to be case insensitive () 2017-06-17 18:56:40 +08:00
Lunny Xiao e2ec4b7c23 fix bu ong normal user visit public repo () 2017-06-17 12:53:51 +08:00
Ethan Koenig 8fc64741d9 Fix deleted milestone bug ()
* Fix deleted milestone bug

* Use locale for ghost milestone name

* Fix pointer bug
2017-06-17 12:51:28 +08:00
Ethan Koenig ce9b86082c Consolidate boilerplate in integration tests () 2017-06-17 12:49:45 +08:00
Ethan Koenig 8fcda0442e Fix search by issue type ()
* Fix search by issue type
2017-06-15 05:09:03 +02:00
Kim "BKC" Carlbäcker bf48c8ebdd SQLite has a query timeout. Hopefully fixes most 'database locked' errors ()
* SQLite has a query timeout. Fixes 'database locked' errors
2017-06-15 04:51:17 +02:00
Lunny Xiao 31b5e9177f fix collborators lack of units on orgnization repositories ()
* fix collborators lack of units on orgnization repositories

* also change log level to debug
2017-06-15 04:50:12 +02:00
Ethan Koenig 57cabb3ad3 Fix diff of renamed and modified file () 2017-06-14 04:07:09 -05:00
Antoine GIRARD 274149dd14 Switch to keybase go-crypto (for some elliptic curve key) + test ()
* Switch to keybase go-crypto (for some elliptic curve key) + test

* Use assert.NoError 

and add a little more context to failing test description

* Use assert.(No)Error everywhere 🌈

and assert.Error in place of .Nil/.NotNil
2017-06-14 08:43:43 +08:00
Ethan Koenig 96152c38b1 Fix bug in Action.loadRepo() () 2017-06-14 08:37:50 +08:00
Ethan Koenig b38b61bbc1 Fix import order () 2017-06-12 10:01:09 -05:00
Andrey Nering 635273cea6 Merge pull request from ethantkoenig/no_branches
Commitless repos should be bare
2017-06-12 11:05:01 -03:00
Ethan Koenig 9fbdd7d787 Fix engine bug in getIssueByID () 2017-06-11 14:39:12 +08:00
Ethan Koenig e0a63a20e0 Fix errors caused by force push () 2017-06-10 21:59:13 -05:00
Dennis Keitzel 96b4780727 Gracefully handle bare repositories on API operations. ()
Signed-off-by: Dennis Keitzel <github@pinshot.net>
2017-06-10 21:57:28 -05:00
Ethan Koenig 73836ce8c4 Fix ghost user bug ()
Fix bug where unassigned issues would appear to be assigned to a ghost user
2017-06-09 09:51:31 +08:00
Dan Magnus Lindvall ff7424179e Delete Public SSH Key tmp file after calculating fingerprint ()
* Delete public key tmp file after calculating fingerprint

Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>

* Move line

Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>

* Remove defer statement

Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>

* Readd defer statement and move remove

Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>

* Delete space

Signed-off-by: Magnus Lindvall <magnus@dnmgns.com>
2017-06-08 10:08:22 +08:00
Sandro Santilli f6b58964d7 Include formatting check to the `make test` (and thus also `check`) rule ()
* Include formatting check to the `make check` rule

... and give it its own standalone target too (make fmt-check)

Show diff on fmt-check failure
Do not allow running "fmt-check" with incompatible go version
Also simplify the `fmt` rule

* Forbid running "make fmt" with Go version != 1.7 or 1.8

* Ignore bindata.go for spelling and formatting checks

also remove duplicated variable assignment for GOFILES

* Run `make fmt`
2017-06-06 08:53:16 -05:00
Phil Hopper 6ec07a6bd7 Make `LocalCopyPath` a setting instead of a hard-coded path () 2017-06-06 04:09:54 -05:00
Ethan Koenig ca9169fbe9 Migration to fix existing owner team units () 2017-06-05 05:40:25 -05:00
Bo-Yi Wu 703d18e50d feat: add check misspelling () 2017-06-05 02:49:46 -05:00
Andrey Nering ed31dff5ab Merge pull request from ethantkoenig/typo/issue_test
Fix misspelled variables
2017-06-04 17:10:40 -03:00
Ethan Koenig 9f9289fc68 Run unused test 2017-06-04 14:28:17 -04:00
Ethan Koenig 1a09afc729 Fix misspelled variables 2017-06-04 13:39:08 -04:00
Ethan Koenig 3e74b5cf51 Rename misnamed migration () 2017-06-04 11:09:50 +08:00
Ethan Koenig b900c04316 Display draft releases ()
* Display draft releases

* Include ctx.User in user cache

* Integration test
2017-06-03 11:46:56 +08:00
Ethan Koenig 036ce3f813 Fix bug in removeOrgRepo () 2017-06-02 20:06:09 -05:00
Ethan Koenig 4e5ee2b67a Fix user profile activity feed ()
* Fix user profile activity feed

* gofmt, and avoid overlapping database connections
2017-06-02 08:42:25 +08:00
Ethan Koenig a977ab7889 Don't ignore error in getMergeCommit () 2017-05-31 19:51:24 -05:00