Kuba Tyszko
5d6b71fdbb
fixes pull request hanging indefinitely when it contains normal and LFS file pointers ( #1425 )
2017-04-03 10:21:09 +08:00
Andrey Nering
37a34c1a28
Merge pull request #1410 from andreynering/notification/issue-watch
...
[Notifications Step 6] Per issue/PR watch/unwatch
2017-04-01 15:12:24 -03:00
Andrey Nering
f6e5ce65b2
Improve tests a little
2017-04-01 10:05:58 -03:00
Andrey Nering
e5c56fe30d
Code style fixes
2017-04-01 09:58:20 -03:00
agrn
88112a5324
Fix "Error: No issue number specified" when pushing ( #1393 )
...
* Fix "Error: No issue number specified" when pushing
* update pr
2017-03-31 18:05:39 -07:00
Mura Li
6a39250579
Add length check for the return string ( #1420 )
...
* Add length check for the return string
* Differentiate error paths and logging messages
* Rectify error message
2017-03-31 16:42:23 +08:00
Andrey Nering
e6781d5488
Add unit tests for issue_watch
2017-03-30 20:20:08 -03:00
Andrey Nering
a90ffffb1a
Use variables for times
2017-03-30 19:14:16 -03:00
Andrey Nering
18952c40f8
Add copyright headers
2017-03-30 19:11:58 -03:00
Andrey Nering
caed86fc6e
Fix lint
2017-03-29 21:18:28 -03:00
Andrey Nering
cb362513f0
Add updated_unix column on issue_watch
2017-03-29 20:59:28 -03:00
Andrey Nering
aa6e949b3d
Consider issue_watchers while sending notifications
2017-03-29 20:54:57 -03:00
Andrey Nering
b674460748
Add watch button on issue
2017-03-29 20:31:47 -03:00
Andrey Nering
a0d0de7233
Create issue_watch table
2017-03-29 19:55:40 -03:00
Bo-Yi Wu
08f7fded3c
refactor: remove workaround after the golang 1.7 release. ( #1349 )
...
* refactor: remove workaround after the golang 1.7 release.
* remove unused import.
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
* refactor: Add remove function.
* refactor: rename
* refactor: update build flag
2017-03-29 10:05:23 +08:00
Philippe Kueck
fe94032f74
rewrite pre-commit, post-commit and options hooks ( fixes #1250 ) ( #1257 )
...
* issue #1250 , replace {pre,post}-receive and update hooks with a single shell script that does not require custom hooks to be a sh-script
* issue #1250 , make script posix compilant
* v23, add migration script to update {pre,post}-receive and update hooks
* migration: use a more common name and rename v23 to v26 to avoid conflicts
* gofmt'ed and added copyright header
* fix SyncRepositoryHooks to also sync wiki repos
2017-03-23 09:12:51 +08:00
Lunny Xiao
d330a23ce1
fix migration failed when authorized_keys is not exist ( #1180 )
2017-03-23 00:04:31 +08:00
Kim "BKC" Carlbäcker
d349f059af
Cleaner IMO ( #1361 )
2017-03-22 22:30:40 +08:00
Antoine GIRARD
14fe9010ae
GPG commit validation ( #1150 )
...
* GPG commit validation
* Add translation
+ some little fix
* Move hash calc after retrieving of potential key + missing translation
* Add some little test
2017-03-22 18:43:54 +08:00
Sandro Santilli
f73e734411
Run "make fmt" with go-1.6 ( #1333 )
2017-03-21 08:55:00 +08:00
Lunny Xiao
888dee3b5f
fix delete user failed on sqlite ( #1321 )
2017-03-20 22:13:52 +08:00
Lunny Xiao
bd8fe49076
fix wiki bugs ( #1294 )
2017-03-20 21:36:19 +08:00
Sandro Santilli
9182a35f18
Show user OpenID URIs in their profile ( #1314 )
2017-03-20 09:31:08 +01:00
Lunny Xiao
608cd54a68
fix gpg wrong column types
2017-03-20 02:55:07 +01:00
Bo-Yi Wu
1c3bd436cc
feat: Only use issue and wiki on repo. ( #1297 )
2017-03-18 18:59:07 +08:00
Sandro Santilli
71d16f69ff
Login via OpenID-2.0 ( #618 )
2017-03-17 15:16:08 +01:00
Lunny Xiao
3cf0e513e6
fix wrong log when push to a new branch ( #1220 )
2017-03-17 10:15:00 +08:00
Sandro Santilli
447c9b428f
Send notifications to partecipants in issue comments ( #1217 )
...
* Send notifications to partecipants in issue comments
Closes #1216
Includes test (still failing)
* Do not include "labelers" to participants
Fix test to expect what GetParticipants return
2017-03-16 09:34:24 +08:00
Antoine GIRARD
ca1c3f1926
Implement GPG api ( #710 )
...
* Implement GPG API
* Better handle error
* Apply review recommendation + simplify database operations
* Remove useless comments
2017-03-16 09:27:35 +08:00
Ethan Koenig
09fe4a2ae9
Batch updates for issues ( #926 )
2017-03-15 02:10:35 +01:00
Ethan Koenig
021904e4e6
Fix typos in models/ and modules/ ( #1248 )
2017-03-15 08:52:01 +08:00
Ethan Koenig
ec0ae5d50c
Refactor and fix incorrect comment ( #1247 )
2017-03-15 08:51:46 +08:00
Sandro Santilli
8746fb3385
Fix migration comment ( #1241 )
2017-03-14 14:39:02 +08:00
Lunny Xiao
1ccdf19fae
fix forget migration for wiki hooks ( #1227 )
2017-03-13 14:27:29 +08:00
Sandro Santilli
0475e7351f
Reserve the "explore" user/org name ( #1222 )
2017-03-12 09:39:38 +08:00
Ethan Koenig
c99e7e1a62
Simplify RepositoryList.loadAttributes() ( #1211 )
2017-03-11 16:50:12 +08:00
Ethan Koenig
3803f257fb
Move user_follow to separate file ( #1210 )
...
Also add unit tests
2017-03-11 16:46:53 +08:00
Ethan Koenig
1e3548b7e7
Unit tests for issue_list ( #1209 )
2017-03-11 16:46:23 +08:00
Philippe Kueck
e2b2fd6e78
fix #1189 , commit messages containing a pipe ( #1203 )
2017-03-11 12:01:38 +08:00
Lunny Xiao
74cde12677
Fix upgrade failed after ever rollback ( #1194 )
...
* fix upgrade failed after rollback
* fix upgrade failed after rollback
* fix possible upgrade twice fail after rollback
2017-03-10 23:43:51 +08:00
Lunny Xiao
f5476bdbb1
bug fixed for delete repo failed ( #1193 )
2017-03-10 22:05:53 +08:00
Lunny Xiao
5d40db629c
fix random avatars ( #1147 )
2017-03-08 23:05:15 +08:00
Lunny Xiao
2215840363
fix avatar bug #1114 ( #1122 )
...
This PR fix the avatar bug described in #1114 . This will fix random avatar is blank problem and potential delete avatars dir problem.
2017-03-06 16:15:40 +08:00
Lunny Xiao
0376029241
fix del org avatar potential delete all avtars ( #1120 )
2017-03-06 16:07:18 +08:00
Lunny Xiao
7b64b2ddab
fix install submit crash caused by xorm log ( #1119 )
2017-03-06 10:11:43 +08:00
Bo-Yi Wu
d76d67de23
feat: expose url field on issue api. ( #982 )
...
* Add api url func.
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
* fix: Add unit testing.
* fix: conflicts
* fix: remove trim
* fix: revert test function name.
2017-03-03 22:35:42 +08:00
Lunny Xiao
ef13bbaf7d
Don't rewrite non-gitea public keys ( #906 )
...
* don't rewrite non-gitea public keys
* add comment for public key
2017-03-03 00:36:47 +08:00
Lunny Xiao
9cb08a3cf5
fix wrong num of user repos because of duplicated click delete button & performance optimization ( #1092 )
2017-03-01 12:05:45 +08:00
Ethan Koenig
d21d5fd736
Remove unnecessary loads in org_team ( #1090 )
2017-03-01 09:09:49 +08:00
Ethan Koenig
22f7aa6e9c
LableIDs -> LabelIDs ( #1088 )
2017-03-01 09:08:45 +08:00
Bo-Yi Wu
e83c8afc56
refactor: move SearchRepositoryByName testing. ( #1083 )
2017-02-28 17:58:50 +08:00
Lunny Xiao
c2eef171ff
fix some typos ( #1082 )
2017-02-28 12:56:15 +08:00
Ethan Koenig
4b286f282a
Consistency checks for action unit tests ( #1079 )
2017-02-28 09:42:10 +08:00
Ethan Koenig
cf80e19157
Optimize and unit test Issue_ReplaceLabels ( #1080 )
2017-02-28 09:35:55 +08:00
Ethan Koenig
136e6beb0f
Fix unused Engine bugs ( #1064 )
2017-02-27 10:16:35 +08:00
Lunny Xiao
e4134debd1
Remove unused vars ( #1063 )
...
* remove unused vars
* remove unused comment
2017-02-27 09:22:15 +08:00
Lunny Xiao
32faec00e6
move all repo list functions as a standalone file ( #1061 )
2017-02-27 08:45:03 +08:00
Lunny Xiao
d4e38cf129
fix setMerged for remove unnecessary db connection ( #1067 )
2017-02-27 08:42:55 +08:00
Lunny Xiao
522f194983
Bug fixed for org avatar caused by #1049 ( #1070 )
...
* bug fixed for org avatar caused by #1049
* use isfile only
2017-02-27 08:42:22 +08:00
Bo-Yi Wu
95574a3640
fix: Admin can see all private repositories on Explore page. ( #1026 )
...
* fix: Admin can see all private repositories on Explore page.
* refactor: fix session
2017-02-26 13:59:31 +08:00
Sandro Santilli
bf24099114
Allow migrating installations with no local avatars ( #1056 )
2017-02-26 11:58:02 +08:00
Lunny Xiao
80f900ebae
Fix avatar enumable ( #1049 )
...
* fix avatar enumable
* fix import style
2017-02-25 22:58:57 +08:00
Lunny Xiao
19b3c45ca7
fix 500 when use a duplicat email instead of giving an error tip ( #1040 )
2017-02-25 22:57:06 +08:00
Lunny Xiao
cd1821a7e2
Move push update to post-receive and protected branch check to pre-receive ( #1030 )
...
* move all push update to git hook post-receive and protected branch check to git hook pre-receive
* add SSH_ORIGINAL_COMMAND check back
* remove all unused codes
* fix the import
2017-02-25 22:54:40 +08:00
Lunny Xiao
e8e56da9ac
fix #13 ( #1042 )
2017-02-25 22:53:57 +08:00
Andrey Nering
ddb0287bf6
Merge pull request #970 from andreynering/api-repo-mirror
...
Add "mirror" field to repo API
2017-02-25 11:35:03 -03:00
Lunny Xiao
fc4f7e82f9
refactor for searching user ( #1038 )
...
* refactor for searching user
* fix like bug
* better format for builder cond
2017-02-25 21:42:20 +08:00
Andrey Nering
946f3078d3
Add "mirror" field to repo API
2017-02-25 10:04:22 -03:00
Bo-Yi Wu
f1412142e0
refactor: repo counts for SearchRepositoryByName func ( #1045 )
2017-02-25 09:27:39 +08:00
Lunny Xiao
c0ea3963be
fix delete repo will hang on postgres ( #1044 )
2017-02-24 23:19:13 +08:00
Andrew Boyarshin
0602a44b27
Fix URL handling in the whole markdown module, improve test coverage ( #1027 )
...
Amended with string to bool change in API SDK.
Signed-off-by: Andrew Boyarshin <andrew.boyarshin@gmail.com>
2017-02-24 22:59:56 +08:00
Ethan Koenig
76057105ca
Remove unnecessary loads in org_team ( #1035 )
2017-02-24 14:25:09 +08:00
Ethan Koenig
f1ab906c51
Unit tests for models/repo_collaboration ( #1032 )
2017-02-24 09:37:38 +08:00
bit
490d3771f7
s/fields/terms ( #1031 )
...
use terms instead of fields as variable name to avoid confusion: NewPhraseQuery(terms []string, field string)
2017-02-24 09:24:58 +08:00
Lunny Xiao
d077fd084a
added missing new struct sync ( #1021 )
2017-02-23 15:05:37 +08:00
Lunny Xiao
0e6b9ea786
Take back control of hooks ( #1006 )
...
* git: delegate all server-side Git hooks (#1623 )
* create hooks directories
* take control hooks back
* fix lint
* bug fixed and minor changes
* fix imports style
* fix migration scripts
2017-02-23 11:40:44 +08:00
Ethan Koenig
4f3880ff15
Bug fixes and unit tests for org_team ( #1016 )
2017-02-23 09:36:15 +08:00
Ethan Koenig
ec3a696e2d
Fix lint errors
2017-02-22 17:10:45 -05:00
Lunny Xiao
1f7837d6d6
Refactor for issues loadattributes of a repository ( #971 )
...
* refactor for issues loadattributes of a repository
* refactors
2017-02-22 22:03:59 +08:00
Bo-Yi Wu
83b6d03231
fix: Wrong repo list on Explore page if user already loggin. ( #1009 )
...
* fix: Wrong repo list on Explore page if user already loggin.
* fix: code readable.
* fix: declare variable
2017-02-22 21:15:14 +08:00
Willem van Dreumel
01d957677f
Oauth2 consumer ( #679 )
...
* initial stuff for oauth2 login, fails on:
* login button on the signIn page to start the OAuth2 flow and a callback for each provider
Only GitHub is implemented for now
* show login button only when the OAuth2 consumer is configured (and activated)
* create macaron group for oauth2 urls
* prevent net/http in modules (other then oauth2)
* use a new data sessions oauth2 folder for storing the oauth2 session data
* add missing 2FA when this is enabled on the user
* add password option for OAuth2 user , for use with git over http and login to the GUI
* add tip for registering a GitHub OAuth application
* at startup of Gitea register all configured providers and also on adding/deleting of new providers
* custom handling of errors in oauth2 request init + show better tip
* add ExternalLoginUser model and migration script to add it to database
* link a external account to an existing account (still need to handle wrong login and signup) and remove if user is removed
* remove the linked external account from the user his settings
* if user is unknown we allow him to register a new account or link it to some existing account
* sign up with button on signin page (als change OAuth2Provider structure so we can store basic stuff about providers)
* from gorilla/sessions docs:
"Important Note: If you aren't using gorilla/mux, you need to wrap your handlers with context.ClearHandler as or else you will leak memory!"
(we're using gorilla/sessions for storing oauth2 sessions)
* use updated goth lib that now supports getting the OAuth2 user if the AccessToken is still valid instead of re-authenticating (prevent flooding the OAuth2 provider)
2017-02-22 08:14:37 +01:00
Denis Denisov
fd941db246
Protected branches system ( #339 )
...
* Protected branches system
* Moved default branch to branches section (`:org/:reponame/settings/branches`).
* Initial support Protected Branch.
- Admin does not restrict
- Owner not to limit
- To write permission restrictions
* reformat tmpl
* finished the UI and add/delete protected branch response
* remove unused comment
* indent all the template files and remove ru translations since we use crowdin
* fix the push bug
2017-02-21 23:02:10 +08:00
Willem van Dreumel
5f234ce2a5
add missing copyright header ( #992 )
2017-02-21 08:46:14 +08:00
Lunny Xiao
04fdeb9d8d
Make Xorm log configurable ( #174 )
...
* make xorm log configable
* bug fixed for other sub commands except web
* rebase and fix xorm log
* bug fix for TrimSpace
2017-02-20 16:11:13 +08:00
Ethan Koenig
be48b32e63
Unit tests for repo watching ( #963 )
2017-02-17 16:02:11 +08:00
Lunny Xiao
847527fd6d
Fix all the bugs in issues and pulls on dashboard ( #943 )
...
* fix all the bugs in issues and pulls on dashboard
* small fix and refactor
* add method getRepoIDs for IssueList
2017-02-17 08:58:19 +08:00
Ethan Koenig
140967f002
Unit tests for repo redirects ( #961 )
2017-02-17 08:55:33 +08:00
Lunny Xiao
7fd14bf7bd
optimization for team get repos ( #953 )
2017-02-16 12:07:58 +08:00
Lunny Xiao
46320f9630
refactor notificationsForUser since xorm In support slice of customerize type ( #956 )
2017-02-16 12:07:00 +08:00
Lunny Xiao
0642cb330c
Small opitimization for getUserTeams ( #954 )
...
* Small opitimization for getUserTeams
* more compact
2017-02-16 12:06:23 +08:00
Bo-Yi Wu
43c94d0a6c
test: Add testing for GetUserFork function ( #944 )
2017-02-15 23:24:23 +08:00
Bo-Yi Wu
a31f64d639
fix: 500 error on /explore/repos page. ( #946 )
2017-02-15 22:28:11 +08:00
Bo-Yi Wu
9d2b830275
refactor: small optimize for sql query ( #940 )
...
* refactor: small optimize for sql query
* fix: get owner name if Searcher is not nil or user star page.
2017-02-15 14:01:50 +08:00
Lunny Xiao
837d346090
fix some older Gogs upgrade to Gitea ( #929 )
2017-02-15 09:32:03 +08:00
Lunny Xiao
9c645b54dc
bug fixed on issues and pulls
2017-02-15 01:17:07 +01:00
Lunny Xiao
4cfde304df
bug fixed for my repository ( #933 )
2017-02-14 23:37:44 +08:00
Lunny Xiao
7a9a5c8a69
Fix assigned issues dashboard ( #920 )
...
* Fix assigned/created issues in dashboard. (#3560 )
* Fix assigned/created issues in dashboard.
* Use GetUserIssueStats for getting all Dashboard stats.
* Use gofmt to format the file properly.
* Replace &Issue{} with new(Issue).
* Check if user has access to given repository.
* Remove unnecessary filtering of issues.
* Return 404 error if invalid repository is given.
* Use correct number of issues in paginater.
* fix issues on dashboard
2017-02-14 22:15:18 +08:00
Lunny Xiao
3a91ac51a9
fix bug of multiple forks ( #928 )
2017-02-14 22:14:29 +08:00
Bo-Yi Wu
d67b278a0d
feat: Able to disable non-admin to create new organization ( #927 )
2017-02-14 20:16:00 +08:00
Bo-Yi Wu
23aba523b5
feat: support search bar on star tab of user profile. ( #917 )
...
* feat: support search bar on star tab of user profile.
* fix: update testing.
* fix: Using loadAttributes
* fix: remove empty line.
* remove LOWER
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
2017-02-14 15:28:22 +08:00
Lunny Xiao
7eb8daffa3
Use fingerprint to check instead content for public key ( #911 )
...
* use fingerprint to check instead content for public key
* add fingerprint field for ErrKeyAlreadyExist
2017-02-14 14:12:52 +08:00
Lunny Xiao
55ae78208e
Small optimization for getTeamIDs ( #919 )
...
* small optimization for getTeamIDs
* rename getOrgTeamIDs to getUserTeamIDs and remove orderby
2017-02-14 11:46:46 +08:00
Bo-Yi Wu
1ec6b1a258
fix: gofmt error. ( #918 )
2017-02-14 10:12:03 +08:00
Bo-Yi Wu
5cc275b1de
feat: add git version on admin panel. ( #921 )
2017-02-13 19:49:42 +08:00
Ethan Koenig
076f940f1f
Fix logging bug
...
Error logged everytime an assignee was removed
2017-02-12 08:54:15 +01:00
Lunny Xiao
d76f34ef51
small optimization for get issue labels
2017-02-12 06:46:51 +01:00
Andrew
3f67676059
Implement basic Open Graph support. ( #901 )
2017-02-11 20:57:33 +08:00
Lunny Xiao
8a0be5e9f0
Bug fixed for deleted label in issue comment ( #904 )
...
* bug fixed for deleted label in issue comment
* fix indent
2017-02-11 20:56:57 +08:00
Morgan Bazalgette
442145dbd3
Fix public activity showing private repos ( #892 )
...
* Fix public activity showing private repos (#811 )
Signed-off-by: Morgan Bazalgette <the@howl.moe>
* error check after setting is_private to true
* Add test for UpdateRepository w/ visibility change
2017-02-11 18:57:57 +08:00
Andrew
42835c7f82
Implement archive cleanup ( #885 )
...
* Implement archive cleanup
Fixes #769
Signed-off-by: Andrew <write@imaginarycode.com>
* Make sure to close the directory file
* Resolve issues noted by @strk
* edit cheatsheet app.ini [ci skip]
* oops [ci skip]
2017-02-11 12:00:46 +08:00
Lunny Xiao
cf0f451c37
Add delete branch track on pull request comments ( #888 )
...
* add delete branch track on pull request comments
* don't change vendor
2017-02-11 12:00:29 +08:00
Lunny Xiao
b6dd6210ea
bug fixed for issue count ( #881 )
2017-02-09 17:59:57 +08:00
Ethan Koenig
a6751cec04
Unit tests for issue_milestone ( #878 )
2017-02-09 14:39:26 +08:00
Ethan Koenig
13973348df
Gogs -> Gitea ( #877 )
2017-02-09 13:44:18 +08:00
Ethan Koenig
e6b4448ba3
Fix bug in Issue.GetIsRead ( #876 )
2017-02-09 11:47:24 +08:00
Ethan Koenig
181c8d9c99
Fix consistency check ( #866 )
2017-02-08 14:29:21 +08:00
Ethan Koenig
d2329e1c26
Use assert in legacy unit tests ( #867 )
2017-02-08 14:29:07 +08:00
Ethan Koenig
5fbab97373
Fix broken test fixture ( #859 )
2017-02-07 22:49:37 +08:00
Bo-Yi Wu
b13232f524
feat: support paginater on star tab of user profile. ( #845 )
2017-02-07 19:54:16 +08:00
Ethan Koenig
ceae143e78
Consistency checks for unit tests ( #853 )
2017-02-07 19:47:55 +08:00
Bo-Yi Wu
71d35dae8c
fix: wrong pages number which includes private repository count. ( #844 )
2017-02-06 23:18:36 +08:00
Ethan Koenig
438e1a7d46
Fix inconsistencies in unit test fixtures
2017-02-05 22:43:31 -05:00
Lunny Xiao
f35b20b042
track issue title changes ( #841 )
2017-02-05 22:36:00 +08:00
Ethan Koenig
027591a3a5
Redirects for renamed repos ( #807 )
...
* Redirects for renamed repos
* Remove unused phrase from locales
2017-02-05 22:35:03 +08:00
Bwko
bf647ce143
Check for manual merging of a pull request ( #719 )
...
When an open pull request got manually merged mark the pull request as
merged
2017-02-05 21:07:44 +08:00
Andrey Nering
7c3dc51655
Merge pull request #839 from ethantkoenig/fix/remove_org_repo
...
Fix bug in removeOrgRepo
2017-02-04 14:55:02 -02:00
Ethan Koenig
f82ea42679
Fix bug in removeOrgRepo
2017-02-04 11:01:21 -05:00
Ethan Koenig
5972aa9af3
Fix inconsistencies in test fixtures
2017-02-04 11:01:06 -05:00
Lunny Xiao
8a421b1fd7
Add units concept for modulable functions of a repository ( #742 )
...
* Add units concept for modulable functions of a repository
* remove unused comment codes & fix lints and tests
* remove unused comment codes
* use struct config instead of map
* fix lint
* rm wrong files
* fix tests
2017-02-04 23:53:46 +08:00
Ethan Koenig
d0960b8035
Move IssueUser code to separate file ( #836 )
...
Also add unit tests
2017-02-04 20:37:26 +08:00
Andrey Nering
d4035d1cb1
Merge pull request #830 from appleboy/patch-2001
...
refactor: set default order by recently star on start tab
2017-02-04 10:32:55 -02:00
Bo-Yi Wu
a90a215662
feat: Add search bar on user profile page. ( #787 )
2017-02-04 20:20:20 +08:00
Bo-Yi Wu
b6da658553
test: Add user mail testing. ( #833 )
2017-02-04 09:20:56 +08:00
Lunny Xiao
3e0525b47d
Track assignee for issue ( #808 )
...
* track assignee for issue
* fix lint
* use getUserByID instead Get
2017-02-03 23:09:10 +08:00
Ethan Koenig
68bdaf0a6b
Drop redundant columns from issue_user table ( #638 )
2017-02-03 15:22:39 +08:00
Bo-Yi Wu
e2de16065a
refactor: set default order by recently star.
2017-02-03 12:03:49 +08:00
Gabriel Jackson
bf6f61cc69
Cleanup log messaging
...
This change corrects a few logging issues:
* Standardized formatting errors with '%v'.
* Standardized failure warning word usage.
* Corrected an instance of using the standard log library when
the gitea log library should be used instead.
2017-02-02 15:24:18 +01:00
Bo-Yi Wu
d7d094bd8a
fix: ignore email notifications if user is not active. ( #820 )
2017-02-02 20:33:36 +08:00
Anton Skorokhod
79ab69fe30
Add X-GitHub-* headers for webhook to get clubhouse.io integration working ( #809 )
2017-02-02 11:51:19 +08:00
Lunny Xiao
081485ecfd
add milestone changed traker on issue view ( #804 )
2017-02-01 10:36:08 +08:00
Ethan Koenig
10644d6dd7
Bug fixes and unit tests for models/issue_label ( #802 )
2017-02-01 09:31:35 +08:00
Ethan Koenig
0a02fb3c4f
Windows compatibility for unit tests ( #800 )
2017-01-30 22:22:04 +08:00
Ethan Koenig
2eb15f4a61
Unit tests and remove unused functions in models/notification ( #796 )
...
* Unit tests and remove unused functions in models/notification
* Read -> Unread
2017-01-30 22:21:49 +08:00
Lunny Xiao
f94869d2d1
Track labels changed on issue view & resolved #542 ( #788 )
...
* track labels changed on issue view & resolved #542
* add missing head comment & sort & fix refresh
2017-01-30 20:46:45 +08:00
Ethan Koenig
7765593018
Better settings for unit tests ( #795 )
2017-01-30 13:17:43 +08:00
Thomas Boerger
78535fb08e
Allow custom public files ( #782 )
...
* Allow custom public files
* Gofmt code, lots of places not related to this pr
2017-01-28 23:14:56 +01:00
Andrey Nering
cc31a21192
Merge pull request #781 from andreynering/notifications-step-5
...
Notifications step 5
2017-01-28 17:54:37 -02:00
Andrey Nering
5348e8b71a
Fix color: closed PR was showing as purple instead of red
2017-01-28 14:01:07 -02:00
Andrey Nering
31c717f579
Merge pull request #777 from ethantkoenig/tests/wiki
...
Unit tests for models/wiki
2017-01-28 11:27:45 -02:00
Ethan Koenig
bb76285762
Unit tests for models/wiki
2017-01-27 13:08:17 -05:00
Ethan Koenig
a2412492da
Unit tests and bug fix for models/org
2017-01-27 12:24:06 -05:00
Lunny Xiao
bb5a6b7a07
fix xorm NewSession uncorrected usages ( #774 )
2017-01-28 00:11:41 +08:00
Bo-Yi Wu
25663b5816
refactor: Remove unnecessary type conversions ( #772 )
2017-01-27 23:03:32 +08:00
Ethan Koenig
da1b6164fe
Fix FIXME and remove superfluous queries in models/org ( #749 )
2017-01-25 23:41:38 +08:00
Bo-Yi Wu
691fbdf1d3
fix: delete attachment after remove comment.
2017-01-25 16:40:43 +01:00
Ethan Koenig
0934d1b1ea
Bug fixes and unit tests for models/webhook ( #751 )
2017-01-25 18:37:35 +08:00
Ethan Koenig
a6832c234d
Unit tests for models/star ( #752 )
2017-01-25 18:37:10 +08:00
Lunny Xiao
8c2381103a
bug fixed issues 500 resolved #754 ( #756 )
2017-01-25 16:28:03 +08:00
Ethan Koenig
8093b3372e
Less boilerplate in models/ unit tests ( #725 )
2017-01-25 10:49:51 +08:00
Ethan Koenig
833f8b94c2
Search bar for issues/pulls ( #530 )
2017-01-25 10:43:02 +08:00
Andrey Nering
521d429b58
Fix link of some repos on stars page ( #737 )
...
Link was wrong the repo was of another owner
2017-01-24 10:39:58 +08:00
Bwko
74ed6dc3ad
Add option to app.ini to enable local import paths ( #724 )
2017-01-23 09:19:50 +08:00
Bwko
1257d43e14
Add a reserved path check to the wiki ( #720 )
2017-01-22 23:08:54 +08:00
Lunny Xiao
f8c2903484
fixed bugs on Wiki and resolved #667 ( #674 )
2017-01-21 20:50:51 +08:00
Philip Couling
1610b9f547
Spun attachments into seperate go file ( #701 )
...
Moved attachments into seperate go file
2017-01-20 07:58:46 +01:00
Ethan Koenig
74bbec3bf9
Fix permission bugs in team API ( #647 )
2017-01-20 13:16:10 +08:00
Ethan Koenig
fcf02e4961
API Endpoints for organization members ( #645 )
2017-01-20 10:31:46 +08:00
Matthias Loibl
d1006150fb
Refactor process package and introduce ProcessManager{} with tests ( #75 )
...
* Add a process.Manager singleton with process.GetManager()
* Use process.GetManager everywhere
* Fix godoc comments for process module
* Increment process counter id after locking the mutex
2017-01-17 13:58:58 +08:00
Andrew
6dd096b7f0
Two factor authentication support ( #630 )
...
* Initial commit for 2FA support
Signed-off-by: Andrew <write@imaginarycode.com>
* Add vendored files
* Add missing depends
* A few clean ups
* Added improvements, proper encryption
* Better encryption key
* Simplify "key" generation
* Make 2FA enrollment page more robust
* Fix typo
* Rename twofa/2FA to TwoFactor
* UNIQUE INDEX -> UNIQUE
2017-01-16 10:14:29 +08:00
Philip Couling
64375d875b
Attach to release ( #673 )
...
* Moved attachaments POST url from /issues/attachments to /attachments
* Implemented attachment upload on release page
* Implemented downloading attachments on the release page
* Added zip and gzip files to default allowed attachments
* Implemented uploading attachments on edit release
* Renamed UploadIssueAttachment to UploadAttachment
2017-01-15 22:57:00 +08:00
btrepp
302fa42980
Removes reliance on server specific SQL ( #393 )
...
Breaks the retrieval of repositories into two queries
This fetches the paged ids in one go, then the
actual repository information in a second query
Some databases do not support SELECT with *
when group by is used.
2017-01-14 22:32:36 +08:00
Ethan Koenig
a6f5efa0bb
Fix ambiguity bug in getCommentsByRepoIDSince ( #665 )
2017-01-14 10:21:30 +08:00
Ethan Koenig
27fcf8d30a
Bug fixes for webhook API ( #650 )
2017-01-14 10:14:48 +08:00
Lunny Xiao
87ad4961f6
bug fixed for update repository ( #664 )
2017-01-14 10:07:04 +08:00
Andrey Nering
769e0a3ea6
Notifications: mark as read/unread and pin ( #629 )
...
* Use relative URLs
* Notifications - Mark as read/unread
* Feature of pinning a notification
* On view issue, do not mark as read a pinned notification
2017-01-12 12:27:09 +08:00
Bo-Yi Wu
cbf2a967c5
refactor: Add new deleteOrg func. ( #633 )
2017-01-11 21:10:43 +08:00
Ethan Koenig
b316b2e740
Unit tests for models/admin
2017-01-09 21:49:51 +01:00
Ethan Koenig
973282dae2
Better coverage in pull_test ( #615 )
2017-01-09 11:15:07 +08:00
Ethan Koenig
862948ab88
Better coverage and TODOs for update_test ( #616 )
2017-01-09 11:14:57 +08:00
Ethan Koenig
4b23e6a694
Unit tests for models/action ( #619 )
2017-01-09 11:08:36 +08:00
derSuessmann
51d578ff33
Add Keep email private (see issue #571 ). ( #571 )
...
- Add site-wide option DEFAULT_KEEP_EMAIL_PRIVATE.
- Add the new option to the install and admin/config pages.
- Add the new option to app.ini in the service section.
- Add the new option to the settings struct.
- Add English text strings to i18n.
- Add field KeepEmailPrivate to user struct.
- Add field KeepEmailPrivate to user form.
- Add option to UI.
- Add using noreply email address if user has "Keep Email Private".
An email address <LowerName>@<NO_REPLY_ADDRESS> is now used in commit
messages (and hopefully all other git log relevant places). The
change relies on the fact that git commands should use
user.NetGitSig().
- Add hiding of email address in UI, if user has set "Keep Email Private".
- Add condition to show email address only on explore/users and user
pages, if user has not set "Keep Email Private".
- Add noreply email in API if set "Keep Email Private".
- Add a new service setting NO_REPLY_ADDRESS. The value of this
setting is used as the domain part for the user's email address in
git log, iff he decides to keep his email address private.
If the user decides to keep his email address private and this
option is not set 'noreply.example.org' is used, which no MTA
should send email to.
Add NO_REPLY_ADDRESS to conf/app.ini.
2017-01-08 11:12:03 +08:00
Ethan Koenig
6072b03291
Unit tests for models/access.go ( #606 )
2017-01-08 11:10:53 +08:00
Ethan Koenig
8422ab542c
API endpoint for subscribers ( #598 )
2017-01-07 11:13:02 +08:00
Andrey Nering
03b45284e1
Merge pull request #555 from ethantkoenig/tests/pull
...
Unit tests for models/pull.go
2017-01-06 19:19:18 -02:00
Andrey Nering
84b7d29d34
Create missing database indexes ( #596 )
2017-01-06 23:14:33 +08:00
Ethan Koenig
72bfabfada
Unit tests for models/pull.go
2017-01-06 10:08:23 -05:00
Ethan Koenig
1a7fc53c98
API endpoint for stargazers ( #597 )
2017-01-06 15:05:09 +08:00
Lunny Xiao
61306fa737
Make releases faster than before and resolved #490 ( #588 )
...
* make releases faster than before and resolved #490
* fix comment
2017-01-06 09:51:15 +08:00
Andrey Nering
79d527195d
Merge pull request #539 from andreynering/notifications-step-2
...
Notifications - Step 2
2017-01-05 11:53:01 -02:00
Ethan Koenig
c5f0d4b1a0
Fix SQL bug in models/access ( #583 )
...
Previously got a 'relation repo_access does not exist' error in User_GetRepositoryAccesses
2017-01-05 08:57:54 +08:00
Berk Demirkır
bdad3b259a
Check primary email address fields on CreateUser ( #556 )
...
* Check primary email address fields on CreateUser
As this check wasn't available, uid=1 (and possibly guests too, if registration is open) is able to register new users with existing email addresses. This leads to numerous 500 errors.
* Update user.go
* Lower the email first. Then check
2017-01-05 08:52:20 +08:00
Ethan Koenig
1207bda94b
Fix typos in models/ ( #576 )
2017-01-05 08:50:34 +08:00
Andrey Nering
b354cf362e
Add pagination for notifications
2017-01-03 17:09:36 -02:00
Lunny Xiao
09dabe2ff2
fix bug #564 ( #567 )
2017-01-03 16:27:11 +08:00
Lunny Xiao
980dd0bf51
Update xorm and dependencies vendor for feature to dump to other database ( #565 )
...
* update xorm and dependencies vendor for feature to dump to other database
* fix golint
2017-01-03 16:20:28 +08:00
Kjell Kvinge
4b0974ec10
Fix benchmarktests ( #557 )
2017-01-03 10:52:09 +08:00
Lunny Xiao
3c7116382f
change the default action when deleting a release to not delete tag
2017-01-03 02:27:38 +01:00
Ethan Koenig
0c301f7b5c
Release API endpoints
2017-01-02 00:10:52 +01:00
Lunny Xiao
6e5fffbd3f
resolved #485 : when migrate empty wiki repo, then ignore ( #541 )
2016-12-31 17:34:34 +08:00
Ethan Koenig
de8b73dd92
Unit tests for token and update models
2016-12-31 10:17:45 +01:00
Schwobaland
c0904f1942
Restrict creating organisations by user ( #193 )
...
* restrict creating organizations based on right on user
* revert bindata.go
* reverse vendor lib
* revert goimports change
* set AllowCreateOrganization default value to true
* revert locale
* added default value for AllowCreateOrganization
* fix typo in migration-comment
* fix comment
* add coments in migration
2016-12-31 10:33:30 +08:00
Bo-Yi Wu
6510e57758
fix gofmt error
...
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
2016-12-30 20:41:10 +01:00
Andrey Nering
42904cb98a
Notification - Step 1 ( #523 )
...
* Notification - Step 1
* Add copyright headers
* Cache issue and repository on notification model
2016-12-31 00:44:54 +08:00
typeless
937b4b5aa1
Speed up conflict checking in pull request creation ( #276 )
...
* Speed up conflict checking in pull request creation
In order to check conflicts of a PR, we set up a working tree by
cloning the base branch, which is quite time-consuming when the repository is huge.
Instead, this PR uses `git read-tree` and `git apply --check --cached` to check conflicts.
For #258
* Use $GIT_INDEX_FILE instead of --index-output to avoid lockfile problem
The lockfile gets renamed to the final destination after the operation
finishes. But it must be located in the same filesystem, which prevents
us from using /tmp.
* Temporary file names should not prefixed with '-'
2016-12-29 22:59:52 +08:00
Andrey Nering
b992858883
Tab on user profile to show starred repos ( #519 )
...
* Tab on user profile to show starred repos
* Make golint happy and use transactions on StarRepo function
* x -> sess
* Use sess.Close() instead of sess.Rollback()
* Add copyright
* Fix lint
2016-12-29 22:58:24 +08:00
Lunny Xiao
799d0c2030
slight optimization for GetUserRepositories ( #498 )
2016-12-29 02:53:33 -06:00
Kjell Kvinge
22e1bd31c6
commithgraph / timeline ( #428 )
...
* Add model and tests for graph
* Add route and router for graph
* Add assets for graph
* Add template for graph
2016-12-29 07:44:32 +08:00
Bwko
331316894e
Replace Gogs with Gitea ( #520 )
2016-12-28 16:33:21 +08:00
Lunny Xiao
c463b1b8cb
Optimization for user.GetRepositoryAccesses to reduce db query times ( #495 )
...
* optimization for user.GetRepositoryAccesses to reduce db query times
* fix missing cache
2016-12-28 09:34:35 +08:00
Lunny Xiao
ba134bd27a
fix 500 when delete orgnization and resolved #486
2016-12-27 12:00:12 +01:00
Ethan Koenig
2342df183b
API Endpoints for collaborators ( #375 )
2016-12-26 15:37:01 +08:00
Fabian Zaremba
2e7ccecfe6
Git LFS support v2 ( #122 )
...
* Import github.com/git-lfs/lfs-test-server as lfs module base
Imported commit is 3968aac269a77b73924649b9412ae03f7ccd3198
Removed:
Dockerfile CONTRIBUTING.md mgmt* script/ vendor/ kvlogger.go
.dockerignore .gitignore README.md
* Remove config, add JWT support from github.com/mgit-at/lfs-test-server
Imported commit f0cdcc5a01599c5a955dc1bbf683bb4acecdba83
* Add LFS settings
* Add LFS meta object model
* Add LFS routes and initialization
* Import github.com/dgrijalva/jwt-go into vendor/
* Adapt LFS module: handlers, routing, meta store
* Move LFS routes to /user/repo/info/lfs/*
* Add request header checks to LFS BatchHandler / PostHandler
* Implement LFS basic authentication
* Rework JWT secret generation / load
* Implement LFS SSH token authentication with JWT
Specification: https://github.com/github/git-lfs/tree/master/docs/api
* Integrate LFS settings into install process
* Remove LFS objects when repository is deleted
Only removes objects from content store when deleted repo is the only
referencing repository
* Make LFS module stateless
Fixes bug where LFS would not work after installation without
restarting Gitea
* Change 500 'Internal Server Error' to 400 'Bad Request'
* Change sql query to xorm call
* Remove unneeded type from LFS module
* Change internal imports to code.gitea.io/gitea/
* Add Gitea authors copyright
* Change basic auth realm to "gitea-lfs"
* Add unique indexes to LFS model
* Use xorm count function in LFS check on repository delete
* Return io.ReadCloser from content store and close after usage
* Add LFS info to runWeb()
* Export LFS content store base path
* LFS file download from UI
* Work around git-lfs client issue with unauthenticated requests
Returning a dummy Authorization header for unauthenticated requests
lets git-lfs client skip asking for auth credentials
See: https://github.com/github/git-lfs/issues/1088
* Fix unauthenticated UI downloads from public repositories
* Authentication check order, Finish LFS file view logic
* Ignore LFS hooks if installed for current OS user
Fixes Gitea UI actions for repositories tracking LFS files.
Checks for minimum needed git version by parsing the semantic version
string.
* Hide LFS metafile diff from commit view, marking as binary
* Show LFS notice if file in commit view is tracked
* Add notbefore/nbf JWT claim
* Correct lint suggestions - comments for structs and functions
- Add comments to LFS model
- Function comment for GetRandomBytesAsBase64
- LFS server function comments and lint variable suggestion
* Move secret generation code out of conditional
Ensures no LFS code may run with an empty secret
* Do not hand out JWT tokens if LFS server support is disabled
2016-12-26 09:16:37 +08:00
Philip Couling
d4924d45d6
Implement sendmail ( #355 )
...
* Implemented sendmail. This piggybacks on existing configuration to keep the change simple
* Changed privicy of new sendSMTP and sendSendmail functions
* Fixed Lint errors
* Seperated SMTP and sendmail into their own senders
* Making new structs private as they should not be used externally now
* Added sendmail setting to ini file
* Minor code cleanup
2016-12-25 14:55:22 +01:00
Bwko
fa3abc22c0
Added sorting to organizations, repos & users page ( #222 )
2016-12-24 22:42:26 +08:00
Bwko
a345a03d99
Added sorting to the labels & milestones page ( #199 )
2016-12-24 22:41:09 +08:00
Ethan Koenig
d0932ef147
Bug fixes for Issues filters ( #413 )
...
Correctly handle simultaneous assignee/poster filters, and conflicting assignee filters
2016-12-24 18:33:21 +08:00
Ethan Koenig
8a4161c723
API Endpoint for watching ( #191 )
2016-12-24 09:53:11 +08:00
btrepp
25b5ffb6af
Enables mssql support ( #383 )
...
* Enables mssql support
Port of dlobs work in gogs.
Enables options in index.js
Enables MSSQL as a database option in go.
Sets ID to 0 on initial migration. Required for
MSSQL insert statements.
Signed-off-by: Beau Trepp <beautrepp@gmail.com>
* Vendors in denisenkom/go-mssqldb
Includes golang.org/x/crypto/md4
as this is required by go-msssqldb
Signed-off-by: Beau Trepp <beautrepp@gmail.com>
2016-12-24 09:37:35 +08:00
Lunny Xiao
a822bba3e1
Add default values for settings ( #455 )
...
* add default values for settings
* more default values
* more default settings and labels resource
* mv locale to options
2016-12-23 15:18:05 +08:00
Thomas Boerger
b33078fa33
Bindata is optional and over-writable on restart ( #354 )
...
* Moved conf assets into options folder
* Dropped old bindata
* Started to integrate options bindata and accessors
* Do not enforce a builtin app.ini
* Replaced bindata calls with options
* Dropped bindata task from makefile, it's the generate task now
* Always embedd app.ini to provide sane config defaults
* Use sane defaults for the configuration
* Defined default value for SSH_KEYGEN_PATH
* Dropped "NEVER EVER MODIFY THIS FILE" header from app.ini
* Fixed new paths in latest test additions
* Drop bindata with make clean task
* Set more proper default values
2016-12-22 19:12:23 +01:00
Lunny Xiao
c21e2c4151
fix tag webhook 404 error ( #420 )
2016-12-22 22:57:48 +08:00
Lunny Xiao
47a7529d96
update code.gitea.io/git ( #450 )
2016-12-22 10:30:52 +01:00
Lunny Xiao
0c5c34d7dd
UpdateIssueUsersByMentions was calling database write operations while ( #443 )
...
a transaction session was in progress. MailParticipants was failing
silently because of the SQLITE_LOCKED error. Make sure failures in
MailParticipants enter the log, and pass on the transaction context.
issue: let caller pass in database context, and use it
issue_comment: obtain database context to pass to UpdateIssueMentions
issue_comment: log any error from call to MailParticipants
issue_mail: pass on database context to UpdateIssueMentions
2016-12-22 17:00:39 +08:00
Ethan Koenig
4c89a9c33c
Bug fixes and tests for modules/base ( #442 )
...
Also address other TODOs
2016-12-22 16:58:04 +08:00
Kim "BKC" Carlbäcker
df7fa4e995
issue comment api fix ( #449 )
...
* ListAllInRepo & Delete Issue-Comments
* Moar data in issue-comments
2016-12-22 16:29:26 +08:00
Alexander Lunegov
d5d21b67d2
Fix string format verbs ( #3637 )
2016-12-22 08:18:41 +01:00
Denis Denisov
380e32e129
Fix random string generator ( #384 )
...
* Remove unused custom-alphabet feature of random string generator
Fix random string generator
Random string generator should return error if it fails to read random data via crypto/rand
* Fixes variable (un)initialization mixed assign
Update test GetRandomString
2016-12-20 13:32:02 +01:00
Michael de Wit
1d30457a94
change test mail subject and body to 'Gitea Test Mail!'
...
Signed-off-by: Michael de Wit <mjwwit@gmail.com>
2016-12-20 09:34:50 +01:00
Lunny Xiao
7c46667e71
fixed vulnerabilities labels ( #409 )
2016-12-17 19:49:17 +08:00
Richie B2B
44428fdc38
Remove fixed FIXME ( #408 )
2016-12-16 17:00:30 +01:00
Richie B2B
0d6e88baef
Fix typo ( #407 )
2016-12-16 17:00:15 +01:00
Lunny Xiao
15c3d14d55
fixed vulnerabilities on deleting release ( #399 )
2016-12-16 19:42:39 +08:00
Lunny Xiao
b4c794058a
fixed vulnerabilities ( #392 )
2016-12-15 16:49:06 +08:00
Lunny Xiao
d771e978a1
Don't use custom PBKDF2 function ( #382 )
2016-12-15 09:24:27 +08:00
Lunny Xiao
73710c00a8
bug fixed branch name for pushupdate ( #380 )
2016-12-13 15:19:42 +08:00
Denis Denisov
f0a989c1d0
Correction LDAP validation ( #342 )
...
* Correction LDAP username validation
As https://msdn.microsoft.com/en-us/library/aa366101(v=vs.85).aspx describe spaces should not be in start or at the end of username but they can be inside the username. So please check my solution for it.
* Check for zero length passwords in LDAP module.
According to https://tools.ietf.org/search/rfc4513#section-5.1.2 LDAP client should always check before bind whether a password is an empty value. There are at least one LDAP implementation which does not return error if you try to bind with DN set and empty password - AD.
* Clearing the login/email spaces at the [start/end]
2016-12-12 08:46:51 +08:00
Bwko
abcd39f7d5
In the wiki title replace tab with a space ( #371 )
2016-12-11 11:01:26 +08:00
Bwko
cbcb4361d5
Fixes issue #283
...
Delete old temp local copy before we create a new temp local copy
2016-12-09 20:13:48 +01:00
Ethan Koenig
401a8db0ed
Remove stale comment in models/repo.go ( #366 )
2016-12-08 00:04:12 +01:00
Ethan Koenig
04b9a7e7a2
Bug fixes for repo permissions in API
...
Also move duplicated code into repo.APIFormat(..)
2016-12-07 12:55:24 +01:00
Thomas Boerger
83ed234472
Integrate templates into bindata optionally ( #314 )
...
Integrated optional bindata for the templates
2016-12-06 18:58:31 +01:00
Kim "BKC" Carlbäcker
d07c955e2a
Fix regression in PR-API #248 ( #349 )
...
* Fix #344 (regression in PR-API #248 )
2016-12-05 12:17:39 +01:00
Bwko
0118b275b6
Fix for #320
...
Suppress the error when we're removing a file that may not exist
2016-12-03 22:31:54 +01:00
Denis Denisov
c8f300b2cd
Safe compare password (timing attack) ( #338 )
2016-12-03 13:49:17 +08:00
Kim "BKC" Carlbäcker
0f05470cb8
[API] Pull Requests ( #248 )
2016-12-02 12:10:39 +01:00
Kim "BKC" Carlbäcker
e8e0539b45
Linting
2016-12-02 09:31:44 +01:00
Kim "BKC" Carlbäcker
e6cfccdd40
GitHub API Compliance (& linting)
2016-12-02 09:18:15 +01:00
Bwko
4ff0db0246
Catch os... errors
2016-12-02 07:41:19 +01:00
Bwko
5ab85372da
Added rel="noopener" to target="_blank" hrefs ( #327 )
...
* Added rel="noopener" to target="_blank" hrefs
* Replaced gogs.io/docs with docs.gitea.io
2016-12-02 09:12:16 +08:00
Lunny Xiao
646e02b521
typo
2016-12-01 09:05:32 +08:00
Thomas Boerger
6dd2c3b2db
Fixed linting errors for variable definitions
2016-11-29 14:05:26 +01:00
Kim "BKC" Carlbäcker
42ec5ce740
Fix breakage from vendor-update
2016-11-29 11:50:22 +01:00
Kim "BKC" Carlbäcker
dad806d3ea
CreateBranch-hook has shasum. Use the full ref for fetching shasum
2016-11-29 11:50:22 +01:00
Kim "BKC" Carlbäcker
f364522468
Tag-webhooks are useless without shasums
2016-11-29 11:50:22 +01:00
Andrey Nering
fd53028139
Merge pull request #294 from Bwko/Lint/user.go
...
Lint models/user.go
2016-11-28 20:30:02 -02:00
Bwko
bad1bc6518
Lint models/repo.go
2016-11-28 18:27:55 +01:00
Bwko
a5aae1c145
Lint models/repo_*
2016-11-28 17:58:59 +01:00
Bwko
9963d61233
Lint models/user.go
2016-11-28 17:47:46 +01:00
Lunny Xiao
27d66855eb
golint fixed for models/migrations ( #291 )
2016-11-28 23:44:17 +08:00
Lunny Xiao
1d0f811399
golint fixed for models/pull.go ( #292 )
2016-11-28 23:31:06 +08:00
Lunny Xiao
9fc609ce17
golint fixed for models/issue_comment.go
2016-11-28 21:33:09 +08:00
Thomas Boerger
9948f0daaa
Merge pull request #285 from lunny/lunny/golint_models_org_team
...
Golint for models/org_team.go
2016-11-28 09:42:53 +01:00
Lunny Xiao
f215d78157
rename all uID -> userID on models/org_team.go
2016-11-28 16:33:08 +08:00
Lunny Xiao
bf8d90c5cc
golint fixed for models/models.go ( #284 )
2016-11-28 15:25:16 +08:00
Lunny Xiao
21846d16e5
golint for models/org_team.go
2016-11-28 09:30:08 +08:00
Lunny Xiao
ec87a75c00
golint fixed for modules/auth
2016-11-27 21:39:06 +08:00
Bwko
a4ece1f223
Fixes typos
2016-11-27 12:59:12 +01:00
Thomas Boerger
5efdccd1d8
Merge pull request #264 from Bwko/lint/org.go
...
Lint models/org.go
2016-11-27 12:18:20 +01:00
Thomas Boerger
9a984c0d49
Merge pull request #266 from Bwko/lint/repo_mirror
...
Lint models/repo_mirror.go
2016-11-27 12:15:01 +01:00
Thomas Boerger
fe3908d099
Merge pull request #268 from Bwko/lint/repo_branch
...
Lint models/repo_branch.go
2016-11-27 12:14:25 +01:00
Thomas Boerger
e23a9d22e5
Merge pull request #267 from Bwko/lint/ssh_key
...
Lint models/ssh_key.go
2016-11-27 12:13:43 +01:00
Thomas Boerger
93d527a0a4
Merge pull request #265 from Bwko/lint/access.go
...
Lint models/access.go
2016-11-27 12:12:56 +01:00
Thomas Boerger
8347a55cc2
Merge pull request #263 from Bwko/lint/user_email
...
Lint models/user_email.go
2016-11-27 12:12:02 +01:00
Lunny Xiao
94da472717
Golint fixed for modules/setting ( #262 )
...
* golint fixed for modules/setting
* typo fixed and renamed UNIXSOCKET to UnixSocket
2016-11-27 18:14:25 +08:00
Bwko
0b9cf10340
Lint models/org.go & models.go
2016-11-26 11:37:50 +01:00
Bwko
7bf7042013
Lint models/repo_mirror.go
2016-11-26 11:23:55 +01:00
Bwko
ce8c9ef580
Lint models/repo_branch.go
2016-11-26 11:20:37 +01:00
Bwko
6cde041080
Lint models/ssh_key.go
2016-11-26 01:36:03 +01:00
Bwko
2bb1601d7c
Lint models/access.go
2016-11-26 01:07:57 +01:00
Bwko
066f515a47
Lint models/user_email.go
2016-11-26 01:03:06 +01:00
Thomas Boerger
574e49c854
Merge pull request #241 from Bwko/lint/admin.go
...
Lint models/admin.go
2016-11-25 12:55:24 +01:00
Thomas Boerger
21b7d30174
Merge pull request #245 from Bwko/lint/update&slack
...
Lint models/update.go, release.go & webhook_slack.go
2016-11-25 12:55:14 +01:00
Thomas Boerger
e9c6053b86
Merge pull request #246 from Bwko/fix/typo
...
Fix typos
2016-11-25 12:54:57 +01:00
Thomas Boerger
3e6f363471
Merge pull request #256 from lunny/lunny/golint_modules_avatar
...
Golint fixed for modules/avatar
2016-11-25 10:11:44 +01:00
Thomas Boerger
7c5de1e393
Merge pull request #250 from lunny/lunny/golint_modules_markdown
...
Golint fixed for modules/markdown
2016-11-25 10:08:23 +01:00
Lunny Xiao
3c87c57d96
golint fixed for modules/avatar
2016-11-25 16:37:04 +08:00
Bwko
c0ca6644ad
Lint/issue &mail ( #243 )
...
* Lint models/release.go
* Lint models/ issue_label, issue_mail & mail.go
2016-11-25 16:11:12 +08:00
Bwko
081c2a9395
Lint models/token.go ( #244 )
2016-11-25 16:03:52 +08:00
Lunny Xiao
76604d8f90
fixed test build error
2016-11-25 16:02:10 +08:00
Bwko
33a2ac3830
Lint models/update.go & webhook_slack.go
2016-11-25 07:55:08 +01:00
Lunny Xiao
304bbd3f25
golint fixed for modules/markdown
2016-11-25 09:58:05 +08:00
Bwko
d8e11a8eaa
Lint models/admin.go
2016-11-24 23:42:07 +01:00
Bwko
ece19f4a5e
Lint models/release.go
2016-11-24 22:02:54 +01:00
Lunny Xiao
450969c158
test database is connect OK after db config initialized ( #239 )
2016-11-24 22:30:36 +08:00
Sandro Santilli
1c3044b873
Lint models/login_source.go
2016-11-24 12:34:38 +01:00
Thomas Boerger
0a66c2a2d9
Merge pull request #234 from strk/issue-lint
...
Lint issue.go
2016-11-24 11:30:39 +01:00
Thomas Boerger
e512411863
Merge pull request #233 from strk/git_diff-lint
...
Lint git_diff.go
2016-11-24 11:29:51 +01:00
Thomas Boerger
03b6880089
Merge pull request #232 from strk/error-lint
...
Lint error.go
2016-11-24 11:29:15 +01:00
Sandro Santilli
8aa960f129
Actually document the missing bits
2016-11-24 09:41:11 +01:00
Sandro Santilli
3fba29c571
Expand documentations
2016-11-24 09:30:08 +01:00
Sandro Santilli
0a61d54a9c
Expand documentation a bit more
2016-11-24 09:20:28 +01:00
Sandro Santilli
dd9d0f3732
Lint action.go
2016-11-24 09:03:29 +01:00
Sandro Santilli
170f2e98cc
Lint error.go
...
This was done semi-programmatically, not really documenting anything
2016-11-24 09:03:17 +01:00
Sandro Santilli
6e644726d0
Lint git_diff.go
...
Semi-automatic linting (don't really document things)
2016-11-24 09:02:58 +01:00
Sandro Santilli
4dd1eb57bd
Lint issue.go
2016-11-24 09:02:44 +01:00
stroucki
3a3782bb7f
Handle ssh key import better ( #224 )
...
* Handle user ssh key input better
ssh_key: when user submitted keys had a newline at the end, strings.Split
would have created a slice with an empty last element, and the key type
check would be incorrect. Perhaps a better way is to look for 'ssh-rsa' or
'ssh-dsa' at the beginning of the string, but this is simple.
* ssh_key: correct indentation
2016-11-24 08:52:55 +08:00
Sandro Santilli
c25063d834
Lint webhook.go, unexports simpleMarshalJSON ( #198 )
2016-11-22 14:42:52 +08:00
Bwko
2a449bd4b1
Fix typos
2016-11-21 20:08:21 +01:00
Ethan Koenig
0834e492c0
API endpoints for stars
2016-11-16 22:51:54 -05:00
Bo-Yi Wu
d9ffe99972
fix variable assigned and not used.
...
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
2016-11-15 14:16:27 +08:00
Sandro Santilli
592a4ec4d3
Fix lint errors in models/wiki (just add methods docs)
...
See #70
2016-11-14 18:01:46 +01:00
Andrey Nering
739f07c98e
Remember diff view style ( #163 )
2016-11-13 10:54:04 +08:00
LefsFlare
3ef022b071
Fixes possible vulnerabilities with keyword hijacking ( #20 )
...
- Added public entries to reserved keywords list
- Rename variables
- Derped comment
2016-11-12 13:26:45 +01:00
Lunny Xiao
3dedc027ac
Bug fixed for issues ( #156 )
2016-11-12 13:06:33 +01:00
Lunny Xiao
0baaa7728a
bug fixed caused by #153 ( #154 )
2016-11-12 09:30:46 +01:00
Lunny Xiao
30a37311f8
use in instead string join ( #155 )
2016-11-12 09:29:18 +01:00
Lunny Xiao
555d8b16cb
fixed bug #151 caused Find should be Get ( #153 )
2016-11-12 00:01:09 +01:00
Lunny Xiao
ade6d4a20f
optimization on database IN
2016-11-12 01:31:37 +08:00
Lunny Xiao
9bf28a2799
bug fixed for 500 caused by get org users ( #149 )
2016-11-12 00:55:06 +08:00
Thibault Meyer
ddee4c8b58
Normalize files with gofmt
2016-11-11 13:11:45 +01:00
Sandro Santilli
a1c5f02444
Fix import path of go-sdk ( #141 )
...
From code.gitea.io/go-sdk/gitea
To code.gitea.io/sdk/gitea
2016-11-11 17:39:44 +08:00
Thibault Meyer
b12f2a5916
Remove unused import
2016-11-10 21:10:25 +01:00
Thibault Meyer
b0ddced2b5
Merge remote-tracking branch 'upstream/master' into feature/rewrite-xorm-queries
...
# Conflicts:
# models/git_diff.go
# models/issue.go
# models/org.go
# models/pull.go
# models/repo.go
2016-11-10 21:05:52 +01:00
Thibault Meyer
a4454f5d0f
Rewrite XORM queries
2016-11-10 20:59:51 +01:00
Sandro Santilli
4247304f5a
Update import paths from github.com/go-gitea to code.gitea.io ( #135 )
...
- Update import paths from github.com/go-gitea to code.gitea.io
- Fix import path for travis
See https://docs.travis-ci.com/user/languages/go#Go-Import-Path
2016-11-10 17:24:48 +01:00
Matthias Loibl
94b2747375
Remove go version from build tags ( #133 )
2016-11-10 08:43:49 -02:00
Lunny Xiao
1b238fe4d5
Merge pull request #121 from joubertredrat/feature-last-login
...
Last Login for admin manage your users
2016-11-10 17:20:55 +08:00
Lunny Xiao
c6c840faf7
Merge pull request #129 from lunny/lunny/SQL_instead_Sql
...
use x.SQL instead of x.Sql
2016-11-10 17:12:14 +08:00
Thibault Meyer
3a10a0c1ca
Ordering organizations and users by name
2016-11-10 09:18:54 +01:00
Lunny Xiao
7dcc3bc3d7
use x.SQL instead of x.Sql
2016-11-10 15:20:48 +08:00
Joubert RedRat
f91cbf0fed
Support to last login feature
2016-11-09 08:53:45 -02:00
Lunny Xiao
c511f1c6c3
Merge pull request #18 from LefsFlarey/issue/3675
...
Fix 500 error caused by deleted users on issues (#3675 )
2016-11-09 15:14:18 +08:00
Flare
a6c487f6ca
Fix err not being nil
2016-11-09 13:07:01 +08:00
Lunny Xiao
5667d4daae
Merge pull request #73 from bkcsoft/gt/2164-release-pagination
...
Add Pagination to Releases-page (and de-duplicate pagination templates)
2016-11-08 10:39:03 +08:00
Sandro Santilli
864d1b1f9f
Fix type in unused constant name ( #111 )
...
* Write LDAP, SMTP, PAM, DLDAP back to all uppercase
* Fix type in unused constant name
* Other MixCased fixes
* Complete MixerCasing of template constants
* Re uppercase LTS and LDAPS suffixes
* Uppercase JSON suffix in constant names
* Proper case LoginNoType
* Prefix unexported template path constants with "tpl"
2016-11-07 18:58:22 -02:00
Sandro Santilli
aadd7dcdc3
And others
2016-11-07 17:53:22 +01:00
Sandro Santilli
b3828e38a5
more
2016-11-07 17:41:28 +01:00
Sandro Santilli
05fd9d3f09
Security protocols
2016-11-07 17:38:43 +01:00
Sandro Santilli
7612b5ec40
More mixage
2016-11-07 17:37:28 +01:00
Sandro Santilli
64196d4036
More overlooks
2016-11-07 17:35:34 +01:00
Sandro Santilli
f14232d2e9
This one I overlooked before
2016-11-07 17:33:03 +01:00
Sandro Santilli
60c82a8780
More...
2016-11-07 17:30:04 +01:00
Sandro Santilli
f6a11e0de1
More MixedCase consts
2016-11-07 17:24:59 +01:00
Sandro Santilli
f388661bda
ACCESS_MODE_* -> AccessMode*
2016-11-07 17:20:37 +01:00
Sandro Santilli
0b62aeb495
More MixedCase consts
2016-11-07 17:08:21 +01:00
Sandro Santilli
80eea77953
Use MixedCase constant names
...
See https://github.com/golang/go/wiki/CodeReviewComments#mixed-caps
2016-11-07 17:05:08 +01:00
Thomas Boerger
5d430c9e68
Merge pull request #108 from go-gitea/go-sdk
...
Replaced gogits go-gogs-client with go-sdk
2016-11-07 16:31:17 +01:00
Sandro Santilli
ee963f67c1
Merge pull request #103 from strk/GOGS_drop
...
Replace GOGS with GITEA in variable names
2016-11-07 16:30:48 +01:00
Joubert RedRat
28bee28102
Replace Gogs to Gitea in installation options
2016-11-07 13:26:19 -02:00
Thomas Boerger
4c6c16f358
Replaced go-gogs-client with go-sdk imports
2016-11-07 16:10:32 +01:00
Sandro Santilli
30be1f4826
Fix typo in unused constant name
2016-11-07 16:06:21 +01:00
Sandro Santilli
b7263f31a5
Replace GOGS with GITEA in variable names
...
Still use GOGS_WORK_DIR and GOGS_CUSTOM env variables
as a fallback if the equivalent GITEA_* are not set,
warning user about the need for change.
Does not change "gogs" to "gitea" in webhook type name
Because "gogs" hook type is part of the API (routes) and used
in templates...
Closes #87
2016-11-07 16:05:18 +01:00
Kim "BKC" Carlbäcker
86fb1a0cb1
Add Pagination to Releases-page
2016-11-07 11:41:09 +01:00
Sandro Santilli
6e4252dad4
Replace gogits/git-module dependency with go-gitea/git ( #94 )
...
* Replace gogits/git-module dependency with go-gitea/git
Fixes #92
* Remove git alias for git module import (not needed)
2016-11-06 11:18:34 -02:00
LefsFlare
55a4d46f5d
Adds checking of reserved keywords against team names ( #22 )
2016-11-06 10:07:03 +01:00
Thibault Meyer
fe8bfa54de
Ordering team by name ascending except for 'Owners' ( #48 )
2016-11-06 09:59:21 +01:00
Matthias Loibl
953c099428
Add missing version & gogs package
2016-11-05 18:04:47 +01:00
Matthias Loibl
1f44b01e2a
Fix imports found by goimports.
2016-11-05 17:56:35 +01:00
Thomas Boerger
648c6fdd60
Vet complains about "should have signature MarshalJSON() ([]byte, error)", replaced with custom name
2016-11-04 23:45:06 +01:00
Flare
fd6be0d17e
Still print error if user does not exist
2016-11-05 02:47:54 +08:00
Matthias Loibl
a4fa889ced
Run goimports on the whole project ( #34 )
...
Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
2016-11-04 09:57:27 -02:00
Rémy Boulanouar
8dc49dc114
Implementation of the feature to redirect to an external issue tracker
2016-11-04 09:06:54 +01:00
Rémy Boulanouar
2d68bd1ef9
Change import reference to match gitea instead of gogs ( #37 )
2016-11-03 10:29:56 -02:00
Sandro Santilli
af03d00780
Fix sender of issue notifications
...
It is the FROM field in mailer configuration that needs be used,
not the USER field, which is for authentication.
Closes https://github.com/gogits/gogs/issues/3615
2016-11-02 21:00:54 +01:00
LefsFlare
2bec8a4f1e
Changed interface ( #3685 )
2016-09-22 19:38:12 -04:00
Flare
1b59e6f910
Fix 500 error caused by deleted users on issues ( #3675 )
2016-09-20 18:13:57 +08:00
Unknwon
6da55159a2
#3589 LoadRepoConfig after ORM is initialized
2016-09-02 23:18:37 -04:00
Unknwon
c50d59874d
#3577 incorrect URL produced by AvatarLink
2016-09-01 12:36:26 -04:00
Unknwon
7c1fbed057
Fix panic when attempt login with non-exist user
2016-09-01 05:12:34 -04:00
Unknwon
c2afdf2192
Minor code fix [CI SKIP]
2016-08-31 04:31:53 -07:00
Unknwon
152e715999
models/login_source: code improvement
2016-08-31 01:22:41 -07:00
Unknwon
99c2ae7b35
#3515 use alert instead 500 for duplicated login source name
2016-08-31 00:56:10 -07:00
Unknwon
8516dfcb6c
#2018 able to sync now for mirrors
...
- Refactor code to use sync.UniqueQueue
- Closes #3509
2016-08-30 16:18:33 -07:00
Unknwon
c1ecb6c60a
modules/sync: add UniqueQueue
2016-08-30 15:50:30 -07:00
Unknwon
43297148b2
modules/sync: rename SingleInstancePool to ExclusivePool
2016-08-30 15:19:53 -07:00
Unknwon
643142acab
Web editor: support upload files
2016-08-30 05:23:59 -07:00
Unknwon
28cf0e6aaa
#3459 code quality improvement
2016-08-29 20:00:06 -07:00
Thibault Meyer
92fb30c526
Load a set of predefined labels ( #3459 )
...
* Can use a predefined set of labels
* Change UI
* Fix HTML file indentation
* Avoid reading file from other directory (security issue)
* Apply a better fix
* Remove not used variable
* Merge upstream/develop
* Do modifications
* Raname
* remove binding + rename variable
2016-08-29 19:02:49 -07:00
LFlare
3738b6399e
Fixed typo ( #3533 )
...
Git convention has it capitalised.
2016-08-29 11:31:12 -07:00
Unknwon
62b0dc4853
Web editor: fix cannot create new file in subdirectory
2016-08-29 00:10:21 -07:00
Unknwon
579e5e4fee
Web editor: disallow edit mirror repository
2016-08-28 04:56:41 -07:00
Unknwon
0114fdcba4
Web editor: improve delete file process
2016-08-28 01:41:44 -07:00
Unknwon
dad5c15520
#2901 allow setting preferred licenses
...
- Closes #3488
2016-08-28 00:06:22 -07:00
Unknwon
c30b856d14
#3505 use user’s info for committer and author
2016-08-27 13:37:55 -07:00
Unknwon
13c106af77
label: adjust forecolor boundary
2016-08-27 12:44:39 -07:00
Unknwon
ce1e4348da
#3521 fix wiki HTTP/S clone URL does not have .wiki suffix
2016-08-27 12:29:52 -07:00
Unknwon
37305a59ca
migrations: sync table first
2016-08-26 17:32:41 -07:00
Unknwon
bb359a74f1
migrations: set comment updated as created
2016-08-26 14:07:21 -07:00
Unknwon
6b98d58906
#2966 code cleanup
2016-08-26 13:40:53 -07:00
Iwan Budi Kusnanto
8dca9f95fa
issues comment API : list, create, edit ( #2966 )
...
add `since` query string support to list issue comment
2016-08-26 11:23:21 -07:00
Thibault Meyer
f50e568fd1
Fix #3189 : Sort labels by name ( #3446 )
...
* Fix #3189 #3445 : Order labels by name
* Order labels by name on Issues view
2016-08-25 17:43:53 -07:00
Unknwon
f8a48ffaad
Web editor: improve code quality
2016-08-24 21:35:03 -07:00
Kurt Madel
67fb0fe6a5
added support to set pull_request event from api ( #3513 )
2016-08-24 20:44:58 -07:00
Unknwon
0b273ac4d5
#3383 code cleanup
2016-08-24 16:05:56 -07:00
Kim "BKC" Carlbäcker
06602a84ff
Fix PR-webhook issue where Label-data is stale ( #3486 ) ( #3510 )
...
* Fix PR-webhook issue where Label-data is stale
* Conventions \o/
* logs are nice if they're consistent...
2016-08-24 12:01:30 -07:00
Unknwon
a00c932bbc
General code quality improvement
2016-08-16 23:06:38 -07:00
Unknwon
6f9a95f830
#2246 add HTMLURL to webhook type
...
- Fill Milestone and Assignee field when available in webhook payload
2016-08-16 10:19:09 -07:00
Unknwon
8bf57be9ba
Fix git diff tests
2016-08-16 07:45:06 -07:00
Unknwon
b1504ed99a
#3464 add diff signs which does not have inline diff
2016-08-16 07:37:28 -07:00
Unknwon
9349def72e
#3464 reproduce diff signs
...
Commited wrong file.
2016-08-16 07:33:53 -07:00