Remove doesn't set deletedAt on disk #1

Geschlossen
von Ghost vor 3 Jahren geöffnet · 1 Kommentare
Ghost hat vor 3 Jahren kommentiert

Calling remove seems to be a no-op. I've looked through the code and it appears as though it should be setting deletedAt and then syncing the change to disk, but in personal testing this does not appear to be happening.

I've noticed that the test suite does not check that deletedAt is set (or the alternative, that the site is no longer managed), and raised an issue there also: https://git.coolaj86.com/coolaj86/greenlock-manager-test.js/issues/3

Calling remove seems to be a no-op. I've looked through the code and it appears as though it should be setting deletedAt and then syncing the change to disk, but in personal testing this does not appear to be happening. I've noticed that the test suite does not check that deletedAt is set (or the alternative, that the site is no longer managed), and raised an issue there also: https://git.coolaj86.com/coolaj86/greenlock-manager-test.js/issues/3
Ghost hat vor 3 Jahren kommentiert

Ahh, closing this as the bug is in Greenlock itself - documented here: https://git.coolaj86.com/coolaj86/greenlock.js/issues/56

Issue regarding testing still stands afaict

Ahh, closing this as the bug is in Greenlock itself - documented here: https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 Issue regarding testing still stands afaict
Ghost hat diesen Issue vor 3 Jahren geschlossen
Anmelden, um an der Diskussion teilzunehmen.
Kein Label
Kein Meilenstein
Niemand zuständig
1 Beteiligte
Nachrichten
Fällig am

Kein Fälligkeitsdatum gesetzt.

Abhängigkeiten

Dieses Issue hat momentan keine Abhängigkeiten.

Laden…
Hier gibt es bis jetzt noch keinen Inhalt.