Remove doesn't set deletedAt on disk #1

クローズ
Ghostが3年前にオープン · 1件のコメント
Ghost3年前 にコメント

Calling remove seems to be a no-op. I've looked through the code and it appears as though it should be setting deletedAt and then syncing the change to disk, but in personal testing this does not appear to be happening.

I've noticed that the test suite does not check that deletedAt is set (or the alternative, that the site is no longer managed), and raised an issue there also: https://git.coolaj86.com/coolaj86/greenlock-manager-test.js/issues/3

Calling remove seems to be a no-op. I've looked through the code and it appears as though it should be setting deletedAt and then syncing the change to disk, but in personal testing this does not appear to be happening. I've noticed that the test suite does not check that deletedAt is set (or the alternative, that the site is no longer managed), and raised an issue there also: https://git.coolaj86.com/coolaj86/greenlock-manager-test.js/issues/3
Ghost 3年前 にコメント

Ahh, closing this as the bug is in Greenlock itself - documented here: https://git.coolaj86.com/coolaj86/greenlock.js/issues/56

Issue regarding testing still stands afaict

Ahh, closing this as the bug is in Greenlock itself - documented here: https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 Issue regarding testing still stands afaict
Ghost が課題をクローズ 3年前
サインインしてこの会話に参加。
ラベルなし
マイルストーンなし
担当者なし
1 人の参加者
通知
期日

期日は未設定です。

依存関係

この課題に依存関係はありません。

読み込み中…
まだ内容がありません