Remove doesn't set deletedAt on disk #1
クローズ
Ghostが3年前にオープン
·
1件のコメント
読み込み中…
新しい課題から参照
まだ内容がありません
ブランチ '%!s(MISSING)' の削除
ブランチの削除は恒久的で、元に戻すことはできません。 続行しますか?
ブランチの削除は恒久的で、元に戻すことはできません。 続行しますか?
Calling remove seems to be a no-op. I've looked through the code and it appears as though it should be setting deletedAt and then syncing the change to disk, but in personal testing this does not appear to be happening.
I've noticed that the test suite does not check that deletedAt is set (or the alternative, that the site is no longer managed), and raised an issue there also: https://git.coolaj86.com/coolaj86/greenlock-manager-test.js/issues/3
Ahh, closing this as the bug is in Greenlock itself - documented here: https://git.coolaj86.com/coolaj86/greenlock.js/issues/56
Issue regarding testing still stands afaict