Remove doesn't set deletedAt on disk #1
닫힘
by Ghost opened 3 년 전
·
1개의 코멘트
불러오는 중...
Reference in new issue
아직 콘텐츠가 없습니다.
'%!s(MISSING)' 브랜치 삭제
Deleting a branch is permanent. It CANNOT be undone. Continue?
Calling remove seems to be a no-op. I've looked through the code and it appears as though it should be setting deletedAt and then syncing the change to disk, but in personal testing this does not appear to be happening.
I've noticed that the test suite does not check that deletedAt is set (or the alternative, that the site is no longer managed), and raised an issue there also: https://git.coolaj86.com/coolaj86/greenlock-manager-test.js/issues/3
Ahh, closing this as the bug is in Greenlock itself - documented here: https://git.coolaj86.com/coolaj86/greenlock.js/issues/56
Issue regarding testing still stands afaict