Remove doesn't set deletedAt on disk #1

Zamknięty
by Ghost opened 3 lat temu · 1 komentarzy
Ghost skomentował(-a) 3 lat temu

Calling remove seems to be a no-op. I've looked through the code and it appears as though it should be setting deletedAt and then syncing the change to disk, but in personal testing this does not appear to be happening.

I've noticed that the test suite does not check that deletedAt is set (or the alternative, that the site is no longer managed), and raised an issue there also: https://git.coolaj86.com/coolaj86/greenlock-manager-test.js/issues/3

Calling remove seems to be a no-op. I've looked through the code and it appears as though it should be setting deletedAt and then syncing the change to disk, but in personal testing this does not appear to be happening. I've noticed that the test suite does not check that deletedAt is set (or the alternative, that the site is no longer managed), and raised an issue there also: https://git.coolaj86.com/coolaj86/greenlock-manager-test.js/issues/3
Ghost skomentował(-a) 3 lat temu

Ahh, closing this as the bug is in Greenlock itself - documented here: https://git.coolaj86.com/coolaj86/greenlock.js/issues/56

Issue regarding testing still stands afaict

Ahh, closing this as the bug is in Greenlock itself - documented here: https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 Issue regarding testing still stands afaict
Ghost zamknął(-ęła) to zgłoszenie 3 lat temu
Zaloguj się, aby dołączyć do tej rozmowy.
Brak etykiety
Brak kamienia milowego
Brak przypisanych
Uczestnicy 1
Powiadomienia
Termin realizacji

Brak ustawionego terminu realizacji.

Zależności

To zgłoszenie nie ma w tej chwili żadnych zależności.

Ładowanie…
Nie ma jeszcze treści.