Remove doesn't set deletedAt on disk #1
Zamknięty
by Ghost opened 3 lat temu
·
1 komentarzy
Ładowanie…
Reference in new issue
Nie ma jeszcze treści.
Usuń gałąź '%!s(MISSING)'
Usunięcie gałęzi jest trwałe i NIE MOŻE zostać cofnięte. Kontynuować?
Calling remove seems to be a no-op. I've looked through the code and it appears as though it should be setting deletedAt and then syncing the change to disk, but in personal testing this does not appear to be happening.
I've noticed that the test suite does not check that deletedAt is set (or the alternative, that the site is no longer managed), and raised an issue there also: https://git.coolaj86.com/coolaj86/greenlock-manager-test.js/issues/3
Ahh, closing this as the bug is in Greenlock itself - documented here: https://git.coolaj86.com/coolaj86/greenlock.js/issues/56
Issue regarding testing still stands afaict