Remove doesn't set deletedAt on disk #1

已关闭
Ghost 创建于 3 年前 · 1 条评论
Ghost 评论于 3 年前

Calling remove seems to be a no-op. I've looked through the code and it appears as though it should be setting deletedAt and then syncing the change to disk, but in personal testing this does not appear to be happening.

I've noticed that the test suite does not check that deletedAt is set (or the alternative, that the site is no longer managed), and raised an issue there also: https://git.coolaj86.com/coolaj86/greenlock-manager-test.js/issues/3

Calling remove seems to be a no-op. I've looked through the code and it appears as though it should be setting deletedAt and then syncing the change to disk, but in personal testing this does not appear to be happening. I've noticed that the test suite does not check that deletedAt is set (or the alternative, that the site is no longer managed), and raised an issue there also: https://git.coolaj86.com/coolaj86/greenlock-manager-test.js/issues/3
Ghost 评论于 3 年前

Ahh, closing this as the bug is in Greenlock itself - documented here: https://git.coolaj86.com/coolaj86/greenlock.js/issues/56

Issue regarding testing still stands afaict

Ahh, closing this as the bug is in Greenlock itself - documented here: https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 Issue regarding testing still stands afaict
Ghost3 年前 关闭此工单
登录 并参与到对话中。
未选择标签
未选择里程碑
未指派成员
1 名参与者
通知
到期时间

未设置到期时间。

依赖工单

此工单当前没有任何依赖。

正在加载...
这个人很懒,什么都没留下。