coolaj86
/
greenlock-manager-test.js
1
0
Vork 0
Code Kwesties 3 Pull-aanvragen Publicaties Wiki Activiteit
Labels Mijlpalen
Nieuw probleem

Test for `remove()` doesn't check either removal or that deletedAt() was set #3

Open
by Ghost opened 3 jaren geleden · 1 comments
Ghost commented 3 jaren geleden

It seems like the call to remove should either fully remove the site entry, or at the very least set deletedAt to the current time.

Currently the test does not check that either of these happen. At the moment it seems like the reference implementation does not set deletedAt (at least in my own testing) - something that should be caught by the test suite.

It seems like the call to `remove` should either fully remove the site entry, or at the very least set `deletedAt` to the current time. Currently the test does not check that either of these happen. At the moment it seems like the reference implementation does not set `deletedAt` (at least in my own testing) - something that should be caught by the test suite.
Ghost commented 3 jaren geleden

Bug is not in greenlock-manager-fs itself, but in Greenlock. Appears that greenlock-manager-fs should work, when https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 is fixed.

I'm still thinking that remove should be more fully tested.

Bug is not in greenlock-manager-fs itself, but in Greenlock. Appears that greenlock-manager-fs should work, when https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 is fixed. I'm still thinking that remove should be more fully tested.
Log in om deel te nemen aan deze discussie.
Geen Branch/Tag gespecificeerd
Branches Labels
master
Labels
Labels toepassen
Verwijder labels
Geen items
Geen label
Mijlpaal
Stel mijlpaal in
Verwijder mijlpaal
Geen items
Geen mijlpaal
Toegewezen aan
Gebruikers toewijzen
Verwijder toegewezen aan
Niet toegewezen
1 deelnemers
Notificaties
Vervaldatum

Geen vervaldatum ingesteld.

Afhankelijkheden

Deze kwestie heeft momenteel geen afhankelijkheden.

Schrijf Voorbeeld
Laden…
Annuleren
Opslaan
Er is nog geen inhoud.
Verwijder branch '%!s(MISSING)'

Het verwijderen van een branch is permanent. Het KAN NIET ongedaan gemaakt worden. Wil je toch doorgaan?

Nee
Ja