Test for `remove()` doesn't check either removal or that deletedAt() was set #3
Aberto
by Ghost opened 3 anos atrás
·
1 comentários
Sem etiqueta
Sem marco
Sem responsável
1 participante(s)
Notificações
Data limite
Data limite não informada.
Dependências
Esta issue atualmente não tem dependências.
Carregando…
Reference in new issue
Ainda não há conteúdo.
Excluir branch '%!s(MISSING)'
A exclusão de uma branch é permanente. Isto NÃO PODERÁ ser desfeito. Continuar?
It seems like the call to
removeshould either fully remove the site entry, or at the very least setdeletedAtto the current time.Currently the test does not check that either of these happen. At the moment it seems like the reference implementation does not set
deletedAt(at least in my own testing) - something that should be caught by the test suite.Bug is not in greenlock-manager-fs itself, but in Greenlock. Appears that greenlock-manager-fs should work, when https://git.coolaj86.com/coolaj86/greenlock.js/issues/56 is fixed.
I'm still thinking that remove should be more fully tested.