expose renewableAt? #1

New Issue

Ghost · 2017-11-30T14:13:16Z

Ghost commented

2017-11-30 14:13:16 +00:00

Currently, the check and register results expose when the certificate is registered and when it expires. However, it does not expose when it is renewable, even though this information is available. From the debug logs:

[le/lib/core.js] checkAsync found existing certificates
[le/lib/core.js] Check Expires At 2018-02-27T20:55:57.000Z
[le/lib/core.js] Check Renewable At 2018-02-20T20:55:57.000Z

Should we expose this date? Or can I assume that it is always exactly 7 days before expiresAt?

Currently, the `check` and `register` results expose when the certificate is registered and when it expires. However, it does not expose when it is renewable, even though this information is available. From the debug logs: [le/lib/core.js] checkAsync found existing certificates [le/lib/core.js] Check Expires At 2018-02-27T20:55:57.000Z [le/lib/core.js] Check Renewable At 2018-02-20T20:55:57.000Z Should we expose this date? Or can I assume that it is always exactly 7 days before `expiresAt`?

coolaj86 commented

2018-03-21 07:48:06 +00:00

Yes, this should be exposed. I would happily accept a PR.

coolaj86 commented

2018-04-19 19:38:10 +00:00

This is available as renewWithin, now documented in the README.

The default has also been changed to 14 days. Published in v2.2.3.

Thanks for the feedback!

This is available as `renewWithin`, now documented in the README. The default has also been changed to 14 days. Published in v2.2.3. Thanks for the feedback!

coolaj86 closed this issue

2018-04-19 19:38:10 +00:00

coolaj86 commented

2018-04-19 19:40:32 +00:00

The minimum (renewBy) defaults to 10 days. The maximum (renewWithin) defaults to 14 days.

A random time is generated within this window so that the renewal dates will skew a little bit between domains and you won't be bogging down your server on exactly a particular day and time to suddenly renew 100 certificates all at once.

:)

The minimum (`renewBy`) defaults to 10 days. The maximum (`renewWithin`) defaults to 14 days. A random time is generated within this window so that the renewal dates will skew a little bit between domains and you won't be bogging down your server on exactly a particular day and time to suddenly renew 100 certificates all at once. :)

Sign in to join this conversation.

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/greenlock.js-ARCHIVED#1

expose renewableAt? #1

expose `renewableAt`? #1