coolaj86/greenlock.js-ARCHIVED
3
3
Fork 0
Código Issues 6 Pull requests 1 Versões Atividade

expose renewableAt? #1

Nova issue
Fechado
2017-11-30 14:13:16 +00:00 abertas por Ghost · 3 comentários
Ghost comentou 2017-11-30 14:13:16 +00:00
Copiar link

Currently, the check and register results expose when the certificate is registered and when it expires. However, it does not expose when it is renewable, even though this information is available. From the debug logs:

[le/lib/core.js] checkAsync found existing certificates
[le/lib/core.js] Check Expires At 2018-02-27T20:55:57.000Z
[le/lib/core.js] Check Renewable At 2018-02-20T20:55:57.000Z

Should we expose this date? Or can I assume that it is always exactly 7 days before expiresAt?

Currently, the `check` and `register` results expose when the certificate is registered and when it expires. However, it does not expose when it is renewable, even though this information is available. From the debug logs: [le/lib/core.js] checkAsync found existing certificates [le/lib/core.js] Check Expires At 2018-02-27T20:55:57.000Z [le/lib/core.js] Check Renewable At 2018-02-20T20:55:57.000Z Should we expose this date? Or can I assume that it is always exactly 7 days before `expiresAt`?
coolaj86 comentou 2018-03-21 07:48:06 +00:00
Proprietário
Copiar link

Yes, this should be exposed. I would happily accept a PR.

Yes, this should be exposed. I would happily accept a PR.
coolaj86 comentou 2018-04-19 19:38:10 +00:00
Proprietário
Copiar link

This is available as renewWithin, now documented in the README.

The default has also been changed to 14 days. Published in v2.2.3.

Thanks for the feedback!

This is available as `renewWithin`, now documented in the README. The default has also been changed to 14 days. Published in v2.2.3. Thanks for the feedback!
coolaj86 comentou 2018-04-19 19:40:32 +00:00
Proprietário
Copiar link

The minimum (renewBy) defaults to 10 days. The maximum (renewWithin) defaults to 14 days.

A random time is generated within this window so that the renewal dates will skew a little bit between domains and you won't be bogging down your server on exactly a particular day and time to suddenly renew 100 certificates all at once.

:)

The minimum (`renewBy`) defaults to 10 days. The maximum (`renewWithin`) defaults to 14 days. A random time is generated within this window so that the renewal dates will skew a little bit between domains and you won't be bogging down your server on exactly a particular day and time to suddenly renew 100 certificates all at once. :)
Acesse para participar desta conversação.
Nenhum branch/tag especificado
Branches Tags
Etiquetas
Nenhum item
Sem etiqueta
Marco
Nenhum item
Sem marco
Responsáveis
Limpar responsáveis
jshaver coolaj86
Sem responsável
2 participante(s)
Notificações
Data limite
Data limite não informada.
Dependências

Nenhuma dependência definida.

Referência: coolaj86/greenlock.js-ARCHIVED#1
Nenhuma descrição fornecida.
Excluir branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?