Is redundant, without that clause the promise will already resolve to results.
https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/core.js#L439
Doing
```
promise.then(function (results) {
return results;
})
```
Is redundant, without that clause the promise will already resolve to `results`.
It's probably leftover from some debugging or a transformation of data, or a control flow branch that was removed.
I'll leave this open to remind me to take care of that.
Correct, this is safe to remove.
It's probably leftover from some debugging or a transformation of data, or a control flow branch that was removed.
I'll leave this open to remind me to take care of that.
AJ - do you have any objections to adding jest in for unit testing? I know this is a trivial change but that makes it useful for proving test automation.
Your hand rolled test code keeps things simple but I appreciate the extra info that using a framework provides.
AJ - do you have any objections to adding jest in for unit testing? I know this is a trivial change but that makes it useful for proving test automation.
Your hand rolled test code keeps things simple but I appreciate the extra info that using a framework provides.
(btw - what the target minimum node level? I am working with 8 but tend to babel compile from 7+.)
Happy to create a pull request for this one, with or without jest
(btw - what the target minimum node level? I am working with 8 but tend to babel compile from 7+.)
Happy to create a pull request for this one, with or without jest
Sorry about delay - I got stuck trying to wire a test around it. Not sure how to best test? Do you generally point it at the sandbox on an internet IP for testing?
Sorry about delay - I got stuck trying to wire a test around it. Not sure how to best test? Do you generally point it at the sandbox on an internet IP for testing?
@chanoch Yes. I create a temporary digital ocean vps and point four test domains at it and run through a few different scenarios.
Then I deploy it to git.coolaj86.com and a possibly a few other sites to see if it works in my existing setups as well.
@chanoch Yes. I create a temporary digital ocean vps and point four test domains at it and run through a few different scenarios.
Then I deploy it to git.coolaj86.com and a possibly a few other sites to see if it works in my existing setups as well.
https://git.coolaj86.com/coolaj86/greenlock.js/src/branch/master/lib/core.js#L439
Doing
Is redundant, without that clause the promise will already resolve to
results
.Correct, this is safe to remove.
It's probably leftover from some debugging or a transformation of data, or a control flow branch that was removed.
I'll leave this open to remind me to take care of that.
AJ - do you have any objections to adding jest in for unit testing? I know this is a trivial change but that makes it useful for proving test automation.
Your hand rolled test code keeps things simple but I appreciate the extra info that using a framework provides.
(btw - what the target minimum node level? I am working with 8 but tend to babel compile from 7+.)
Happy to create a pull request for this one, with or without jest
No objections.
Thank you, btw.
Sorry about delay - I got stuck trying to wire a test around it. Not sure how to best test? Do you generally point it at the sandbox on an internet IP for testing?
@chanoch Yes. I create a temporary digital ocean vps and point four test domains at it and run through a few different scenarios.
Then I deploy it to git.coolaj86.com and a possibly a few other sites to see if it works in my existing setups as well.