coolaj86/greenlock.js-ARCHIVED
3
3
Förgrening 0
Kod Ärenden 6 Pull-förfrågningar 1 Släpp Aktiviteter

expected return object for approveDomains #15

Nytt Ärende
Stängd
öppnade 2018-08-24 21:27:25 +00:00 av ryanburnette · 2 kommentarer
ryanburnette kommenterad 2018-08-24 21:27:25 +00:00
Kopiera länk

In this video you mention that in a later version, a custom approveDomains function will be expected to return only opts, not an object with opts and certs keys. Will this change be breaking? Or could it expect the returned object to be arranged either way?

https://youtu.be/bTEn93gxY50?t=408

In this video you mention that in a later version, a custom approveDomains function will be expected to return only `opts`, not an object with `opts` and `certs` keys. Will this change be breaking? Or could it expect the returned object to be arranged either way? https://youtu.be/bTEn93gxY50?t=408
coolaj86 kommenterad 2018-08-24 21:55:02 +00:00
Ägare
Kopiera länk

Well, since I can check fn.length I suppose I could introduce it in v2.

But when v3 hits I’ll probably want to break it hard and reduce code size. It does too much already. Now that it’s fully implemented and all the discovery is done it can be refined.

Well, since I can check fn.length I suppose I could introduce it in v2. But when v3 hits I’ll probably want to break it hard and reduce code size. It does too much already. Now that it’s fully implemented and all the discovery is done it can be refined.
coolaj86 refererade till detta ärende från en incheckning 2018-11-05 08:11:04 +00:00
update approveDomains function as per #15
coolaj86 kommenterad 2018-11-05 08:11:39 +00:00
Ägare
Kopiera länk

This is now available in a backwards-compatible fashion in the v2.5 branch

This is now available in a backwards-compatible fashion in the v2.5 branch
Logga in för att delta i denna konversation.
Ingen Branch/Tag specificerad
Grenar Taggar
Etiketter
Inga objekt
Ingen Etikett
Milsten
Inga objekt
Ingen Milsten
Tilldelade
Rensa tilldelade
jshaver coolaj86
Ingen tilldelad
2 Deltagare
Notiser
Förfallodatum
Inget förfallodatum satt.
Beroenden

No dependencies set.

Reference: coolaj86/greenlock.js-ARCHIVED#15
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?