coolaj86
/
greenlock.js-ARCHIVED
3
3
Fork 0
Code Issues 13 Pull Requests 1 Releases Activity
Labels Milestones
New Issue

expected return object for approveDomains #15

Closed
opened 6 years ago by ryanburnette · 2 comments
ryanburnette commented 6 years ago

In this video you mention that in a later version, a custom approveDomains function will be expected to return only opts, not an object with opts and certs keys. Will this change be breaking? Or could it expect the returned object to be arranged either way?

https://youtu.be/bTEn93gxY50?t=408

In this video you mention that in a later version, a custom approveDomains function will be expected to return only `opts`, not an object with `opts` and `certs` keys. Will this change be breaking? Or could it expect the returned object to be arranged either way? https://youtu.be/bTEn93gxY50?t=408
coolaj86 commented 6 years ago
Owner

Well, since I can check fn.length I suppose I could introduce it in v2.

But when v3 hits I’ll probably want to break it hard and reduce code size. It does too much already. Now that it’s fully implemented and all the discovery is done it can be refined.

Well, since I can check fn.length I suppose I could introduce it in v2. But when v3 hits I’ll probably want to break it hard and reduce code size. It does too much already. Now that it’s fully implemented and all the discovery is done it can be refined.
coolaj86 commented 6 years ago
Owner

This is now available in a backwards-compatible fashion in the v2.5 branch

This is now available in a backwards-compatible fashion in the v2.5 branch
coolaj86 closed this issue 5 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
acmev2
dns-challenge-regression-fix
github
greenlock
master
next
node-letsencrypt-python
npm
v1
v2
v2.1
v2.2
v2.3
v2.4
v2.5
v3
v4
wip
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes