expected return object for approveDomains #15

Nova issue

ryanburnette · 2018-08-24T21:27:25Z

ryanburnette comentou

2018-08-24 21:27:25 +00:00

In this video you mention that in a later version, a custom approveDomains function will be expected to return only opts, not an object with opts and certs keys. Will this change be breaking? Or could it expect the returned object to be arranged either way?

https://youtu.be/bTEn93gxY50?t=408

In this video you mention that in a later version, a custom approveDomains function will be expected to return only `opts`, not an object with `opts` and `certs` keys. Will this change be breaking? Or could it expect the returned object to be arranged either way? https://youtu.be/bTEn93gxY50?t=408

coolaj86 comentou

2018-08-24 21:55:02 +00:00

Proprietário

Well, since I can check fn.length I suppose I could introduce it in v2.

But when v3 hits I’ll probably want to break it hard and reduce code size. It does too much already. Now that it’s fully implemented and all the discovery is done it can be refined.

Well, since I can check fn.length I suppose I could introduce it in v2. But when v3 hits I’ll probably want to break it hard and reduce code size. It does too much already. Now that it’s fully implemented and all the discovery is done it can be refined.

coolaj86 citou esta issue em um commit

2018-11-05 08:11:04 +00:00

update approveDomains function as per #15

coolaj86 comentou

2018-11-05 08:11:39 +00:00

Proprietário

This is now available in a backwards-compatible fashion in the v2.5 branch

coolaj86 fechou esta issue

2019-02-05 05:14:48 +00:00

coolaj86 citou esta issue em um commit

2019-11-01 11:10:12 +00:00

updated letiny-core dep, show better error message, related to #15