coolaj86
/
greenlock.js-ARCHIVED
3
3
Fork 0
Code Issues 13 Pull Requests 1 Releases Activity
Labels Milestones
New Issue

communityMember should default to false #16

Closed
by Ghost opened 6 years ago · 0 comments
Ghost commented 6 years ago 
λ ~/Projects/greenlock.js/ master rg "communityMember"
index.js
363:            lexOpts.communityMember = lexOpts.communityMember;

README.md
165:, communityMember: true               // Optionally get important greenlock updates (security, api changes, etc)
249:  opts.communityMember = true;
302:, communityMember: true           // Help make Greenlock better by submitting
536:  * v2.2.8 - communityMember option support

lib/core.js
410:            if (args.communityMember && !args._communityMemberAdded) {
414:              args._communityMemberAdded = true;
421:            if (args.communityMember && !args._communityMemberAdded) {
425:              args._communityMemberAdded = true;

We should default this to false

```sh λ ~/Projects/greenlock.js/ master rg "communityMember" index.js 363: lexOpts.communityMember = lexOpts.communityMember; README.md 165:, communityMember: true // Optionally get important greenlock updates (security, api changes, etc) 249: opts.communityMember = true; 302:, communityMember: true // Help make Greenlock better by submitting 536: * v2.2.8 - communityMember option support lib/core.js 410: if (args.communityMember && !args._communityMemberAdded) { 414: args._communityMemberAdded = true; 421: if (args.communityMember && !args._communityMemberAdded) { 425: args._communityMemberAdded = true; ``` We should default this to `false`
Ghost closed this issue 6 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
acmev2
dns-challenge-regression-fix
github
greenlock
master
next
node-letsencrypt-python
npm
v1
v2
v2.1
v2.2
v2.3
v2.4
v2.5
v3
v4
wip
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes