communityMember should default to false #16

Fermé
2018-08-28 21:53:07 +00:00 ouvert par Ghost · 0 commentaire
λ ~/Projects/greenlock.js/ master rg "communityMember"
index.js
363:            lexOpts.communityMember = lexOpts.communityMember;

README.md
165:, communityMember: true               // Optionally get important greenlock updates (security, api changes, etc)
249:  opts.communityMember = true;
302:, communityMember: true           // Help make Greenlock better by submitting
536:  * v2.2.8 - communityMember option support

lib/core.js
410:            if (args.communityMember && !args._communityMemberAdded) {
414:              args._communityMemberAdded = true;
421:            if (args.communityMember && !args._communityMemberAdded) {
425:              args._communityMemberAdded = true;

We should default this to false

```sh λ ~/Projects/greenlock.js/ master rg "communityMember" index.js 363: lexOpts.communityMember = lexOpts.communityMember; README.md 165:, communityMember: true // Optionally get important greenlock updates (security, api changes, etc) 249: opts.communityMember = true; 302:, communityMember: true // Help make Greenlock better by submitting 536: * v2.2.8 - communityMember option support lib/core.js 410: if (args.communityMember && !args._communityMemberAdded) { 414: args._communityMemberAdded = true; 421: if (args.communityMember && !args._communityMemberAdded) { 425: args._communityMemberAdded = true; ``` We should default this to `false`
Ghost a fermé ce ticket 2018-08-28 21:53:39 +00:00.
Connectez-vous pour rejoindre cette conversation.
Sans labels
Sans jalon
Sans assignation
1 participants
Notifications
Échéance
La date d’échéance est invalide ou hors plage. Veuillez utiliser le format 'aaaa-mm-dd'.

Aucune échéance n'a été définie.

Dépendances

Aucune dépendance définie.

Référence : coolaj86/greenlock.js-ARCHIVED#16
Sans contenu.