checking for req.socket.servername on plain sockets #18

New Issue

coolaj86 · 2018-09-07T18:12:47Z

coolaj86 commented

2018-09-07 18:12:47 +00:00

Should first check for req.socket.encrypted

        } else if (safehost && !gl.middleware.sanitizeHost._skip_fronting_check) {
          // TODO how to handle wrapped sockets, as with telebit?
          console.warn(safehost, typeof req.socket.servername, req.servername, req.socket.servername, req.socket.encrypted);
          console.warn("\n\n\n[greenlock] WARN: no string for req.socket.servername,"
            + " skipping fronting check for '" + safehost + "'\n\n\n");

Should first check for req.socket.encrypted ``` } else if (safehost && !gl.middleware.sanitizeHost._skip_fronting_check) { // TODO how to handle wrapped sockets, as with telebit? console.warn(safehost, typeof req.socket.servername, req.servername, req.socket.servername, req.socket.encrypted); console.warn("\n\n\n[greenlock] WARN: no string for req.socket.servername," + " skipping fronting check for '" + safehost + "'\n\n\n"); ```

coolaj86 commented

2018-11-05 07:43:29 +00:00

Fixed in v2.4.8

coolaj86 closed this issue

2018-11-05 07:43:29 +00:00

coolaj86 referenced this issue from a commit

2019-11-01 11:10:12 +00:00

fix #18 letsencrypt-express

Sign in to join this conversation.