Unused challenges => unrelated warning about le.challenges[tls-sni-01].loopback #2

New Issue

Ghost · 2017-12-28T20:28:14Z

Ghost commented

2017-12-28 20:28:14 +00:00

https://git.coolaj86.com/coolaj86/greenlock.js/src/master/index.js#L81-L97 fills in several challenges, even if I provide my own le-challenge-route53.

This results in me getting a warning le.challenges[tls-sni-01].loopback should be defined as function (opts, domain, token, cb) { ... } and should prove (by external means) that the ACME server challenge 'tls-sni-01' will succeed, which is not related to anything I want to do.

https://git.coolaj86.com/coolaj86/greenlock.js/src/master/index.js#L81-L97 fills in several challenges, even if I provide my own le-challenge-route53. This results in me getting a warning `le.challenges[tls-sni-01].loopback should be defined as function (opts, domain, token, cb) { ... } and should prove (by external means) that the ACME server challenge 'tls-sni-01' will succeed`, which is not related to anything I want to do.

Ghost commented

2017-12-28 20:39:07 +00:00

And it creates middleware even if I don't have any need for it, making at least 'http-01' a must.

coolaj86 commented

2018-03-21 07:47:23 +00:00

I'll be updating greenlock for acme-v2 (git.coolaj86.com/coolaj86/acme-v2.js) and when I do there will no longer be a need for the loopback test.

coolaj86 commented

2018-04-19 18:55:30 +00:00

The loopback test has been removed. Instead the loopback check now occurs directly in acme-v2.js).

http-01 still has a default plugin, but this isn't something I think I should remove at this point.

Thanks for the feedback.

Also, I'd love a PR with a link to your route53 module. :)

The loopback test has been removed. Instead the loopback check now occurs directly in [`acme-v2.js`](https://git.coolaj86.com/coolaj86/acme-v2.js)). `http-01` still has a default plugin, but this isn't something I think I should remove at this point. Thanks for the feedback. Also, I'd love a PR with a link to your route53 module. :)

coolaj86 closed this issue

2018-04-19 18:55:30 +00:00

Ghost commented

2018-04-19 19:05:16 +00:00

Not much to it: https://github.com/SignalK/letsencrypt-plugin/blob/master/le.js

coolaj86 referenced this issue from a commit

2019-11-01 11:10:12 +00:00

Merge pull request #2 from marcusnielsen/fix-readme-typo Docs: Fixes a typo i the readme.

Sign in to join this conversation.