coolaj86/greenlock.js-ARCHIVED
3
3
Fork 0
程式碼 問題 6 合併請求 1 版本發布 動態

Unused challenges => unrelated warning about le.challenges[tls-sni-01].loopback #2

新增問題
已關閉
建立於 2017-12-28 20:28:14 +00:00 由 Ghost · 4 comment
Ghost 已留言 2017-12-28 20:28:14 +00:00
複製連結

https://git.coolaj86.com/coolaj86/greenlock.js/src/master/index.js#L81-L97 fills in several challenges, even if I provide my own le-challenge-route53.

This results in me getting a warning le.challenges[tls-sni-01].loopback should be defined as function (opts, domain, token, cb) { ... } and should prove (by external means) that the ACME server challenge 'tls-sni-01' will succeed, which is not related to anything I want to do.

https://git.coolaj86.com/coolaj86/greenlock.js/src/master/index.js#L81-L97 fills in several challenges, even if I provide my own le-challenge-route53. This results in me getting a warning `le.challenges[tls-sni-01].loopback should be defined as function (opts, domain, token, cb) { ... } and should prove (by external means) that the ACME server challenge 'tls-sni-01' will succeed`, which is not related to anything I want to do.
Ghost 已留言 2017-12-28 20:39:07 +00:00
作者
複製連結

And it creates middleware even if I don't have any need for it, making at least 'http-01' a must.

And it creates middleware even if I don't have any need for it, making at least 'http-01' a must.
coolaj86 已留言 2018-03-21 07:47:23 +00:00
擁有者
複製連結

I'll be updating greenlock for acme-v2 (git.coolaj86.com/coolaj86/acme-v2.js) and when I do there will no longer be a need for the loopback test.

I'll be updating greenlock for acme-v2 (git.coolaj86.com/coolaj86/acme-v2.js) and when I do there will no longer be a need for the loopback test.
coolaj86 已留言 2018-04-19 18:55:30 +00:00
擁有者
複製連結

The loopback test has been removed. Instead the loopback check now occurs directly in acme-v2.js).

http-01 still has a default plugin, but this isn't something I think I should remove at this point.

Thanks for the feedback.

Also, I'd love a PR with a link to your route53 module. :)

The loopback test has been removed. Instead the loopback check now occurs directly in [`acme-v2.js`](https://git.coolaj86.com/coolaj86/acme-v2.js)). `http-01` still has a default plugin, but this isn't something I think I should remove at this point. Thanks for the feedback. Also, I'd love a PR with a link to your route53 module. :)
coolaj86 關閉了這個問題 2018-04-19 18:55:30 +00:00
Ghost 已留言 2018-04-19 19:05:16 +00:00
作者
複製連結

Not much to it: https://github.com/SignalK/letsencrypt-plugin/blob/master/le.js

Not much to it: https://github.com/SignalK/letsencrypt-plugin/blob/master/le.js
登入 才能加入這對話。
未指定分支或標籤
分支 標籤
標籤
沒有項目
未選擇標籤
里程碑
沒有項目
未選擇里程碑
負責人
清除負責人
jshaver coolaj86
沒有負責人
2 參與者
通知
截止日期
未設定截止日期。
先決條件

未設定先決條件。

參考: coolaj86/greenlock.js-ARCHIVED#2
No description provided.
刪除分支「%!s()」

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?