coolaj86/greenlock.js-ARCHIVED
3
3
Fork 0
Code Issues 6 Pull Requests 1 Releases Activity

Wildcard updates broke non-wildcard domain #34

New Issue
Closed
opened 2019-04-01 19:12:59 +00:00 by Ghost · 6 comments
Ghost commented 2019-04-01 19:12:59 +00:00
Copy Link

This has broken my server

Apr  1 13:39:28 ip-172-31-2-116 node: Unhandled rejection TypeError: Cannot read property 'toLowerCase' of undefined
Apr  1 13:39:28 ip-172-31-2-116 node: at /.../node_modules/greenlock/lib/utils.js:26:26
Apr  1 13:39:28 ip-172-31-2-116 node: at Array.some (<anonymous>)
Apr  1 13:39:28 ip-172-31-2-116 node: at Object.module.exports.certHasDomain (/.../node_modules/greenlock/lib/uti$
Apr  1 13:39:28 ip-172-31-2-116 node: at /.../node_modules/greenlock/lib/core.js:444:23
This has broken my server ``` Apr 1 13:39:28 ip-172-31-2-116 node: Unhandled rejection TypeError: Cannot read property 'toLowerCase' of undefined Apr 1 13:39:28 ip-172-31-2-116 node: at /.../node_modules/greenlock/lib/utils.js:26:26 Apr 1 13:39:28 ip-172-31-2-116 node: at Array.some (<anonymous>) Apr 1 13:39:28 ip-172-31-2-116 node: at Object.module.exports.certHasDomain (/.../node_modules/greenlock/lib/uti$ Apr 1 13:39:28 ip-172-31-2-116 node: at /.../node_modules/greenlock/lib/core.js:444:23 ```
coolaj86 commented 2019-04-01 20:05:11 +00:00
Owner
Copy Link

Can you give me some more information? I have tests cases surrounding this that pass.

I don't doubt that my update broke it. However, I'm not sure how to reproduce. What does your config look like?

Can you give me some more information? I have tests cases surrounding this that pass. I don't doubt that my update broke it. However, I'm not sure how to reproduce. What does your config look like?
Ghost commented 2019-04-01 20:11:39 +00:00
Author
Copy Link

Sure. I imagine these kind of bugs are a pain to track.

    const lex = require('greenlock-express').create({
      version: 'draft-11',
      server: config.ssl.staging ? 'https://acme-staging-v02.api.letsencrypt.org/directory' : 'https://acme-v02.api.letsencrypt.org/directory',
      agreeTos: true,
      configDir: config.ssl.certDir, // '~/certs/'
      email: config.ssl.email,
      communityMember: false,
      telemetry: false,
      app,
      approveDomains: config.ssl.domains // ['my.domain.com']
    })

    server = lex.listen(config.port, config.ssl.port)

Not sure what else to provide. It's been working great all this time until last update. I'm guessing _domain isn't getting passed or some test is failing.

Sure. I imagine these kind of bugs are a pain to track. ``` const lex = require('greenlock-express').create({ version: 'draft-11', server: config.ssl.staging ? 'https://acme-staging-v02.api.letsencrypt.org/directory' : 'https://acme-v02.api.letsencrypt.org/directory', agreeTos: true, configDir: config.ssl.certDir, // '~/certs/' email: config.ssl.email, communityMember: false, telemetry: false, app, approveDomains: config.ssl.domains // ['my.domain.com'] }) server = lex.listen(config.port, config.ssl.port) ``` Not sure what else to provide. It's been working great all this time until last update. I'm guessing _domain isn't getting passed or some test is failing.
coolaj86 commented 2019-04-01 20:21:34 +00:00
Owner
Copy Link

I think it may be a bug in greenlock-express, actually - passing in bad data and missing the 'domain' string for the servername on startup when it isn't available yet and falling through to trying to use it anyway.

I've published greenlock@v2.7.1 with a workaround that should do until I can address the other tonight.

Please give it a try and let me know if that fixes it for you.

I think it may be a bug in greenlock-express, actually - passing in bad data and missing the 'domain' string for the servername on startup when it isn't available yet and falling through to trying to use it anyway. I've published `greenlock@v2.7.1` with a workaround that should do until I can address the other tonight. Please give it a try and let me know if that fixes it for you.
Ghost commented 2019-04-01 20:26:38 +00:00
Author
Copy Link

Ok I'll give it a try later. Is there a way to force it to update? greenlock is a dependency of greenlock-express (which is a dependency of my project). so npm update or ci even doesn't seem to update it that deep.

Ok I'll give it a try later. Is there a way to force it to update? greenlock is a dependency of greenlock-express (which is a dependency of my project). so npm update or ci even doesn't seem to update it that deep.
coolaj86 commented 2019-04-01 20:29:06 +00:00
Owner
Copy Link

greenlock-express has a package-lock.json (which is still pointing to the older version of greenlock), so npm ci should do the trick.

However, you can manually npm install --save greenlock@2.7.1 at the root of your project and that shouldn't be in conflict with greenlock-express' dependency graphy.

(otherwise we have a very strange catch 22)

greenlock-express has a `package-lock.json` (which is still pointing to the older version of `greenlock`), so `npm ci` _should_ do the trick. However, you can manually `npm install --save greenlock@2.7.1` at the root of your project and that _shouldn't_ be in conflict with `greenlock-express`' dependency graphy. (otherwise we have a very strange catch 22)
Ghost commented 2019-04-01 20:52:35 +00:00
Author
Copy Link

That looks to have done the trick. Thanks @coola86

That looks to have done the trick. Thanks @coola86
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jshaver coolaj86
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coolaj86/greenlock.js-ARCHIVED#34
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?