coolaj86/greenlock.js-ARCHIVED
3
3
Fork 0
Code Issues 6 Pull Requests 1 Releases Activity

challenge files are never deleted #35

New Issue
Closed
opened 2019-04-07 14:04:02 +00:00 by Ghost · 1 comment
Ghost commented 2019-04-07 14:04:02 +00:00
Copy Link

challenge files are never deleted from disk.
I've traced it to the following line:
core.js:405
gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.keyAuthorization, done);

should be:
gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.token, done);

challenge files are never deleted from disk. I've traced it to the following line: core.js:405 gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.keyAuthorization, done); should be: gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.token, done);
coolaj86 commented 2019-04-07 15:27:20 +00:00
Owner
Copy Link

Thank you very much, especially for detailing exactly where the bug is.

Updated and published as Greenlock @ v2.7.13

And I apologize for the mess you saw in the code. We're in the process of adding transitional code (like that nasty block you found this bug in, which unfortunately was introduced by the change) to be forwards compatible with the upcoming v3 API so that in the near future the code will be much more consistent, smaller, and easier to test.

Thank you very much, especially for detailing exactly where the bug is. Updated and published as Greenlock @ v2.7.13 And I apologize for the mess you saw in the code. We're in the process of adding transitional code (like that nasty block you found this bug in, which unfortunately was introduced by the change) to be forwards compatible with the upcoming v3 API so that in the near future the code will be much more consistent, smaller, and easier to test.
Sign in to join this conversation.
greenlock
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jshaver coolaj86
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coolaj86/greenlock.js-ARCHIVED#35
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?