challenge files are never deleted #35

Nieuw probleem

Ghost · 2019-04-07T14:04:02Z

Ghost reageerde

2019-04-07 14:04:02 +00:00

challenge files are never deleted from disk.
I've traced it to the following line:
core.js:405
gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.keyAuthorization, done);

should be:
gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.token, done);

challenge files are never deleted from disk. I've traced it to the following line: core.js:405 gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.keyAuthorization, done); should be: gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.token, done);

coolaj86 reageerde

2019-04-07 15:27:20 +00:00

Eigenaar

Thank you very much, especially for detailing exactly where the bug is.

Updated and published as Greenlock @ v2.7.13

And I apologize for the mess you saw in the code. We're in the process of adding transitional code (like that nasty block you found this bug in, which unfortunately was introduced by the change) to be forwards compatible with the upcoming v3 API so that in the near future the code will be much more consistent, smaller, and easier to test.

Thank you very much, especially for detailing exactly where the bug is. Updated and published as Greenlock @ v2.7.13 And I apologize for the mess you saw in the code. We're in the process of adding transitional code (like that nasty block you found this bug in, which unfortunately was introduced by the change) to be forwards compatible with the upcoming v3 API so that in the near future the code will be much more consistent, smaller, and easier to test.

coolaj86 heeft dit probleem gesloten

2019-04-07 15:27:20 +00:00

Log in om deel te nemen aan deze discussie.

Geen label

Geen mijlpaal

Niet toegewezen

2 deelnemers

Notificaties

Vervaldatum

De deadline is ongeldig of buiten bereik. Gebruik het formaat 'jjjj-mm-dd'.

Geen vervaldatum ingesteld.

Afhankelijkheden

Geen afhankelijkheden ingesteld.

Referentie: coolaj86/greenlock.js-ARCHIVED#35