challenge files are never deleted #35
Etiquetas
Sem etiqueta
Sem marco
Sem responsável
2 participante(s)
Notificações
Data limite
Data limite não informada.
Dependências
Nenhuma dependência definida.
Referência: coolaj86/greenlock.js-ARCHIVED#35
Carregando…
Referência em uma nova issue
Nenhuma descrição fornecida.
Excluir branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
challenge files are never deleted from disk.
I've traced it to the following line:
core.js:405
gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.keyAuthorization, done);
should be:
gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.token, done);
Thank you very much, especially for detailing exactly where the bug is.
Updated and published as Greenlock @ v2.7.13
And I apologize for the mess you saw in the code. We're in the process of adding transitional code (like that nasty block you found this bug in, which unfortunately was introduced by the change) to be forwards compatible with the upcoming v3 API so that in the near future the code will be much more consistent, smaller, and easier to test.