challenge files are never deleted #35

Nytt Ärende

Ghost · 2019-04-07T14:04:02Z

Ghost kommenterad

2019-04-07 14:04:02 +00:00

challenge files are never deleted from disk.
I've traced it to the following line:
core.js:405
gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.keyAuthorization, done);

should be:
gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.token, done);

challenge files are never deleted from disk. I've traced it to the following line: core.js:405 gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.keyAuthorization, done); should be: gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.token, done);

coolaj86 kommenterad

2019-04-07 15:27:20 +00:00

Ägare

Thank you very much, especially for detailing exactly where the bug is.

Updated and published as Greenlock @ v2.7.13

And I apologize for the mess you saw in the code. We're in the process of adding transitional code (like that nasty block you found this bug in, which unfortunately was introduced by the change) to be forwards compatible with the upcoming v3 API so that in the near future the code will be much more consistent, smaller, and easier to test.

Thank you very much, especially for detailing exactly where the bug is. Updated and published as Greenlock @ v2.7.13 And I apologize for the mess you saw in the code. We're in the process of adding transitional code (like that nasty block you found this bug in, which unfortunately was introduced by the change) to be forwards compatible with the upcoming v3 API so that in the near future the code will be much more consistent, smaller, and easier to test.

coolaj86 stängde ärendet

2019-04-07 15:27:20 +00:00

Logga in för att delta i denna konversation.

Ingen Etikett

Ingen Milsten

Ingen tilldelad

2 Deltagare

Notiser

Förfallodatum

Förfallodatumet är ogiltigt eller utanför gränserna. Använd formatet 'åååå-mm-dd'.

Inget förfallodatum satt.

Beroenden

No dependencies set.

Reference: coolaj86/greenlock.js-ARCHIVED#35