challenge files are never deleted #35

Yeni Konu

Ghost · 2019-04-07T14:04:02Z

Ghost

2019-04-07 14:04:02 +00:00

yorum yaptı

challenge files are never deleted from disk.
I've traced it to the following line:
core.js:405
gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.keyAuthorization, done);

should be:
gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.token, done);

challenge files are never deleted from disk. I've traced it to the following line: core.js:405 gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.keyAuthorization, done); should be: gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.token, done);

coolaj86

2019-04-07 15:27:20 +00:00

yorum yaptı

Sahibi

Thank you very much, especially for detailing exactly where the bug is.

Updated and published as Greenlock @ v2.7.13

And I apologize for the mess you saw in the code. We're in the process of adding transitional code (like that nasty block you found this bug in, which unfortunately was introduced by the change) to be forwards compatible with the upcoming v3 API so that in the near future the code will be much more consistent, smaller, and easier to test.

Thank you very much, especially for detailing exactly where the bug is. Updated and published as Greenlock @ v2.7.13 And I apologize for the mess you saw in the code. We're in the process of adding transitional code (like that nasty block you found this bug in, which unfortunately was introduced by the change) to be forwards compatible with the upcoming v3 API so that in the near future the code will be much more consistent, smaller, and easier to test.

coolaj86

2019-04-07 15:27:20 +00:00

konusunu kapattı

Bu konuşmaya katılmak için oturum aç.

Etiket Yok

Kilometre Taşı Yok

Atanan Kişi Yok

2 Katılımcı

Bildirimler

Bitiş Tarihi

Bitiş tarihi geçersiz veya aralık dışında. Lütfen 'yyyy-aa-gg' biçimini kullanın.

Bitiş tarihi atanmadı.

Bağımlılıklar

Bağımlılık yok.

Referans: coolaj86/greenlock.js-ARCHIVED#35