challenge files are never deleted #35

建立問題

Ghost · 2019-04-07T14:04:02Z

Ghost " 評論

2019-04-07 14:04:02 +00:00

"

challenge files are never deleted from disk.
I've traced it to the following line:
core.js:405
gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.keyAuthorization, done);

should be:
gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.token, done);

challenge files are never deleted from disk. I've traced it to the following line: core.js:405 gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.keyAuthorization, done); should be: gl.challenges[challenge.type].remove(copy, challenge.altname, challenge.token, done);

coolaj86 " 評論

2019-04-07 15:27:20 +00:00

"

管理員

Thank you very much, especially for detailing exactly where the bug is.

Updated and published as Greenlock @ v2.7.13

And I apologize for the mess you saw in the code. We're in the process of adding transitional code (like that nasty block you found this bug in, which unfortunately was introduced by the change) to be forwards compatible with the upcoming v3 API so that in the near future the code will be much more consistent, smaller, and easier to test.

Thank you very much, especially for detailing exactly where the bug is. Updated and published as Greenlock @ v2.7.13 And I apologize for the mess you saw in the code. We're in the process of adding transitional code (like that nasty block you found this bug in, which unfortunately was introduced by the change) to be forwards compatible with the upcoming v3 API so that in the near future the code will be much more consistent, smaller, and easier to test.

coolaj86 closed this issue

2019-04-07 15:27:20 +00:00

登入才能加入這對話。

未選擇標籤

未選擇里程碑

No Assignees

2 參與者

訊息

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: coolaj86/greenlock.js-ARCHIVED#35