coolaj86
/
greenlock.js-ARCHIVED
3
3
Fork 0
Code Issues 13 Pull Requests 1 Releases Activity
Labels Milestones
New Issue

the major update to rsa-compat should have caused a major version update to greenlock #36

Closed
by Ghost opened 5 years ago · 3 comments
Ghost commented 5 years ago

in v2.6.8 of greenlock, rsa-compat was updated to v2.0.3 from v1.9.2, which is a breaking change. it might have been better to bump greenlock to v3 to signal the breaking change. Our app broke since we are currently on node v8.

in v2.6.8 of greenlock, rsa-compat was updated to v2.0.3 from v1.9.2, which is a breaking change. it might have been better to bump greenlock to v3 to signal the breaking change. Our app broke since we are currently on node v8.
coolaj86 commented 5 years ago
Owner

Can you tell me what broke so I can fix it?

Can you tell me what broke so I can fix it?
coolaj86 commented 5 years ago
Owner

As far as I know there were no breaking changes.

The external dependencies were made explicit and that was it. Everything should still work with node v8.

As far as I know there were no breaking changes. The external dependencies were made explicit and that was it. Everything _should_ still work with node v8.
Ghost commented 5 years ago

our app used to work without the need for ursa. after a deployment it broke here. we found that ursa is now required for our app to work since we are on node < 10.

there is nothing specifically broken now but this hiccup may have been avoided if greenlock had a major version upgrade.

our app used to work without the need for `ursa`. after a deployment it broke [here](https://git.coolaj86.com/coolaj86/rsa-compat.js/src/branch/master/lib/generate-privkey.js#L55). we found that `ursa` is now required for our app to work since we are on node < 10. there is nothing specifically broken now but this hiccup may have been avoided if greenlock had a major version upgrade.
Ghost closed this issue 5 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
acmev2
dns-challenge-regression-fix
github
greenlock
master
next
node-letsencrypt-python
npm
v1
v2
v2.1
v2.2
v2.3
v2.4
v2.5
v3
v4
wip
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes