coolaj86/greenlock.js-ARCHIVED
3
3
Fork 0
Code Issues 6 Pull Requests 1 Releases Activity

the major update to rsa-compat should have caused a major version update to greenlock #36

New Issue
Closed
opened 2019-04-27 10:00:42 +00:00 by Ghost · 3 comments
Ghost commented 2019-04-27 10:00:42 +00:00
Copy Link

in v2.6.8 of greenlock, rsa-compat was updated to v2.0.3 from v1.9.2, which is a breaking change. it might have been better to bump greenlock to v3 to signal the breaking change. Our app broke since we are currently on node v8.

in v2.6.8 of greenlock, rsa-compat was updated to v2.0.3 from v1.9.2, which is a breaking change. it might have been better to bump greenlock to v3 to signal the breaking change. Our app broke since we are currently on node v8.
coolaj86 commented 2019-04-27 15:03:53 +00:00
Owner
Copy Link

Can you tell me what broke so I can fix it?

Can you tell me what broke so I can fix it?
coolaj86 commented 2019-04-27 15:05:05 +00:00
Owner
Copy Link

As far as I know there were no breaking changes.

The external dependencies were made explicit and that was it. Everything should still work with node v8.

As far as I know there were no breaking changes. The external dependencies were made explicit and that was it. Everything _should_ still work with node v8.
Ghost commented 2019-04-27 16:39:19 +00:00
Author
Copy Link

our app used to work without the need for ursa. after a deployment it broke here. we found that ursa is now required for our app to work since we are on node < 10.

there is nothing specifically broken now but this hiccup may have been avoided if greenlock had a major version upgrade.

our app used to work without the need for `ursa`. after a deployment it broke [here](https://git.coolaj86.com/coolaj86/rsa-compat.js/src/branch/master/lib/generate-privkey.js#L55). we found that `ursa` is now required for our app to work since we are on node < 10. there is nothing specifically broken now but this hiccup may have been avoided if greenlock had a major version upgrade.
Ghost closed this issue 2019-04-27 16:39:20 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jshaver coolaj86
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coolaj86/greenlock.js-ARCHIVED#36
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?