the major update to rsa-compat should have caused a major version update to greenlock #36

Cerrada
abierta 2019-04-27 10:00:42 +00:00 por Ghost · 3 comentarios

in v2.6.8 of greenlock, rsa-compat was updated to v2.0.3 from v1.9.2, which is a breaking change. it might have been better to bump greenlock to v3 to signal the breaking change. Our app broke since we are currently on node v8.

in v2.6.8 of greenlock, rsa-compat was updated to v2.0.3 from v1.9.2, which is a breaking change. it might have been better to bump greenlock to v3 to signal the breaking change. Our app broke since we are currently on node v8.
Propietario

Can you tell me what broke so I can fix it?

Can you tell me what broke so I can fix it?
Propietario

As far as I know there were no breaking changes.

The external dependencies were made explicit and that was it. Everything should still work with node v8.

As far as I know there were no breaking changes. The external dependencies were made explicit and that was it. Everything _should_ still work with node v8.
Autoría

our app used to work without the need for ursa. after a deployment it broke here. we found that ursa is now required for our app to work since we are on node < 10.

there is nothing specifically broken now but this hiccup may have been avoided if greenlock had a major version upgrade.

our app used to work without the need for `ursa`. after a deployment it broke [here](https://git.coolaj86.com/coolaj86/rsa-compat.js/src/branch/master/lib/generate-privkey.js#L55). we found that `ursa` is now required for our app to work since we are on node < 10. there is nothing specifically broken now but this hiccup may have been avoided if greenlock had a major version upgrade.
Ghost cerró esta incidencia 2019-04-27 16:39:20 +00:00
Inicie sesión para unirse a esta conversación.
Sin etiquetas
Sin Milestone
No asignados
2 participantes
Notificaciones
Fecha de vencimiento
La fecha de vencimiento es inválida o está fuera de rango. Por favor utilice el formato 'aaaa-mm-dd'.

Sin fecha de vencimiento.

Dependencias

No se han establecido dependencias.

Referencia: coolaj86/greenlock.js-ARCHIVED#36
No se ha proporcionado una descripción.